Arch Linux User Repository

once install with yay, it gives the error

imagelib.c:109:17: error: implicit declaration of function ‘malloc’ [-Wimplicit-function-declaration]
  109 |   rv = (image *)malloc (sizeof(image));
      |                 ^~~~~~
imagelib.c:5:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’
    4 | #include "cards.h"
  +++ |+#include <stdlib.h>
    5 |
imagelib.c:109:17: warning: incompatible implicit declaration of built-in function ‘malloc’ [-Wbuiltin-declaration-mismatch]
  109 |   rv = (image *)malloc (sizeof(image));
      |                 ^~~~~~
imagelib.c:109:17: note: include ‘<stdlib.h>’ or provide a declaration of ‘malloc’

Edit, this ace14_fixes.patch should work:

--- ace-1.4/lib/imagelib.c  2012-03-24 18:00:49.000000000 +0000
+++ ace-1.4/lib/imagelib.c 2024-12-11 13:01:20.736769787 +0000
@@ -2,6 +2,7 @@
 #include <string.h>
 #include "imagelib.h"
 #include "cards.h"
+#include <stdlib.h>

image_list *image_root = 0;
--- ace-1.4/lib/make-imglib.c       2012-03-24 18:00:49.000000000 +0000
+++ ace-1.4/lib/make-imglib.c      2024-12-11 13:50:18.723471957 +0000
@@ -8,6 +8,8 @@
#include <png.h>
+#include <ctype.h>
+
 static int verbose = 0;
 static char basename = "images";
 static char imagedir = ".";
@@ -202,7 +204,7 @@
   char rv;
   if (string) {
     next = string;
-    return;
+    return string;
   }
   while (next && !isgraph(next)) next++;
   if (!next) return 0;
@@ -353,3 +355,4 @@
exit(0);
 }
+

I'll let you maintain the patch.

Editing this comment, please ignore the font change in help.c. I managed to get the fonts working on the Steam Deck. I had to install the xorg-fonts-100dpi, but then after it copy /usr/share/fonts/100dpi to ~/.local/share/fonts , go into the local font dir and do mkfontdir, and then do "xset +fp ~/.local/share/fonts/100dpi". After rebooting the fonts finally showed up for X.

Again, most arch installs will work fine, but the Steam Deck is stripped down.

Wanting to get this running on the Steam Deck even after the patch it needed a couple of tweaks to get it running. First, even after installing xorg-fonts-100dpi, still couldn't find the fonts needed, so in lib/help.c changed both of the XLoadQueryFont lines to use font "-misc-fixed-medium-*-*-*-*-*-*-*-*-*-*-*"

Additionally I had a problem where Freecell and Merlin wouldn't work. Both would fail on startup with a BadMatch. I've seen this issue listed on other Arch forums.

The fix I have is "good enough". It fixes the BadMatch and I don't see any graphical issues, but I didn't continue more up in the code path to figure out why the bad values are coming in. Anyway the fix is:

-- ../../../penguins_orig/ace-1.4/lib/table.c  2012-03-24 14:00:49.000000000 -0400
+++ ./table.c   2022-11-21 05:36:11.183763096 -0500
@@ -216,7 +216,7 @@
   printf("copy clip: x=%3d y=%3d w=%3d h=%3d (ex=%d ey=%d ew=%d eh=%d)\n",
         dx+x, dy+y, w, h, ex, ey, ew, eh);
 #endif
-  if (w>0 && h>0)
+  if (w>0 && h>0 && !(w == 1 && h == 1 && (dx+x) == 0 && (dy+y) == 0))
   {
 #if TRACE_PICTURES
     printf("copy aft: x=%3d y=%3d w=%3d h=%3d\n", dx+x, dy+y, w, h);

@kleintug Thanks a lot!

And thank you for keeping it up!

@sng thx for the patch. adopted the package and added your patch. I list you under the contributors. cheers.

ok, fixed it... I just added this to ace14_fixes.patch

--- ace-1.4/lib/xwin.c  2020-10-07 02:07:59.000000000 +0300
+++ ace14/lib/xwin.c    2020-10-07 02:15:05.941784967 +0300
@@ -55,7 +55,6 @@
   { "-visual", OPTION_INTEGER, &visual_id },
   { 0, 0, 0 }
 };
-OptionDesc *xwin_options = xwin_options_list;

 Display *display=0;
 int screen=0;

This is on a fresh install...

/bin/sh ../libtool --tag=CC   --mode=link gcc  -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong --param=ssp-buffer-size=4 -version-info 1:0:0  -Wl,-O1,--sort-common,--as-needed,-z,relro -lpng -lz -lm -o libcards.la -rpath /usr/lib table.lo help.lo stack.lo imagelib.lo xwin.lo images.lo table_rn.lo funcs.lo  
libtool: link: gcc -shared  .libs/table.o .libs/help.o .libs/stack.o .libs/imagelib.o .libs/xwin.o .libs/images.o .libs/table_rn.o .libs/funcs.o   -lpng -lz -lm  -march=x86-64 -mtune=generic -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z -Wl,relro   -Wl,-soname -Wl,libcards.so.1 -o .libs/libcards.so.1.0.0
/usr/bin/ld: .libs/xwin.o:(.data.rel+0x40): multiple definition of `xwin_options'; .libs/table.o:(.bss+0x8): first defined here
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:303: libcards.la] Error 1
make[1]: Leaving directory '/home/user/.cache/yay/ace-of-penguins/src/ace-1.4/lib'
make: *** [Makefile:281: all-recursive] Error 1
==> ERROR: A failure occurred in build().
    Aborting...
error making: ace-of-penguins

Anyone can help?