Arch Linux User Repository

Ahoj,

↗ Here and below a diff between the current PKGBUILD and a suggested PKGBUILD that

• unifies indentation: Use only spaces (previously, spaces and tabs were used) and unified indentation width,
• removes spourious trailing space after make,
• explicitly states more build options,
• removes --enable-ccache,
• adds versioned provides,
• adds the git log to the documentation,
• specifies the GPL version,
• makes optdepends more verbose.

Feel free to use what you find useful.

Regards and thanks for maintaining this actually working fork of aMule!

--- PKGBUILD.orig   2023-10-12 13:29:22.727181545 +0200
+++ PKGBUILD    2023-10-12 13:32:54.943862795 +0200
@@ -13,3 +13,3 @@
 url="https://github.com/persmule/amule-dlp"
-license=('GPL')
+license=('GPL2')
 depends=('wxwidgets-gtk3' 'gd' 'geoip' 'libupnp' 'crypto++>=6.0.0' 'libsm' 'boost-libs')
@@ -17,9 +17,12 @@
 makedepends=('git' 'boost')
-optdepends=('antileech')
+optdepends=(
+  'antileech: To use the antileech functionality.'
+  'perl: For xas plugin (xChat2).'
+)
 install=amule.install
-provides=('amule' 'amule-dlp')
+provides=("amule=${pkgver}" "amule-dlp=${pkgver}")
 source=("git+https://github.com/persmule/amule-dlp.git"
         'amuled.systemd'
-       'amuleweb.systemd'
-       '0001-allow-to-build-with-autoconf-2.70-and-later.patch')
+        'amuleweb.systemd'
+        '0001-allow-to-build-with-autoconf-2.70-and-later.patch')
 sha256sums=('SKIP'
@@ -32,3 +35,3 @@
   printf "%s.r%s.%s" "$(grep -Po '(?<=set \(PACKAGE_VERSION ").+(?="\))' ./CMakeLists.txt)" \
-                   "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
+         "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
 }
@@ -39,2 +42,4 @@
   patch -p1 < ../0001-allow-to-build-with-autoconf-2.70-and-later.patch
+
+  git log > "${srcdir}/git.log"
 }
@@ -46,24 +51,34 @@
   ./configure \
-     --prefix=/usr \
-     --mandir=/usr/share/man \
-     --disable-debug \
-     --enable-amule-daemon \
-     --enable-amulecmd \
-     --enable-amule-gui \
-     --enable-webserver \
-     --enable-cas \
-     --enable-wxcas \
-     --enable-alc \
-     --enable-alcc \
-     --enable-geoip \
-     --enable-upnp \
-     --with-denoise-level=3 \
-     --enable-nls \
-     --enable-optimize \
-     --enable-mmap \
-     --enable-ccache \
-     --with-boost \
-     --with-wxversion=3.2
+    --prefix=/usr \
+    --mandir=/usr/share/man \
+    --disable-debug \
+    --disable-bfd \
+    --enable-monolithic \
+    --enable-amule-daemon \
+    --enable-amulecmd \
+    --enable-amule-gui \
+    --enable-webserver \
+    --enable-cas \
+    --enable-wxcas \
+    --enable-ed2k \
+    --enable-alc \
+    --enable-alcc \
+    --enable-xas \
+    --enable-fileview \
+    --disable-plasmamule \
+    --enable-shared \
+    --disable-static \
+    --disable-kde-in-home \
+    --enable-dlp \
+    --enable-geoip \
+    --enable-upnp \
+    --with-denoise-level=3 \
+    --disable-rpath \
+    --enable-nls \
+    --enable-optimize \
+    --enable-mmap \
+    --with-boost \
+    --with-wxversion=3.2

-  make 
+  make
 }
@@ -77,2 +92,4 @@
   install -D -m644 "${srcdir}/amuleweb.systemd" "${pkgdir}/usr/lib/systemd/system/amuleweb.service"
+
+  install -D -m644 "${srcdir}/git.log" "${pkgdir}/usr/share/doc/amule-dlp/git.log"
 }

Ahoj,

the $install file says

If you want the antileech function, you have to install amule-dlp-libantileech-git.

But there is no package amule-dlp-libantileech-git. And optdepends mentions the package antileech.

Is the former maybe a leftover error?

Regards!

You compile with --enable-ccache.
But what if ccache is not installed?

Regards!

Ahoj,

thanks for the package!

can you add =${pkgver} to the provides entries, please?

This would allow versioned dependencies on amule work.

Regards!

As of July 17, 2023, PKGBUILD has been updated for compatibility with wxWidgets-gtk3 version 3.2. Unfortunately, a bug exists in wxWidgets cmake setup. A fix illustrating the abovementioned bug has been merged, but not available in the latest release yet. One may want to cherry-pick the corresponding commit and compile the wxWidgets packages locally.

The upstream maintainer has disappeared for eighteen months. For build failures related to recent wx updates, you probably want to check the non-dlp version.

Build failed:

checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether make supports nested variables... (cached) yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking if this is a FreeBSD 4 or earlier system... no
checking for g++... g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C++... yes
checking whether g++ accepts -g... yes
checking for g++ option to enable C++11 features... none needed
checking whether make supports the include directive... yes (GNU style)
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for gcc... gcc
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for gawk... (cached) gawk
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking whether make sets $(MAKE)... (cached) yes
checking for ranlib... ranlib
checking for a sed that does not truncate output... /usr/bin/sed
checking for ranlib... (cached) ranlib
checking for strip... strip
checking for ar... ar
checking for ld... ld
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for gdlib... yes (version 2.3.3)
checking for gd.h... yes
checking for _Bool... yes
checking for stdbool.h that conforms to C99... yes
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for working volatile... yes
checking for zlib >= 1.1.4... yes (version 1.2.12)
checking for libpng-config... /usr/bin/libpng-config
checking for libpng version >= 1.2.0... yes (version 1.6.37)
checking if libpng is usable... yes
checking for GeoIP.h... yes
checking for GeoIP_open in -lGeoIP... yes
checking for the --with-toolkit option... will be automatically detected
checking for the --with-wxshared option... will be automatically detected
checking for the --with-wxdebug option... will be automatically detected
checking for the --with-wxversion option... 3.0
checking for wx-config... no
configure: error: 
        wxWidgets must be installed on your system but wx-config
        script couldn't be found. Please check that wx-config is
        in path or specified by --with-wx-config=path flag, the
        directory where wxWidgets libraries are installed (returned
        by 'wx-config --libs' command) is in LD_LIBRARY_PATH or
        equivalent variable and wxWidgets version is 2.8.12 or above.

add crypto++6 patch https://git.archlinux.org/svntogit/community.git/tree/trunk/amule-cryptopp6.patch?h=packages/amule