Package Details: arch-update-helper 2.0.0-1

Git Clone URL: https://aur.archlinux.org/arch-update-helper.git (read-only, click to copy)
Package Base: arch-update-helper
Description: A Systray Utility for Checking Arch Linux Updates and Installing Them
Upstream URL: https://github.com/silverhadch/arch-update-helper
Licenses: GPL-3.0-or-later
Submitter: silverhadch
Maintainer: silverhadch
Last Packager: silverhadch
Votes: 1
Popularity: 0.71
First Submitted: 2025-01-13 10:11 (UTC)
Last Updated: 2025-01-14 17:38 (UTC)

Latest Comments

Antiz commented on 2025-01-16 16:12 (UTC)

@silverhadch, we have specific sets of option we usually use to build packages with cmake. This is described in the page I linked in my previous comments.

You can take a look at the PKGBUILD Template [1] we usually use for cmake stuff. See from there what's relevant and can be applied for your PKGBUILD :)

[1] https://wiki.archlinux.org/title/CMake_package_guidelines#Template

silverhadch commented on 2025-01-16 15:12 (UTC)

@Antiz No problem. However i am not finding anything in the guidelines i still need to do. Would you mind telling me where exactly in which section of the Wiki i should look or better directly tell me what should be applied. Thanks

Antiz commented on 2025-01-14 20:35 (UTC)

No worries, thanks for your quick actions addressing most issues :)

You could still apply the cmake packaging guidelines [1].
Other than that, it looks better now ;)

[1] https://wiki.archlinux.org/title/CMake_package_guidelines

Antiz commented on 2025-01-14 10:17 (UTC) (edited on 2025-01-14 10:20 (UTC) by Antiz)

Hi,

There are multiple issues with this PKGBUILD:

  • No need to specify $pkgbase if it's the same as $pkgname, that's already the case by default. [1]
  • arch=('any') is wrong, this package is compiled for specific architectures so it should list specific architectures it can be built for (at least requires x86_64). [2]
  • GPL3 is not a valid SPDX License identifier. It should either be GPL-3.0-only or GPL-3.0-or-later. [3]
  • cmake should be listed in makedepends rather than depends as it is only needed at build time. [4] [5]
  • Currently this package silently builds arch-update-helper against the latest upstream commit rather than against a stable version. The 1.0.3 value for $pkgver is confusing and superfluous as there's no correlation between it and the built source. This package should either be renamed arch-update-helper-git (to reflect that is a VCS package [6]) or it should point to stable releases / tags in the source array (note that the upstream repo doesn't contain any release or tag yet).
  • No need to cd to $srcdir in functions. They are already executed from there. cd $pkgname is enough.
  • The Arch cmake packaging guidelines are not applied. [7]
  • You shouldn't use /etc/skel to create configuration files in user's $HOME/.config. The creation of such a config file / folder under $HOME/.config should either be done by the user themselves or handled by the software itself.
  • Shipping desktop file directly in /etc/xdg/autostart is unusual. First of all, not every Desktop Environment / Window Manager support the XDG Autostart specification (so it might not work for everyone). Secondly, desktop files are usually shipped under /usr/share/applications/ and it's then up to users to decide if they want to autostart the related app / software or not. [8]

I hope that helps! :)

[1] https://wiki.archlinux.org/title/PKGBUILD#pkgbase
[2] https://wiki.archlinux.org/title/PKGBUILD#arch
[3] https://wiki.archlinux.org/title/PKGBUILD#license
[4] https://wiki.archlinux.org/title/PKGBUILD#depends
[5] https://wiki.archlinux.org/title/PKGBUILD#makedepends
[6] https://wiki.archlinux.org/title/VCS_package_guidelines
[7] https://wiki.archlinux.org/title/CMake_package_guidelines
[8] https://wiki.archlinux.org/title/Autostarting