Arch Linux User Repository

I get build error, i didn't find any place to report issue upstream

[ 78%] Building CXX object ADM_videoFilters6/blend/CMakeFiles/ADM_vf_blend.dir/ADM_vidBlendFrames.cpp.o
[ 79%] Building CXX object ADM_videoFilters6/avsfilter/CMakeFiles/ADM_vf_avsfilter.dir/avsfilterparam_json.cpp.o
[ 79%] Linking CXX shared library libADM_vf_blend.so
[ 79%] Linking CXX shared library libADM_vf_avsfilter.so
/home/fre/ARCH-AUR/avidemux-git/src/avidemux/avidemux_plugins/ADM_videoEncoder/x265/ADM_x265.cpp: In member function ‘virtual bool x265Encoder::encode(ADMBitstream*)’:
/home/fre/ARCH-AUR/avidemux-git/src/avidemux/avidemux_plugins/ADM_videoEncoder/x265/ADM_x265.cpp:216:66: error: cannot convert ‘x265_picture*’ to ‘x265_picture**’ in argument passing
  216 |             er = api->encoder_encode(handle, &nal, &nbNal, NULL, &pic_out);
      |                                                                  ^~~~~~~~
      |                                                                  |
      |                                                                  x265_picture*
/home/fre/ARCH-AUR/avidemux-git/src/avidemux/avidemux_plugins/ADM_videoEncoder/x265/ADM_x265.cpp:224:66: error: cannot convert ‘x265_picture*’ to ‘x265_picture**’ in argument passing
  224 |             er = api->encoder_encode(handle, &nal, &nbNal, &pic, &pic_out);
      |                                                                  ^~~~~~~~
      |                                                                  |
      |                                                                  x265_picture*
make[2]: *** [ADM_videoEncoder/x265/CMakeFiles/ADM_ve_x265_other.dir/build.make:93: ADM_videoEncoder/x265/CMakeFiles/ADM_ve_x265_other.dir/ADM_x265.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:6045: ADM_videoEncoder/x265/CMakeFiles/ADM_ve_x265_other.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 79%] Built target freetype_probe
[ 79%] Built target ADM_vf_blend
[ 79%] Built target ADM_vf_avsfilter
make: *** [Makefile:136: all] Error 2

It builds fine after disabling this

  # add SETTINGS to MESSAGE(FATAL_ERROR in avidemux_plugins/CMakeLists.txt
  # patch -p1 -i "${srcdir}/add_settings_pluginui_message_error.patch"

Build errors
makepkg -sicC

==> Starting prepare()...
patching file cmake/admCoreIncludes.cmake
patching file avidemux_plugins/CMakeLists.txt
Hunk #1 FAILED at 88.
1 out of 1 hunk FAILED -- saving rejects to file avidemux_plugins/CMakeLists.txt.rej
==> ERROR: A failure occurred in prepare().

Looks like there is a mistake in PKGBUILD in the prepare() function at
# fix build ffmpeg about ASM encode
I substituted the path without quotation marks with ./ and finally got the package

I've shared it on the Avidemux Forum. I plan to create a pull request if it seems like it would be accepted and that this is the way they want it implemented.

So far, it has been recommended to drop the '6' from the directory name since it is there for historical reasons and no longer needed. And also the use of XDG_CONFIG_HOME instead of XDG_DATA_HOME.

can you fill a issue/request in upstream?

Here's a patch to make avidemux XDG compliant if anyone else is interested:

diff --git a/avidemux_core/ADM_core/src/ADM_folder_linux.cpp b/avidemux_core/ADM_core/src/ADM_folder_linux.cpp
index 4288c28e7..9d6449ec9 100644
--- a/avidemux_core/ADM_core/src/ADM_folder_linux.cpp
+++ b/avidemux_core/ADM_core/src/ADM_folder_linux.cpp
@@ -155,17 +155,28 @@ const char *ADM_getBaseDir(void)

 void ADM_initBaseDir(int argc, char *argv[])
 {
-   const char* homeEnv = getenv("HOME");
+    char* homeEnv = getenv("XDG_DATA_HOME");

-   if (!homeEnv)
-   {
+    if (homeEnv)
+    {
+        strcpy(ADM_basedir, homeEnv);
+    } else {
+        homeEnv = getenv("HOME");
+        if (homeEnv)
+        {
+            strcpy(ADM_basedir, homeEnv);
+            strcat(ADM_basedir, "/.local/share");
+        }
+    }
+
+    if (!homeEnv)
+    {
         ADM_warning("Cannot locate HOME...\n");
         return;
     }
-    strcpy(ADM_basedir, homeEnv);
     AddSeparator(ADM_basedir);

-    const char *ADM_DIR_NAME = ".avidemux6";
+    const char *ADM_DIR_NAME = "avidemux6";

     strcat(ADM_basedir, ADM_DIR_NAME);
     strcat(ADM_basedir, ADM_SEPARATOR);
@@ -176,7 +187,7 @@ void ADM_initBaseDir(int argc, char *argv[])
     }
     else
     {
-        ADM_error("Oops: cannot create the .avidemux directoryi (%s)\n", ADM_basedir);
+        ADM_error("Oops: cannot create the avidemux directoryi (%s)\n", ADM_basedir);
     }

     if(isPortableMode(argc,argv))

please rework you post. is hard to read. please use markdown text

greetings

EDIT: also, report it to upstream: https://avidemux.org/smif/index.php

Correct ffmpeg build failure (ffmpeg is fixed upstream, but the avidemux version needs patched. Maybe use a submodule?)

in PKGBUILD:

... build() { msg2 "Build Core Libs" cmake -B build_core -S avidemux/avidemux_core \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_PREFIX=/usr \ -DFAKEROOT="${srcdir}/fakeroot" \ -DAVIDEMUX_SOURCE_DIR="${srcdir}/avidemux"

#insert patch here (build_core is not available at the prepare() stage): cd $srcdir patch -p1 < $BUILDDIR/mathops.h.patch

cmake --build build_core ...

mathops.h.patch (adapted from upstream):

diff --git a/build_core/ffmpeg/source/libavcodec/x86/mathops.h b/build_core/ffmpeg/source/libavcodec/x86/mathops.h index 6298f5ed19..1a1578a0c4 100644 --- a/build_core/ffmpeg/source/libavcodec/x86/mathops.h +++ b/build_core/ffmpeg/source/libavcodec/x86/mathops.h @@ -113,21 +113,32 @@ asm volatile(\ // avoid +32 for shift optimization (gcc should do that ...) #define NEG_SSR32 NEG_SSR32 static inline int32_t NEG_SSR32( int32_t a, int8_t s){ + if (builtin_constant_p(s)) __asm ("sarl %1, %0\n\t" : "+r" (a) - : "ic" ((uint8_t)(-s)) + : "i" (-s & 0x1F) ); + else + asm ("sarl %1, %0\n\t" + : "+r" (a) + : "c" ((uint8_t)(-s)) + ); return a; }

#define NEG_USR32 NEG_USR32 static inline uint32_t NEG_USR32(uint32_t a, int8_t s){ + if (builtin_constant_p(s)) __asm ("shrl %1, %0\n\t" : "+r" (a) - : "ic" ((uint8_t)(-s)) + : "i" (-s & 0x1F) ); + else + asm ("shrl %1, %0\n\t" + : "+r" (a) + : "c" ((uint8_t)(-s)) + ); return a; } - #endif / HAVE_INLINE_ASM / #endif / AVCODEC_X86_MATHOPS_H /

Optional: Get rid of ugly slider:

--- avidemux/qt4/ADM_userInterfaces/ADM_gui/Q_gui2.cpp 2018-06-14 18:55:42.216958656 +0200 +++ avidemux/qt4/ADM_userInterfaces/ADM_gui/Q_gui2.cpp 2018-06-14 18:55:50.939958572 +0200 @@ -398,10 +398,10 @@ ADM_mwNavSlider qslider=(ADM_mwNavSlider )slider; slider->setMinimum(0); slider->setMaximum(ADM_LARGE_SCALE); -#if !(defined(APPLE) && QT_VERSION >= QT_VERSION_CHECK(5,10,0)) +/#if !(defined(APPLE) && QT_VERSION >= QT_VERSION_CHECK(5,10,0)) slider->setTickInterval(ADM_SCALE_INCREMENT); slider->setTickPosition(QSlider::TicksBothSides); -#endif +#endif / connect( slider,SIGNAL(valueChanged(int)),this,SLOT(sliderValueChanged(int))); connect( slider,SIGNAL(sliderMoved(int)),this,SLOT(sliderMoved(int))); connect( slider,SIGNAL(sliderReleased()),this,SLOT(sliderReleased()));

Fix typo:

--- avidemux_plugins/ADM_muxers/muxerffPS/muxerffPSPlugin.cpp +++ avidemux_plugins/ADM_muxers/muxerffPS/muxerffPSPlugin.cpp @@ -25,7 +25,7 @@ ADM_MUXER_BEGIN( "mpg",muxerffPS, 1,0,0, "ffPS", // Internal name "ffMpeg PS muxer plugin (c) Mean 2009", - "Mpeg-PS Muxer( ff)", // DIsplay name + "Mpeg-PS Muxer (ff)", // Display name ffPSConfigure, ps_muxer_param, //template &psMuxerConfig, //config --- avidemux_plugins/ADM_muxers/muxerffTS/muxerffTSPlugin.cpp +++ avidemux_plugins/ADM_muxers/muxerffTS/muxerffTSPlugin.cpp @@ -34,7 +34,7 @@ ADM_MUXER_DYN_EXT( 1,0,1, "ffTS", // Internal name "ffMpeg TS muxer plugin (c) Mean 2009", - "Mpeg TS Muxer (ff)", // Display name + "Mpeg-TS Muxer (ff)", // Display name ffTSConfigure, ts_muxer_param, // template &tsMuxerConfig, // config

Edit: No sensible code block handling? Get the mathops patch from upstream.

simply pacman -Sd libvpx and then rebuild avidemux