These tests are there for the developers of aws-cli to ensure features built are actually working and no regressions are introduced from version to version; they're not really meant as target platform integration tests.
So, when a test failure would occur, there wouldn't be a new release since that would've been caught on upstream side already. As such you could argue it is not really necessary to run them on package build.
However, the package does patch quite some stuff, so after all it is justified a bit. It seems, though, that these tests do pick up the environment and user-specific configuration that exists in the context where these tests are run. For the package it means it uses all env vars and $HOME/.aws/{credentials,config}
and that really is a problem since many of us might have real credentials there...
These tests should have some kind of jail and a separate user where they're run (eg. for me the test suite finally breaks with an assertion that 'eu-central-1' != 'us-mars-2'
- where eu-central-1 is the region configured in my $HOME/.aws/credentials).
PS: Thank you for providing this package!
UPDATE: Found out that you can build packages in a chroot, with paru's --chroot
option and this solves everything. I will enable this option in /etc/paru.conf
for all the builds.
Pinned Comments
kstolp commented on 2024-10-23 05:14 (UTC)
If you receive this error when trying to build, it is because you have not imported the GPG keys used for verification.
You have two options:
1) Import the key into your keyring. ArchWiki article. The key is available in this repo, which is copied from the AWS documentation. e.g.
gpg --import keys/pgp/FB5DB77FD5C118B80511ADA8A6310ACC4672475C.asc
. (recommended)2) Alternatively, you can skip this verification by passing the
--skippgpcheck
argument tomakepkg
when building. (not recommended)