Arch Linux User Repository

Oh, nice! Thanks a lot!

Hi @exploder-jimmy,

Thanks for the nice recommendations. I applied them, as well as added the missing libyaml dependency, in this commit.

Hi!

Are shards really required as hard dependency? Isn't it just a make dependency?

It seems to be working fine without it installed, but I'm not sure...

Could you please define the CRYSTAL_CACHE_DIR environment variable in build() and check() functions, so that it won't put anything in home cache dir?

And you might also use some bash parameter expansion, like _pkgname="${pkgname^^}"

Anyway, if you are interested, here's the patch. Thank you.

diff --git a/PKGBUILD b/PKGBUILD
index 5dfaad9..e390ecb 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,25 +1,26 @@
 # Maintainer: Robin Candau <antiz@archlinux.org>

 pkgname=blahaj
-_pkgname=BLAHAJ
+_pkgname="${pkgname^^}"
 pkgver=2.0.1
-pkgrel=1
+pkgrel=2
 pkgdesc="Gay sharks at your local terminal - lolcat-like CLI tool"
 arch=('x86_64')
 url="https://blahaj.queer.software"
 license=('BSD')
-depends=('crystal' 'shards')
-source=("${pkgname}-${pkgver}.tar.gz::https://github.com/GeopJr/BLAHAJ/archive/v${pkgver}.tar.gz")
+depends=('crystal')
+makedepends=('shards')
+source=("${pkgname}-${pkgver}.tar.gz::https://github.com/GeopJr/${_pkgname}/archive/v${pkgver}.tar.gz")
 sha256sums=('04d6b8e1b5f151c7c04335f758e4184408d12cfa024abd7583a25e933b681cbc')

 build () {
        cd "${_pkgname}-${pkgver}"
-       make build_mt
+       CRYSTAL_CACHE_DIR="${srcdir}/crystal" make build_mt
 }

 check () {
        cd "${_pkgname}-${pkgver}"
-       make test_mt
+       CRYSTAL_CACHE_DIR="${srcdir}/crystal" make test_mt
 }

 package() {