Arch Linux User Repository

hello, i tried installing this package today, i'm getting errors after a minute of compilation:

In file included from src/type_id.h:7,
                 from src/damage.h:11,
                 from src/veh_type.h:20,
                 from src/veh_type.cpp:1:
In member function ‘bool string_id<T>::operator<(const This&) const [with T = ammunition_type]’,
    inlined from ‘constexpr bool std::less<_Tp>::operator()(const _Tp&, const _Tp&) const [with _Tp = string_id<ammunition_type>]’ at /usr/include/c++/12.1.0/bits/stl_function.h:408:20,
    inlined from ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::find(const _Key&) const [with _Key = string_id<ammunition_type>; _Val = string_id<ammunition_type>; _KeyOfValue = std::_Identity<string_id<ammunition_type> >; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_tree.h:2546:33,
    inlined from ‘std::set<_Key, _Compare, _Alloc>::size_type std::set<_Key, _Compare, _Alloc>::count(const key_type&) const [with _Key = string_id<ammunition_type>; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_set.h:749:25,
    inlined from ‘static void vehicle_prototype::finalize()’ at src/veh_type.cpp:1268:61:
src/string_id.h:229:24: error: array subscript 0 is outside array bounds of ‘ammotype [0]’ [-Werror=array-bounds]
  229 |             return _id._id < rhs._id._id;
      |                    ~~~~^~~
In member function ‘bool string_id<T>::operator<(const This&) const [with T = ammunition_type]’,
    inlined from ‘constexpr bool std::less<_Tp>::operator()(const _Tp&, const _Tp&) const [with _Tp = string_id<ammunition_type>]’ at /usr/include/c++/12.1.0/bits/stl_function.h:408:20,
    inlined from ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_lower_bound(_Const_Link_type, _Const_Base_ptr, const _Key&) const [with _Key = string_id<ammunition_type>; _Val = string_id<ammunition_type>; _KeyOfValue = std::_Identity<string_id<ammunition_type> >; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_tree.h:1967:29,
    inlined from ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::const_iterator std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::find(const _Key&) const [with _Key = string_id<ammunition_type>; _Val = string_id<ammunition_type>; _KeyOfValue = std::_Identity<string_id<ammunition_type> >; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_tree.h:2544:42,
    inlined from ‘std::set<_Key, _Compare, _Alloc>::size_type std::set<_Key, _Compare, _Alloc>::count(const key_type&) const [with _Key = string_id<ammunition_type>; _Compare = std::less<string_id<ammunition_type> >; _Alloc = std::allocator<string_id<ammunition_type> >]’ at /usr/include/c++/12.1.0/bits/stl_set.h:749:25,
    inlined from ‘static void vehicle_prototype::finalize()’ at src/veh_type.cpp:1268:61:
src/string_id.h:229:38: error: array subscript 0 is outside array bounds of ‘ammotype [0]’ [-Werror=array-bounds]
  229 |             return _id._id < rhs._id._id;
      |                              ~~~~~~~~^~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
make: *** [Makefile:950: obj/veh_type.o] Error 1
make: *** Waiting for unfinished jobs....
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: cataclysm-dda-git

i could not find anything about this error on game's github

EDIT: i fixed this by patching Makefile:

diff --git a/Makefile b/Makefile
index 56418b4be7a6..39a333e7af9a 100644
--- a/Makefile
+++ b/Makefile
@@ -109,7 +109,8 @@ WARNINGS = \
   -Wsuggest-override \
   -Wunused-macros \
   -Wzero-as-null-pointer-constant \
-  -Wno-unknown-warning-option
+  -Wno-unknown-warning-option \
+  -Wno-array-bounds
 # Uncomment below to disable warnings
 #WARNINGS = -w
 DEBUGSYMS = -g

Happy that I could help !

Oh I didnt know about that option, even better! Thanks for pointing that out gileri

Thanks for the suggestion matthemsteger. Why not put it directly in /etc/makepkg.conf ?

One suggestion for this package. I typically edit the PKGBUILD locally before building to add "-jnproc" to the make for builds so that it uses more than a single core (otherwise the build takes a very long time), in this case nproc returns the number of cores your system has.

Im not sure if nproc is appropriate for everyone .. it taxes your system quite a lot, but a suggestion would be to use some variation of "-j" to use more than a single core.

For those wanting to do the same ..

  make -j`nproc` PREFIX=/usr RELEASE=1 USE_XDG_DIR=1 LANGUAGE="all" RUNTESTS=0 LINTJSON=0 ASTYLE=0 PCH=0
  make -j`nproc` PREFIX=/usr RELEASE=1 USE_XDG_DIR=1 LANGUAGE="all" RUNTESTS=0 LINTJSON=0 ASTYLE=0 PCH=0 TILES=1 SOUND=1

What is the easiest way to use both stable and experimental?

Thank you for previously maintaining it @MarsSeed ! @Faalgorn I'll take a look soon.

I have triggered this package to become orphaned, so a new volunteer can adopt it and update it.

Mind bumping the version to 0.F? Would make it green on https://repology.org/project/cataclysm-dda/versions