@fabiscafe True. Maybe it's the lack of coffee.
pacman -Syyu coffee-with-extra-caffeine
:)
Git Clone URL: | https://aur.archlinux.org/czkawka.git (read-only, click to copy) |
---|---|
Package Base: | czkawka |
Description: | Multi functional app to find duplicates, empty folders, similar images etc. (Desktop App) |
Upstream URL: | https://github.com/qarmin/czkawka |
Licenses: | LicenseRef-MIT AND CC-BY-4.0 |
Submitter: | fabiscafe |
Maintainer: | fabiscafe |
Last Packager: | fabiscafe |
Votes: | 37 |
Popularity: | 0.74 |
First Submitted: | 2021-08-09 09:49 (UTC) |
Last Updated: | 2024-10-13 11:20 (UTC) |
@fabiscafe True. Maybe it's the lack of coffee.
pacman -Syyu coffee-with-extra-caffeine
:)
@flan_suse In my opinion the conflicts should only be aded to the non-stable non-source packages (-git, -bin, …).
For the provides - I don't see any benefit to have this added. :s
I think the following should be added to this PKGBUILD to avoid collision:
conflicts=('czkawka-gui-bin','czkawka-cli-bin')
provides=('czkawka')
@exploder-jimmy Thanks I added the change. 👍👍
the pkgrel "0.x" however is not a bug, but my "new" naming scheme. So packages that might get imported to Arch at some point can be upgraded gracefully, instead of a manual downgrade.
Also please consider this patch.
With export CARGO_HOME="${srcdir}/cargo"
, cargo won't create anything unnecessary in user $HOME dir during build.
Thanks.
diff --git a/PKGBUILD b/PKGBUILD
index f334c58..4c6f8c8 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -6,7 +6,7 @@ pkgname=(
czkawka-gui
)
pkgver=6.0.0
-pkgrel=0.1
+pkgrel=2
pkgdesc='Multi functional app to find duplicates, empty folders, similar images etc.'
url='https://github.com/qarmin/czkawka'
arch=(
@@ -37,12 +37,14 @@ pkgver() {
build() {
cd ${pkgbase}
+ export CARGO_HOME="${srcdir}/cargo"
cargo build --bin czkawka_cli --release --features heif
cargo build --bin czkawka_gui --release --features heif
}
check() {
cd ${pkgbase}
+ export CARGO_HOME="${srcdir}/cargo"
cargo test --bin czkawka_cli --release
dbus-run-session xvfb-run -s '-nolisten local' \
cargo test --bin czkawka_gui --release
Please fix line 9 pkgrel=0.1
=> pkgrel=1
This PKGBUILD uses signed commits. If not done you need to import GitHubs (web-flow) public pgp key.
curl -sS https://github.com/web-flow.gpg | gpg --import -
https://gitlab.archlinux.org/fabiscafe/czkawka_aur
Build takes a long time for --release builds: https://github.com/rust-lang/rust/issues/121354
@Raansu Thanks. I updated the arch to include ALARM and AL32. For the other change, thats not on my part. The -bin and -git PKGBUILDS need to specify a provides and conflicts array. The "non"-git/-bin PKGBUILD is the base provider.
@fabiscafe It conflicts these other two https://aur.archlinux.org/packages/czkawka-gui-bin https://aur.archlinux.org/packages/czkawka-git
And it allows other packages or package groups to include a dependency for 'czkawka-gui'. Maybe also include a conflict and provides for czkawka
and czkawka-cli
for the same reasons as well please.
But to add to this, can you please change arch to include this arch=('x86_64' 'aarch64' 'armv7h')
? This appears to compile and work fine on ARM based computers. I compiled this pkgbuild for a Raspberry Pi 4 running Manjaro-ARM after modifying that line.
@proledatarian why?
Pinned Comments
fabiscafe commented on 2023-06-11 14:41 (UTC) (edited on 2024-02-21 16:45 (UTC) by fabiscafe)
Key Import
This PKGBUILD uses signed commits. If not done you need to import GitHubs (web-flow) public pgp key.
Merge/Pull Requests
https://gitlab.archlinux.org/fabiscafe/czkawka_aur
Known issues
Build takes a long time for --release builds: https://github.com/rust-lang/rust/issues/121354