Arch Linux User Repository

Build fails for 6.6.3-arch1-1:

$ cat /var/lib/dkms/frandom/1.2/build/make.log
DKMS make.log for frandom-1.2 for kernel 6.6.3-arch1-1 (x86_64)
śro, 29 lis 2023, 18:07:59 CET
make -C /lib/modules/6.6.3-arch1-1/build M=/var/lib/dkms/frandom/1.2/build modules
make[1]: Wejście do katalogu '/usr/lib/modules/6.6.3-arch1-1/build'
  CC [M]  /var/lib/dkms/frandom/1.2/build/frandom.o
In file included from ./include/linux/linkage.h:7,
                 from ./arch/x86/include/asm/cache.h:5,
                 from ./include/linux/cache.h:6,
                 from ./include/linux/time.h:5,
                 from ./include/linux/stat.h:19,
                 from ./include/linux/module.h:13,
                 from /var/lib/dkms/frandom/1.2/build/frandom.c:17:
/var/lib/dkms/frandom/1.2/build/frandom.c: In function ‘frandom_init_module’:
./include/linux/export.h:29:22: error: passing argument 1 of ‘class_create’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   29 | #define THIS_MODULE (&__this_module)
      |                     ~^~~~~~~~~~~~~~~
      |                      |
      |                      struct module *
/var/lib/dkms/frandom/1.2/build/frandom.c:337:38: note: in expansion of macro ‘THIS_MODULE’
  337 |         frandom_class = class_create(THIS_MODULE, "fastrng");
      |                                      ^~~~~~~~~~~
In file included from ./include/linux/device.h:31,
                 from ./include/linux/cdev.h:8,
                 from /var/lib/dkms/frandom/1.2/build/frandom.c:29:
./include/linux/device/class.h:230:54: note: expected ‘const char *’ but argument is of type ‘struct module *’
  230 | struct class * __must_check class_create(const char *name);
      |                                          ~~~~~~~~~~~~^~~~
/var/lib/dkms/frandom/1.2/build/frandom.c:337:25: error: too many arguments to function ‘class_create’
  337 |         frandom_class = class_create(THIS_MODULE, "fastrng");
      |                         ^~~~~~~~~~~~
./include/linux/device/class.h:230:29: note: declared here
  230 | struct class * __must_check class_create(const char *name);
      |                             ^~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:243: /var/lib/dkms/frandom/1.2/build/frandom.o] Błąd 1
make[2]: *** [/usr/lib/modules/6.6.3-arch1-1/build/Makefile:1913: /var/lib/dkms/frandom/1.2/build] Błąd 2
make[1]: *** [Makefile:234: __sub-make] Błąd 2
make[1]: Opuszczenie katalogu '/usr/lib/modules/6.6.3-arch1-1/build'
make: *** [Makefile:11: default] Błąd 2

I went ahead and fixed a couple issues with this package just now:

1. The main source tarball checksum changed yet again and wasn’t matching
2. The source code needed a small compatibility patch to build without errors on kernels 6.4 and later

Actually even on a 10 years old low end Atom D525, urandom is faster than frandom (97 vs 69 MB/s). Tested with: dd if=/dev/urandom of=/dev/null bs=1M count=1000 I think the performance of urandom has improved so much in the mainline kernel that this module has been rendered useless.

On a Ryzen 5950X with linux-lts, urandom is just as fast as frandom (~450 MB/s)

Not having much time lately. Disowning it.

Read the "first submitted" date of this package and the comments at the top inside the PKGBUILD... there was a time where packages where starting with "dkms" actually in Archlinux history.

To do your suggestion, I'll have to upload a new package just with the name change and ask for the removal of this one. Till there's a formal obligation from AUR rules, I don't think the hassle for that gives us any benefit due to the few votes this package has received.

On the other hand, I just updated the package to reflect the new hash of the main file. It seems the original developer just updated the Makefile and didn't increased the version of his software.

A suggestion: To rename your package to frandom-dkms. Adding -dkms at the end seems to be the de-facto-standard (maybe it is also in the guidelines?, I haven't checked.)

Checksum verification fails:

==> Validating source files with md5sums...
    frandom-1.2.tar.gz ... FAILED
    frandom.udev.patch ... Passed
    dkms.conf ... Passed
    Makefile ... Passed
==> ERROR: One or more files did not pass the validity check!

Thanks for maintaining!

Done. Big thanks to you, jihem.

Hi, You can add the following patch to make this package compatible with Linux 4.12. You should also remove the .install file (not necessary with pacman hooks) and remove (or move to optdepends) linux-headers dependency for people who don't use the default kernel. --- frandom-1.1-old/frandom.c +++ frandom-1.1/frandom.c @@ -26,6 +26,9 @@ #include <linux/random.h> #include <asm/uaccess.h> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 12, 0) +#include <linux/uaccess.h> +#endif #include <linux/cdev.h> #include <linux/err.h> #include <linux/device.h>