Package Details: dnglab 0.6.3-1

Git Clone URL: https://aur.archlinux.org/dnglab.git (read-only, click to copy)
Package Base: dnglab
Description: Camera RAW to DNG file format converter
Upstream URL: https://github.com/dnglab/dnglab
Licenses: LGPL-2.1-only
Submitter: supermario
Maintainer: supermario
Last Packager: supermario
Votes: 1
Popularity: 0.90
First Submitted: 2024-06-14 14:58 (UTC)
Last Updated: 2024-11-15 10:13 (UTC)

Latest Comments

HurricanePootis commented on 2024-11-18 03:27 (UTC)

Hello, this package could do with the following changes to be in line with the Rust packaging guidelines

  1. Add a prepare() function to fetch cargo crates
  2. Change --locked to --frozen in build() since the crates were already fetched
  3. Add export RUSTUP_TOOLCHAIN=stable for users who use rustup.
  4. Add glibc to depends()
diff --git a/PKGBUILD b/PKGBUILD
index ca6ea4e..d72b42d 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,19 +7,29 @@ pkgdesc="Camera RAW to DNG file format converter"
 arch=(x86_64)
 url=https://github.com/dnglab/dnglab
 license=(LGPL-2.1-only)
-depends=(gcc-libs)
+depends=(glibc gcc-libs)
 makedepends=(cargo)
 source=($url/archive/v$pkgver/$pkgname-$pkgver.tar.gz)
 sha256sums=('a3c4d7bb22bf16811f2018eb1b4c9f633b67320d56659fc643d4d809dc58d01b')

+prepare(){
+  cd $pkgname-$pkgver
+  export RUSTUP_TOOLCHAIN=stable
+  cargo fetch --locked --target "$(rustc -vV | sed -n 's/host: //p')"
+}
+
+
 build() {
   cd $pkgname-$pkgver
-  cargo build --release --locked
+  export RUSTUP_TOOLCHAIN=stable
+  export CARGO_TARGET_DIR=target
+  cargo build --frozen --release
 }

 check() {
   cd $pkgname-$pkgver
-  cargo test --all --release --locked
+  export RUSTUP_TOOLCHAIN=stable
+  cargo test --all --release --frozen
 }

 package() {