| Git Clone URL: | https://aur.archlinux.org/element-desktop-git.git (read-only, click to copy) |
|---|---|
| Package Base: | element-desktop-git |
| Description: | Glossy Matrix collaboration client — web version. |
| Upstream URL: | https://element.io |
| Licenses: | Apache |
| Conflicts: | element-web |
| Provides: | element-web |
| Submitter: | idanoo |
| Maintainer: | Xangelix |
| Last Packager: | Xangelix |
| Votes: | 14 |
| Popularity: | 0.000001 |
| First Submitted: | 2020-07-18 02:27 (UTC) |
| Last Updated: | 2024-08-14 19:58 (UTC) |
You don't have to update it every time there is a new commit, makepkg will automatically get the latest commit and create a package for that commit, this is actually less work than what you are doing now.
You should read all of the VCS package guidelines and this note about the difference between -git and normal packages
@SeerLite
Maybe you should consider changing it so it does either way.
If this is the case I would have to disown the package because, like many of us, I do the whole thing in my spare time and therefore cannot provide every single commit as an update.
@jaltek Oh, looks like I never came across that guideline, I only read the PKGBUILD wiki page. I had no idea the replaces field could be ignored in VCS packages. Now that I see it I think it makes sense though.
It also doesn't say anything about -git packages having to pull from the last commit, and in fact even explains how to fix the source on a specific commit. But I found this section in the AUR wiki page that gives the impression that -git packages are indeed meant to build from the latest.
Oh and now I also found this! (See the first point). AFAICT this package doesn't really patch or add anything that the official binary package doesn't do already, right? (except for RC versions, which are not the majority of versions) That means it's not complying with the first rule (unless I missed something or the RC versions do indeed work around that). Making it pull from the latest commit would effectively solve that.
And even if it turns out the package is fine, I'm pretty sure most people expect a -git package to have the latest developments of the package. Maybe you should consider changing it so it does either way.
@SeerLite: Thank you for
your feedback. According to this guideline the replaces field should be avoided.
And yes, this repo does not reflect every commit from the upstream repo. I have used @idanoo's commits as a guide here. So this repo reflects only the RC and stable releases. Maybe the -git is wrong then?
@jaltek Thanks! Yes, that's working! I think you shouldn't really remove the replaces field though (it's used for when a package is updated), but I don't know if that's important.
You could also have a look at the official PKBUILD for reference:
https://github.com/archlinux/svntogit-community/blob/packages/element.io/trunk/PKGBUILD
Also, I realized this package doesn't build the latest version from git, but builds the fixed version just like the official repo package. I'm not sure if it's a rule that -git packages should build from the latest commit but it was really confusing that this one didn't. Most of them do, I'm pretty sure that's their main purpose.
@SeerLite I added both fields with the latest update to 1.7.19. Please have a look - should be ok.
Hi! Please add the provides and conflicts fields for element-desktop and element-web (non-git versions) to make installation easier. Thanks!
I adopted the maintainership from @idanoo. Co-Maintainers are always welcome :)
As I had the same problems like @cryzed I added a small patch for reskindex which simply calls the reskindex twice during the yarn build.
Other suggestions welcome :)
I am stepping down from maintaining this as I have no spare time to keep it up to date. The latest community package is up to date for the time being.
Pinned Comments