Arch Linux User Repository

@RileyInkTheCat Looks good now! :)

I've been thinking about the libwrap thing and looked around in the code to see where it is used. It seems to me that libwrap is an extra layer of security, not something that replaces or duplicates kernel routines.

I would suggest, but I fully respect your choice here, to add it as an “optdepends” so that users of the package can decide if they want this extra layer or not. E.g.:

optdepends=('libwrap: enable TCP wrappers')

That way it will build and work perfectly without libwrap, but user can opt to include it. That's the proper use of optdepends in my opinion.

@kseistrup it is fixed now

Cheers and thank you so much for your suggestions!

git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g'

I gave you wrong information. The above sed expression is the correct one.

I'll buy you a coffee if we meet one day. :)

@kseistrup It is no problem, I am certainly very amateur when it comes to packaging software and I quite enjoy the learning experience. Should be fixed now!

I'm sorry to disturb you again, but the version string is still wrong. Just remove the

printf "r%s.%s"

part and the "$()" thing so that we only have

git describe --long --tags --abbrev=7 | sed 's/([^-]*-g)/r\\1/;s/-/./g')

then the version string will be alright.

:)

@kseistrup oh I was unaware of the license identifier changes! I have updated according to your suggestions.

Thank you very much.

Oh, I forgot:

There's no reason to use printf in

printf "r%s.%s" "$(git describe --long --tags --abbrev=7 | sed 's/([^-]*-g)/r\\1/;s/-/./g')"

(and it produces an erroneous version anyway), using

git describe --long --tags --abbrev=7 | sed 's/([^-]*-g)/r\\1/;s/-/./g')"

is sufficient.

Cheers.

@RileyInkTheCat Thanks a lot. I didn't know that libwrap was optional, just noticed that it was linked to.

Please note that the license identifier should literally be BSD-2-Clause because Arch had moved to SPDX compliant license identifiers: https://spdx.org/licenses/BSD-2-Clause.html

/usr/share/licenses/spdx/

Also note that although this package will build on “any” architecture, the final package isn't an “any” package. Something like

arch=('aarch64' 'arm' 'armv6h' 'armv7h' 'i686' 'x86_64')

should satisfy most people.

@kseistrup thanks for bringing this up, I hadn't updated this package in a while so I was totally unaware it didn't build anymore. I am unsure what is causing config.h to generate in the wrong place, so I added a simple fix to move it to the correct directory. Its pretty dirty, but I am not an upstream contributor, just someone who likes using the software.

Libwrap however does not seem to be a hard requirement and Gophernicus should be able to use the kernel's built in functionality if libwrap is not present at the time of compilation. As far as my understanding goes.

Cheers!

Hey! Thanks for packaging this for AUR.

However, the package does not currently build. The config.h file should be present in the source directory.

Also, need to have:

1. There's a missing dependency: libwrap
2. The license should be BSD-2-Clause

Nice to have:

1. A decent version string can now be had with:

   git describe --long --tags --abbrev=7 | sed 's/([^-]*-g)/r\1/;s/-/./g'

Cheers.