Arch Linux User Repository

I'm getting this error while building in clean chroot:

==> Starting check()...
# github.com/gotify/cli/v2/utils.test
_cgo_callers: relocation target x_cgo_callers not defined
_cgo_init: relocation target x_cgo_init not defined
_cgo_mmap: relocation target x_cgo_mmap not defined
_cgo_munmap: relocation target x_cgo_munmap not defined
_cgo_notify_runtime_init_done: relocation target x_cgo_notify_runtime_init_done not defined
_cgo_sigaction: relocation target x_cgo_sigaction not defined
_cgo_thread_start: relocation target x_cgo_thread_start not defined
net._cgo_2ac87069779a_C2func_getaddrinfo: relocation target _cgo_2ac87069779a_C2func_getaddrinfo not defined
net._cgo_2ac87069779a_Cfunc_freeaddrinfo: relocation target _cgo_2ac87069779a_Cfunc_freeaddrinfo not defined
net._cgo_2ac87069779a_Cfunc_gai_strerror: relocation target _cgo_2ac87069779a_Cfunc_gai_strerror not defined
runtime._cgo_setenv: relocation target x_cgo_setenv not defined
runtime._cgo_unsetenv: relocation target x_cgo_unsetenv not defined
runtime.cgo_yield: relocation target _cgo_yield not defined
?       github.com/gotify/cli/v2        [no test files]
?       github.com/gotify/cli/v2/command        [no test files]
?       github.com/gotify/cli/v2/config [no test files]
FAIL    github.com/gotify/cli/v2/utils [build failed]
FAIL
==> ERROR: A failure occurred in check().
    Aborting...
==> ERROR: Build failed, check /var/lib/aurbuild/x86_64/build/build

Sadly the error message is not always clear. LDFLAGS in particular is not a problem since makepkg will force it's own value (see /etc/makepkg.conf, but I know what you mean and I agree that the user has to be aware of his own environment. I secretly hope CGO_ENABLED along with the other CGO_* flags will be enforced by makepkg in the future, although I read (or heard) it's very unlikely.

It's a good point, but I think that in this scenario the user is responsible. I mean, if users export CGO_ENABLED=0 globally, they should know what they are doing or at least for some reason this is intended.

It's like changing LDFLAGS. There's no way to prevent such things (which is actually good).

There's no need to enforce CGO_ENABLED here since we are running go build directly and not through a Makefile or something.

Sorry, should make this more clear: I mean that some Arch users have CGO_ENABLED=0 exported in their environments, not the upstream project.

If you see building in clean chroot as a requirement, then I agree that it's unnecessary. The env variable is still picked up when running makepkg directly. In this specific case it still builds, but with side-effects like partial relro (see namcap, checksec)

This decision is up to you. I had some "works for me" moments in the past, so I started including it for Golang packages.

Hey @matthias.lisin, thanks for the feedback.

The only thing you missed is the -u flag for date

Well spotted! UTC enforced now.

I also like to force CGO_ENABLED=1, as some Go developers have CGO_ENABLED=0

There's no need to enforce CGO_ENABLED here since we are running go build directly and not through a Makefile or something.

Hi flipee, thanks for adopting this package. PKGBUILD looks really good, I really appreciate. The only thing you missed is the -u flag for date.

Edit: (this is debatable) I also like to force CGO_ENABLED=1, as some Go developers have CGO_ENABLED=0 exported in their environments and the build can break for them.