Package Details: gzdoom-git 4.15pre+5+g62381cc-1

Git Clone URL: https://aur.archlinux.org/gzdoom-git.git (read-only, click to copy)
Package Base: gzdoom-git
Description: Feature centric port for all Doom engine games (git version)
Upstream URL: http://www.zdoom.org/
Licenses: GPL3, BSD, LGPL3
Conflicts: gzdoom
Provides: gzdoom
Replaces: gzdoom-legacy-git, gzdoom1-git
Submitter: grubber
Maintainer: MaddieMewmews
Last Packager: MaddieMewmews
Votes: 24
Popularity: 0.188559
First Submitted: 2013-06-25 15:27 (UTC)
Last Updated: 2024-12-22 22:57 (UTC)

Dependencies (28)

Required by (10)

Sources (4)

Latest Comments

1 2 3 4 5 6 Next › Last »

MarisaDOOM commented on 2024-12-22 12:43 (UTC)

The fix-format-security-error patch is in the sources, but it's not being applied during prepare(), worth pointing out this oversight (same thing with vkdoom-git)

MarisaDOOM commented on 2024-11-26 14:47 (UTC) (edited on 2024-12-19 11:39 (UTC) by MarisaDOOM)

The developers have a tendency to not bother with those kinds of issues, considering the already existing problem with makepkg having -Wp,-D_GLIBCXX_ASSERTIONS resulting in crashes related to calls to clamp with reverse argument order, among other things.

If this does get reported upstream, they might ignore it too, as their CI builds work just fine with whatever default compiler flags they use.

Edit: Might have to just go with how the stable package does it and patch the problematic function.

FabioLolix commented on 2024-11-18 16:51 (UTC)

error: format not a string literal and no format arguments [-Werror=format-security]

This need 

  export CFLAGS+=" -Wno-error=format-security"
  export CXXFLAGS+=" -Wno-error=format-security"

to avoid the error and should be reported upstream

kinker31 commented on 2024-11-18 02:44 (UTC)

As of the making of this post, trying to build i_net.cpp when trying to install this package results in the following, failing to install:

[ 85%] Building CXX object src/CMakeFiles/zdoom.dir/common/engine/i_net.cpp.o
/home/kinker31/.cache/paru/clone/gzdoom-git/src/gzdoom/src/common/engine/i_net.cpp: In function ‘void I_NetError(const char*)’:
/home/kinker31/.cache/paru/clone/gzdoom-git/src/gzdoom/src/common/engine/i_net.cpp:1075:21: error: format not a string literal and no format arguments [-Werror=format-security]
 1075 |         I_FatalError(error);

Might be something over at the repo itself? Could also be my system being a lil' dumdum.

MarisaDOOM commented on 2024-10-10 09:24 (UTC)

Even with that patch there's still the issue of ZMusic needing to be updated to 1.1.14, unfortunately.

MaddieMewmews commented on 2024-10-09 00:01 (UTC)

The patch seems mostly unnecessary with modern GZDoom code, all it seems to do is remove /usr/local/share/ from the search paths, which seems somewhat arbitrary, and force $PROGDIR searching for soundfonts/fm_banks. A much smaller patch that just used that last change should work, I already integrated it into my vkdoom-git package.

Below is the patch that vkdoom-git is using, albeit this is mostly untested as of now.

From f3d8a2ba96b8f9cbd327b55c17e3428ce6d7af9e Mon Sep 17 00:00:00 2001
From: Madeline Mewmews <maddie@mewmews.gay>
Date: Tue, 8 Oct 2024 16:01:25 -0500
Subject: [PATCH] Update Arch Linux patch

Signed-off-by: Madeline Mewmews <maddie@mewmews.gay>
---
 src/gameconfigfile.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gameconfigfile.cpp b/src/gameconfigfile.cpp
index b61279ebc..75da8e4e0 100644
--- a/src/gameconfigfile.cpp
+++ b/src/gameconfigfile.cpp
@@ -181,6 +181,8 @@ FGameConfigFile::FGameConfigFile ()
        SetValueForKey("Path", "/usr/local/share/doom/fm_banks", true);
        SetValueForKey("Path", "/usr/local/share/games/doom/soundfonts", true);
        SetValueForKey("Path", "/usr/local/share/games/doom/fm_banks", true);
+       SetValueForKey("Path", "$PROGDIR/soundfonts", true);
+       SetValueForKey("Path", "$PROGDIR/fm_banks", true);
        SetValueForKey("Path", "/usr/share/doom/soundfonts", true);
        SetValueForKey("Path", "/usr/share/doom/fm_banks", true);
        SetValueForKey("Path", "/usr/share/games/doom/soundfonts", true);
-- 
2.46.1

MarisaDOOM commented on 2024-10-02 08:36 (UTC)

Seems that a recently merged pull request (https://github.com/ZDoom/gzdoom/pull/2610) has broken the included patch in this package.

lighterowl commented on 2023-09-28 09:40 (UTC)

The pkgver() in the current PKGBUILD returns 4.12pre+3+g40ec46e6e, but the pkgver variable is set to 4.12pre+3+g40ec46e6ea, which means that AUR helpers will keep notifying you about a possible update.

Please change to pkgver=4.12pre+3+g40ec46e6e in the PKGBUILD, thanks!

wallabra commented on 2022-12-15 03:15 (UTC) (edited on 2022-12-15 03:34 (UTC) by wallabra)

GZDoom 4.10 seems to have introduced a PROGDIR argument/definition that basically obsoletes that section of the patch. It can be taken advantage of by passing -DPROGDIR="/usr/lib/gzdoom" in the pkgbuild's CXXFLAGS.

This, alongside stripping that particular diff section from the patch file, fixes the issue I and @CasualUser have encountered.

Here is a git diff from the, as of writing, current version of the AUR repo (6497acf64):

diff --git a/0001-Fix-file-paths.patch b/0001-Fix-file-paths.patch
index cc8adb6..00b7c23 100644
--- a/0001-Fix-file-paths.patch
+++ b/0001-Fix-file-paths.patch
@@ -8,31 +8,6 @@ Subject: [PATCH] Fix file paths
  src/gameconfigfile.cpp                   | 10 ++--------
  2 files changed, 3 insertions(+), 21 deletions(-)

-diff --git a/src/common/platform/posix/sdl/i_main.cpp b/src/common/platform/posix/sdl/i_main.cpp
-index a28b90f01..7299029fd 100644
---- a/src/common/platform/posix/sdl/i_main.cpp
-+++ b/src/common/platform/posix/sdl/i_main.cpp
-@@ -175,19 +175,7 @@ int main (int argc, char **argv)
-   Args = new FArgs(argc, argv);
- 
-   // Should we even be doing anything with progdir on Unix systems?
--  char program[PATH_MAX];
--  if (realpath (argv[0], program) == NULL)
--      strcpy (program, argv[0]);
--  char *slash = strrchr (program, '/');
--  if (slash != NULL)
--  {
--      *(slash + 1) = '\0';
--      progdir = program;
--  }
--  else
--  {
--      progdir = "./";
--  }
-+  progdir = "/usr/lib/gzdoom/";
- 
-   I_StartupJoysticks();
- 
 diff --git a/src/gameconfigfile.cpp b/src/gameconfigfile.cpp
 index 17898f3ae..7bfb63205 100644
 --- a/src/gameconfigfile.cpp
diff --git a/PKGBUILD b/PKGBUILD
index 6f6814a..c94da48 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,7 +1,7 @@
 # Maintainer: Jan Cholasta <grubber at grubber cz>

 pkgname=gzdoom-git
-pkgver=4.10pre+16+gd422737a7
+pkgver=4.11pre+8+gde65d1b96
 pkgrel=1
 pkgdesc='Feature centric port for all Doom engine games (git version)'
 arch=('i686' 'x86_64' 'aarch64')
@@ -42,7 +42,7 @@ source=('gzdoom::git+https://github.com/coelckers/gzdoom.git'
         '0001-Fix-file-paths.patch')
 sha256sums=('SKIP'
             '59122e670f72aa2531aff370e7aaab2d886a7642e79e91f27a533d3b4cad4f6d'
-            '195a9d1ec0489bd38f1d6c40763e66773dd74f5f719acb6afa32a077fdb0b8f4')
+            '80269a3cc5b2a3a8c3070e9ec267ec17f68f7cb884b1dee657b4d6178784abbb')

 pkgver() {
     cd gzdoom
@@ -59,10 +59,11 @@ build() {
     mkdir -p build
     cmake -B build \
           -D CMAKE_BUILD_TYPE=Release \
-          -D CMAKE_CXX_FLAGS="${CXXFLAGS} -ffile-prefix-map=\"$PWD\"=. -DSHARE_DIR=\\\"/usr/share/gzdoom\\\"" \
+          -D CMAKE_CXX_FLAGS="${CXXFLAGS} -ffile-prefix-map=\"$PWD\"=. -DSHARE_DIR=\\\"/usr/share/gzdoom\\\" -D PROGDIR=\\\"/usr/lib/gzdoom\\\"" \
           -D INSTALL_RPATH=/usr/lib \
           -D DYN_GTK=OFF \
-          -D DYN_OPENAL=OFF
+          -D DYN_OPENAL=OFF \
+          -Wno-dev
     make -C build
 }

CasualUser commented on 2022-11-22 11:59 (UTC) (edited on 2022-11-22 12:00 (UTC) by CasualUser)

patching file src/common/platform/posix/sdl/i_main.cpp

Hunk #1 FAILED at 175.

1 out of 1 hunk FAILED -- saving rejects to file src/common/platform/posix/sdl/i_main.cpp.rej

patching file src/gameconfigfile.cpp

Hunk #1 succeeded at 121 (offset 2 lines).

Hunk #2 succeeded at 141 (offset 2 lines).

Hunk #3 succeeded at 168 (offset 2 lines).

The patch needs and update.

1 2 3 4 5 6 Next › Last »