Package Details: heroic-games-launcher 2.15.2-1

Git Clone URL: https://aur.archlinux.org/heroic-games-launcher.git (read-only, click to copy)
Package Base: heroic-games-launcher
Description: Native GOG, Epic Games and Amazon games launcher for Linux
Upstream URL: https://heroicgameslauncher.com/
Licenses: GPL3
Submitter: FabioLolix
Maintainer: FabioLolix
Last Packager: FabioLolix
Votes: 20
Popularity: 1.57
First Submitted: 2022-07-18 20:20 (UTC)
Last Updated: 2024-09-20 21:10 (UTC)

Latest Comments

1 2 3 Next › Last »

FabioLolix commented on 2024-09-21 21:54 (UTC)

It would be very beneficial to only package heroic itself (eg. app.asar and app.asar.unpacked but without the win32 folder)

PR welcome here: https://github.com/FabioLolix/PKGBUILD-AUR_fix/tree/master/h

tippfehlr commented on 2024-09-21 20:47 (UTC)

Stripping and compressing takes this long because it processes all of electron too. It would be very beneficial to only package heroic itself (eg. app.asar and app.asar.unpacked but without the win32 folder)

FabioLolix commented on 2024-09-21 17:27 (UTC)

Save time? You mean while compressing the package?

While stripping

If you've taken care of your Pacnews after updating to Pacman 7, you'll notice that it's faster now.

Haven't

yochananmarqos commented on 2024-09-21 16:57 (UTC)

@FabioLolix: Save time? You mean while compressing the package? If you've taken care of your Pacnews after updating to Pacman 7, you'll notice that it's faster now.

I just built in a clean chroot with stripping enabled and it didn't complain this time. Odd.

Either way, there's no reason to ship Windows binaries.

FabioLolix commented on 2024-09-21 11:10 (UTC)

There's no reason to disable stripping

For what I recall I disabled it to same time

It's complaining about the Windows binaries

What the complain?

yochananmarqos commented on 2024-09-20 23:52 (UTC)

@FabioLolix: There's no reason to disable stripping. It's complaining about the Windows binaries, just remove them:

# Remove Windows binaries
  rm -rv "${pkgdir}/opt/heroic/resources/app.asar.unpacked/build/bin/x64/win32/"

chrrybmb commented on 2024-09-14 10:58 (UTC) (edited on 2024-09-14 10:58 (UTC) by chrrybmb)

upstream using a custom version of electron which supports DRM, while it is not supported in the Arch packages

That is no longer true, Heroic has reverted back to using standard electron. See here

FabioLolix commented on 2024-09-10 19:45 (UTC)

is there a reason to not use system electron?

Aside that I'm not pratical with that

Yes, see this I don't think things have changed meanwhile https://lists.archlinux.org/archives/list/aur-requests@lists.archlinux.org/message/ULRU76CEQWVNDISFAFDE52WHM2XQYNHE/

[...] upstream using a custom version of
`electron` which supports DRM, while it is not supported in the Arch
packages.

tippfehlr commented on 2024-09-10 18:36 (UTC) (edited on 2024-09-10 19:00 (UTC) by tippfehlr)

It is new to me that installing a package remove core packages

I uninstalled it by accident because it was is a dependency of base-devel :D

tippfehlr commented on 2024-09-10 18:26 (UTC)

@FabioLolix: is there a reason to not use system electron? it works for me with only app.asar and app.asar.unpacked/* (copied from the current installation). I’m not sure about compiled extensions.

(https://wiki.archlinux.org/title/Electron_package_guidelines)

1 2 3 Next › Last »