Arch Linux User Repository

Ahh, sorry. I thought pkgver had not been increased. Then apparently I made a mistake locally when building. Thanks again for your quick response and the fix.

@marek22k pkgrel should not be increased when pkgver is updated. pkgrel needs to be increased only when pkgver stays the same, which was not the case in the last package update. At the contrary, I decreased pkgrel from 2 to 1 due to a pkgver update. Please see the Arch Wiki about pkgrel.

Thanks for the quick reply! If you have made an update to the package, please increase the pkgrel (so that the old PKGBUILD is not stuck in the cache, alternatively one could delete the cache).

@marek22k package updated to match the latest upstream changes. Thanks for reporting.

Mhh, I get a error when trying to install the package:

==> Starting prepare()...
Submodule 'i2pd' (https://github.com/PurpleI2P/i2pd) registered for path 'i2pd'
Cloning into '/home/marek/.cache/yay/i2pd-tools-git/src/i2pd-tools/i2pd'...
done.
Submodule path 'i2pd': checked out '9668ea9338fe8524781d6966f576227775129769'
patching file Makefile
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
 -> error making: i2pd-tools-git-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
i2pd-tools-git - exit status 4

$ cat /home/marek/.cache/yay/i2pd-tools-git/src/i2pd-tools/Makefile.rej 
--- Makefile
+++ Makefile
@@ -7,16 +7,16 @@ LIBI2PD_PATH = $(I2PD_PATH)/libi2pd
 LIBI2PD_CLIENT_PATH = $(I2PD_PATH)/libi2pd_client

 CXX ?= g++
-CXXFLAGS = -Wall -std=c++17 -O2
+CXXFLAGS += -Wall -std=c++17 -O2
 INCFLAGS = -I$(LIBI2PD_PATH) -I$(LIBI2PD_CLIENT_PATH)
 DEFINES = -DOPENSSL_SUPPRESS_DEPRECATED

-LDFLAGS = 
+LDFLAGS += 
 LDLIBS = $(I2PD_PATH)/$(I2PD_LIB) -lboost_system$(BOOST_SUFFIX) -lboost_date_time$(BOOST_SUFFIX) -lboost_filesystem$(BOOST_SUFFIX) -lboost_program_options$(BOOST_SUFFIX) -lssl -lcrypto -lz 


 ifeq ($(UNAME),Linux)
-   CXXFLAGS += -g
+   CXXFLAGS += 
 else ifeq ($(UNAME),Darwin)
    CXXFLAGS += -g
 else ifeq ($(UNAME),FreeBSD)

@tamjan package updated. Fixed the executable files and added the i2pdctl script.

@tamjan binary stripping is a makepkg task. It should not be used directly in 'package()', unless there is a good reason for doing so, which is not the case here. Also notice that there are different types of stripping depending on the binary file in question, and you can see makepkg.conf(5) for details. Some source files are really ending up installed alongside the binaries, as upstream marks them as executable. I guess we can overcome this in a better way instead of specifying every single file extension here. I have yet to investigate if i2pdctl is worth installing. Thanks for the suggestions.

I suggest:

--- PKGBUILD.orig    2023-10-29 15:23:53.000000000 +0100
+++ PKGBUILD     2024-04-23 07:48:37.000000000 +0200
@@ -42,7 +42,8 @@
     while read -r -d '' _tool
     do
         install -D -m755 "$_tool" "${pkgdir}/usr/bin/i2pd-${_tool##*/}"
-    done < <(find i2pd-tools -maxdepth 1 -type f ! -name '*.sh' ! -name '*README*' -executable -print0)
+    done < <(find i2pd-tools -maxdepth 1 -type f ! -name '*.sh' ! -name Makefile ! -name '*.cpp' ! -name '*.hpp' ! -name '*README*' -executable -print0)
+    install -D -m7555 i2pd-tools/scripts/i2pdctl -t "${pkgdir}/usr/bin"

     install -D -m644 i2pd-tools/LICENSE -t "${pkgdir}/usr/share/licenses/${pkgname}"
 }

@dbermond thanks. i saw some commits were made to the github project so i just tried building again, but now it's failing on a different error

edit: nevermind that. it's building now after i first reinstalled i2pd-git. thanks for your help.

@pizfunk Confirmed. It also does not build against stable i2pd version. This is an upstream issue.