@sshaikh If upstream changes will cause breakage in users setup, IMO, they should be responsible for their systems (specially in this case as this is a VCS package and breakage is expected) as arch packages aim to be close to upstream (ie, not heavily patched as other distros). If the current maintainer had disagreed with those changes, then he would've said something, but because he didn't, then I would've guessed that he is not really taking care of the package and an orphan request would've made sense to me...
BTW, the compilation should be done in build()
, not package()
, and in pkgver()
, the git
line can be simplified to git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
(no need for VAR
)
Edit: corrected git command...
Pinned Comments
sshaikh commented on 2021-08-16 11:28 (UTC) (edited on 2021-08-16 11:52 (UTC) by sshaikh)
@thiagowfx
The i3blocks-contrib repo contains the source code for various contributed to be used by i3blocks. As per upstream[1] they are not meant to be used "raw" by cloning but in fact are meant to be selectively built/copied into an existing script directory.
This allows upstream's default/example config to work correctly, as block names are by default taken from filenames in the script directory (ie it doesn't handle subfolders elegantly). So to answer your question directly, the difference between this package and i3blocks-contrib-git is that the latter simply clones and copies the repo (sub directories and all), while this one "flattens" it into an appropriate script directory.
There's more discussion in upstream's issue #255[2], including the inspiration for the code in this PKGBUILD.
@a821
I have raised this (as well as offering a solution) on i3blocks-contrib-git's AUR page[3], but received no meaningful response. As I was unable to determine if this was by design/preference or that the users of this package were actively expected to configure their systems in a way contrary to upstream, I didn't feel it was appropriate to adopt and correct it in a way that would break it for an existing audience. And so I uploaded an alternative package.
Hope that helps!
[1]https://github.com/vivien/i3blocks-contrib/wiki/Installation [2]https://github.com/vivien/i3blocks-contrib/issues/255 [3]https://aur.archlinux.org/packages/i3blocks-contrib-git/#comment-776755