Arch Linux User Repository

This and lenovolegionlinux-git needs an update , Due to [1] commit , it is giving missing package error. It looks like fixed on git but this package is fetching old archive thus still having that error.

[1] : https://github.com/johnfanv2/LenovoLegionLinux/commit/62e33f411a9d013fe6e91ac45c823f3962b8f925

@rabaimor this is only a dkms package (kernel module) so I don’t what you mean by missing packages

It can't start due to "missing packages", not listing which ones. (Installed all the listed dependencies)

@yataro thanks for notice the missing dkms depedency

About lenovolegionlinux-git yes it a requirement, because you can't do almost anything wit the driver without it (well I think anyone would like to write to /sys/class/hwmon by hand) and upstream it will not offer any support if you don't have at least the python gui or cli install/available.

dkms is supposed to be in depends not makedepends, see https://wiki.archlinux.org/title/DKMS_package_guidelines#Dependencies

Why there's a dependency on lenovolegionlinux-git? The kernel module should work without it.

this pkg installs the presets in /usr/share/legion_linux instead of /etc/legion_linux, which makes the GUI program crash if you chose a preset

Did the change upstream @memchr https://github.com/johnfanv2/LenovoLegionLinux/commit/62e33f411a9d013fe6e91ac45c823f3962b8f925

The hook causes mkinitpcio to rebuild mkinitramfs images twice when the linux or linux-zen package is changed. This is unnecessary as mkinitcpio already provides 90-mkinitcpio-install.hook which causes writes to usr/lib/modules/*/vmlinuz to trigger an initcpio rebuild.

Thus, at least for mkinitcpio, the following lines could be removed

12,13d11
<     elif [[ "$installed" =~ mkinitcpio ]] ; then
<         mkinitcpio -P

@Kathy is a good ideia but i will only not doit because some people like to patch the kernel and make lenovolegionlinux-dkms-git a dependency for lenovolegionlinux-git can cause problems.

Thanks for pointing out the error i will fix them now and update the commit

Sorry for the late replay.

lenovolegionlinux-git is still be a dependency because you need the tools in that package to make easy to interact with the kernel module

Fix some errors. Maybe you could set lenovolegionlinux-git to be an opt-dependent of lenovolegionlinux-dkms-git, and then let lenovolegionlinux-git to depend on lenovolegionlinux-dkms-git.

# Maintainer: MrDuartePT <gonegrier.duarte@gmail.com>
# Maintainer: johnfanv2 <https://github.com/johnfanv2>
_pkgname=lenovolegionlinux
pkgname=${_pkgname}-dkms-git
pkgver=r301.a03d860
pkgrel=1
pkgdesc="LenovoLegionLinux (LLL) DKMS module"
arch=("any")
url="https://github.com/johnfanv2/LenovoLegionLinux"
license=('GPL')
makedepends=("git")
depends=(
    "dkms"
    "lm_sensors"
    "i2c-tools"
    "dmidecode"
)
optdepends=(
    "lenovolegionlinux-git: Brings additional drivers and tools for Lenovo Legion series laptops to Linux"
    "legion-fan-utils-linux-git: Systemd service that will apply a given profile"
)
source=("${_pkgname}::git+https://github.com/johnfanv2/LenovoLegionLinux")
sha256sums=('SKIP')
install="lenovolegionlinux.install"

pkgver() {
    cd "${_pkgname}"
    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
}

prepare() {
    cd "${_pkgname}"
    pkgver_commit=$(echo $pkgver | cut -c 6-)
    git checkout $pkgver_commit
}

package() {
    cd "${srcdir}/${_pkgname}/kernel_module/"
    install -Dm644 dkms.conf ${pkgdir}/usr/src/${_pkgname}-1.0.0/dkms.conf
    cp -r {issue-warning.sh,legion-laptop-unused-snippets.c,legion-laptop.c,Makefile} ${pkgdir}/usr/src/$_pkgname-1.0.0/

    cd "${srcdir}/${_pkgname}/deploy/"
    install -Dm644 LenovoLegionLinux.hook ${pkgdir}/etc/pacman.d/hooks/LenovoLegionLinux.hook
}