Arch Linux User Repository

@oxalin, I'd also like to suggest and ask that you remove the hardcoded versioned dependence on openjpeg2.

That makes Arch system upgrades a pain when there is a newer openjpeg2 in the Arch repo while lib32-openjpeg2 has not yet been bumped.

I would recommend a middle ground, though:

depends=("${_pkgbasename}>=${pkgver}"

That way, Arch users would have no issues upgrading to the newer repo version of openjpeg2 while the lib32 version is not bumped.

I know that is not ideal, because then the dependents of lib32-openjpeg2 can potentially use newer headers of openjpeg2 than the version of the installed lib32-openjpeg2 when building the package.

But such a scenario rarely causes problems, because header upgrades are usually not drastic (typically upstream devs just mark some definitions deprecated for several releases before dropping them completely). Also, such potential but rare problems would only affect a limited number of user-built lib32 AUR packages.

On the other hand, hardcoding the version of openjpeg2 to lib32-openjpeg2 will prevent users from upgrading openjpeg2 but typically will not prevent them to upgrade ffmpeg or gstreamer. Then, the newer versions of those dependent packages would be incompatible with the non-latest openjpeg2 in case of an upstream SO version bump of the latter, breaking ffmpeg and/or gstreamer and a lot of downstream libraries / apps installed from the Arch repos.

Allowing the 'depends= (repo-package)>=(lib32-version)' constraint would lead to the far lesser evil according to the reasoning explained above. It would prevent breaking the runtime functioning of any Arch repo package because of the not yet bumped lib32 AUR package.

~~Since the v2.5.0 update is not very much, I made this patch. It SHOULDN'T cause any problems.
Keep in mind that this is an unofficial patch.

After using this patch, don't forget to update the 64-bit version.~~

DELETED

EDIT: The official one is updated.

Please update ASAP. This package for some reason has a dependency on the 64-bit openjpeg2, which has been updated to 2.5.0 on the main Arch repo a few days ago.

@sl1pkn07: thanks for the cleanup suggestion. I incorporated a big part of it in the latest update.

diff --git a/PKGBUILD b/PKGBUILD
index 5665db0..2a9cc06 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,46 +1,51 @@
 # Maintainer: Alexandre Demers <alexandre.f.demers@gmail.com>

-_setPrefix="/usr"
-_setLibdir="lib32"
-_setFullLibdir="${_setPrefix}/${_setLibdir}"
-_pkgbase=openjpeg2
-
-pkgname=${_setLibdir}-${_pkgbase}
-pkgver=2.3.1
+pkgname=lib32-openjpeg2
+pkgver=2.4.0
 pkgrel=1
 pkgdesc="An open source JPEG 2000 codec, version ${pkgver}"
 arch=('x86_64')
 license=('BSD')
 url="http://www.openjpeg.org"
-makedepends=('cmake' 'lib32-gcc-libs' 'lib32-libpng'  'lib32-libtiff' 'lib32-lcms2')
-depends=("${_pkgbase}" 'lib32-zlib')
+makedepends=('cmake'
+             'lib32-gcc-libs'
+             'lib32-libpng'
+             'lib32-libtiff'
+             'lib32-lcms2'
+             )
+depends=("openjpeg2=${pkgver}"
+         'lib32-zlib'
+         )
 source=("https://github.com/uclouvain/openjpeg/archive/v${pkgver}.tar.gz")
-md5sums=("3b9941dc7a52f0376694adb15a72903f")
+sha256sums=('8702ba68b442657f11aaeb2b338443ca8d5fb95b0d845757968a7be31ef7f16d')
+
+prepare(){
+  mkdir -p build
+}

 build() {
   export CFLAGS="-m32"
   export CXXFLAGS="-m32"
-  export PKG_CONFIG_PATH="${_setFullLibdir}/pkgconfig"
+  export PKG_CONFIG_PATH="/usr/lib32/pkgconfig"

-  cd "${srcdir}"
-  mkdir -p build
   cd build
-  cmake "../openjpeg-$pkgver" -DCMAKE_INSTALL_PREFIX=${_setPrefix} -DOPENJPEG_INSTALL_LIB_DIR=${_setLibdir} -DBUILD_DOC=off
+  cmake "../openjpeg-${pkgver}" \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DCMAKE_INSTALL_PREFIX=/usr \
+    -DOPENJPEG_INSTALL_LIB_DIR=lib32 \
+    -DBUILD_SHARED_LIBS=ON \
+    -DBUILD_STATIC_LIBS=OFF \
+    -DBUILD_DOC=off
+
   make
 }

 package() {
-  cd "${srcdir}/build"
-  make DESTDIR="${pkgdir}" install
+  make -C build DESTDIR="${pkgdir}" install

   # removing unneeded files and folders
-  rm -rf "${pkgdir}/${_setPrefix}"/{bin,include}
-  rm -fr "${pkgdir}/${_setFullLibdir}"/openjpeg-2.3
+  rm -rf "${pkgdir}/usr/"{bin,include}

   # installing license
-  mkdir -p "${pkgdir}/${_setPrefix}"/share/licenses/openjpeg-2.3
-  cp LICENSE.txt "${pkgdir}/${_setPrefix}"/share/licenses/openjpeg-2.3/LICENSE
-
-  mkdir -p "${pkgdir}/${_setPrefix}"/share/licenses/${pkgname}
-  ln -s ../openjpeg-2.3/LICENSE "${pkgdir}/${_setPrefix}"/share/licenses/${pkgname}/LICENSE
+  install -Dm644 "openjpeg-${pkgver}/LICENSE" "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
 }