Hi,
To follow the Arch Linux RFC16, could you please specific the LICENSE using SPDX syntax?
Git Clone URL: | https://aur.archlinux.org/libadwaita-without-adwaita-git.git (read-only, click to copy) |
---|---|
Package Base: | libadwaita-without-adwaita-git |
Description: | libadwaita; Includes a patch to not overwrite the system theme |
Upstream URL: | https://gnome.pages.gitlab.gnome.org/libadwaita |
Licenses: | LGPL-2.1-or-later |
Conflicts: | libadwaita |
Provides: | libadwaita, libadwaita-1.so |
Submitter: | ich |
Maintainer: | ich |
Last Packager: | ich |
Votes: | 30 |
Popularity: | 1.29 |
First Submitted: | 2022-04-08 09:57 (UTC) |
Last Updated: | 2025-03-31 21:05 (UTC) |
Hi,
To follow the Arch Linux RFC16, could you please specific the LICENSE using SPDX syntax?
I cannot reproduce your problem
I switched to Debina Ustable and latest patch, i cant reproduce it on Unstable either.
but I have found an issue where newer libadwaita versions override the "application-prefer-dark-theme"-property after my patch sets them, so I updated the patch to set the dark mode preference more aggressively. I don't know if libdwaita 1.4.2 works on debian, but if it does, could you test the newest patch?
Yes, Debian Unstable comes with libadwaita 1.4.2 and that last patch works perfectly fine.Thank you!!!!!!
As for the move to a proper development platform, I didn't really see the need initially since this is just a simple patch, but if it is necessary, I can look into that.
I agree, it was a suggestion.
@ExaHamza I cannot reproduce your problem, but I have found an issue where newer libadwaita versions override the "application-prefer-dark-theme"-property after my patch sets them, so I updated the patch to set the dark mode preference more aggressively.
I don't know if libdwaita 1.4.2 works on debian, but if it does, could you test the newest patch?
As for the move to a proper development platform, I didn't really see the need initially since this is just a simple patch, but if it is necessary, I can look into that.
Hi, i have a bug on my system (Debian stable) using this patch. If the system is on dark mode (on Settings>Appearance) toggling "Show percentage on battery" under Settings>Energy applies light mode without actually changing to it on Settings>Appearance. I'm not actually sure if this is related to this patch, I've never tested before applying the patch, so can someone try to reproduce it?
Also, i suggest the patch moves to a proper development platform as here is suitable to discuss package specific issues.
@ich thanks for your solution suggestions. It worked :)
@kanehekili this is because I changed the git path for version 1.4.2. Your AUR helper still has the last git cached, so it does not accept the new one.
You need to delete the cache and try again. It's usually in ~/.cache/YOUR-AUR-HELPER
Got the error:
libadwaita-without-adwaita-git/libadwaita-without-adwaita-git is not a clone of https://gitlab.gnome.org/GNOME/libadwaita.git
Removed corresponding .git file in cache
@mvidaldp pamac-gtk
seems to be a Manjaro package, so I can't test it on my system, but here's what I've gathered:
pamac-gtk
does not only depend on version 1.4.2
of libadwaita, but specifically the second epoch of it (this is what the 1:
means).
As far as I know, an AUR package cannot override a specific epoch of another package, so there is no way for me to update the PKGBUILD
to solve your problem.
I don't know why pamac-gtk
does this. I don't think there even was a first epoch of libadwaita 1.4.2.
Here's how you can solve this:
You could ask the maintainer of the package to set the version to something more reasonable (like 1.4.2
) if there is no reson to require the epoch.
You could clone this repository, replace 'libadwaita>=1:1.4.2'
with 'libadwaita>=1.4.2'
in the PKGBUILD
and run makepkg -si
to install pamac-gtk
without the additional dependency. However, you will have to do this every time the package updates in the future.
Thanks @ich :)
Unfortunately, I get the following error when trying to replace libadwaita for your package:
removing libadwaita breaks dependency 'libadwaita>=1:1.4.2' required by pamac-gtk
Any idea about how to overcome this?
@mvidaldp thanks for the notice. I updated the PKGBUILD.
The appstream problems have been resolved upstream, so I removed that part of the patch. Your AUR helper might be unhappy about the repository change, so if it complains make sure to clear the cache.
Pinned Comments
ich commented on 2022-04-08 10:17 (UTC) (edited on 2023-01-10 05:38 (UTC) by ich)
The version of libadwaita provided by this package will use the dconf-variable 'org.gnome.desktop.interface.gtk-theme' to load the theme. This is the same variable that other gtk4-apps (and gnome-tweaks) uses.
For this to work, your theme needs to support gtk4. There may also be some weird formatting until themes are updated to fully support the new widgets; The Arc-family of themes seems to already support most of libadwaita.
Since this replaces the system library, it will only work for apps that actually use it (that is, all apps in the main repo). You will still have to set GTK_THEME if you want to use Flatpaks / Snaps / Appimages
Edit: Please, never just report issues to other gtk projects while using this library. Please always check if the issue persists using extra/libadwaita, and report your issue only on this AUR package if it doesn't.