Package Details: libuser-ldap 0.64-1

Git Clone URL: https://aur.archlinux.org/libuser-ldap.git (read-only, click to copy)
Package Base: libuser-ldap
Description: LDAP module for libuser
Upstream URL: https://pagure.io/libuser/
Licenses: LGPL
Submitter: piernov
Maintainer: cyqsimon
Last Packager: cyqsimon
Votes: 0
Popularity: 0.000000
First Submitted: 2016-04-15 13:33 (UTC)
Last Updated: 2023-10-19 03:58 (UTC)

Latest Comments

cyqsimon commented on 2022-12-11 09:28 (UTC)

@tormod

Sorry for the late reply. I'm rather hesitant on patching the build with a commit diff, reasons summarised neatly here: https://dont-ship.it/

I will contact upstream and request a new release from them. And if for whatever reason they cannot do that, I will ask about shipping with your patch.

tormod commented on 2022-11-27 10:16 (UTC) (edited on 2022-11-27 11:50 (UTC) by tormod)

Seeing such bugs, nobody wants to be a C programmer :) At this point, with an upstream fix available, this remains just a release management and maintenance issue. The best would be if upstream would promptly release a new version and you can package it. Do you have a Fedora account so that you can ask in the upstream tracker?

I'd be happy to stop-gap fix this and other critical bugs directly, but I don't want to take ownership of the package.

For now I can also give you an AUR git patch, pasted here: http://0x0.st/oUho.diff (SHA512 05306bf137a135d086c2239025e8f7ef5bf0f1592f140006cd8e085ff102212ad026105d413965deec56f0e58606bde4d99c725c15ee8692e689518b6aac31f7)

cyqsimon commented on 2022-11-26 09:50 (UTC)

@tormod

That's good to know. Unfortunately I'm not a C programmer and cannot contribute meaningfully to fixing any logic bugs.

Would you like to take ownership of, or be added as a co-maintainer of this package, so that if further issues come up you can push a fix?

tormod commented on 2022-11-24 15:19 (UTC) (edited on 2022-11-24 15:40 (UTC) by tormod) 

Breakpoint 3, main (argc=3, argv=0x7fffffffeb88) at apps/luseradd.c:116
116     name = poptGetArg(popt);
(gdb) n
117     if (name == NULL) {
(gdb) print name
$5 = 0x555555568e90 "Testuser"
(gdb) n
122     if (uid_number_str != NULL) {
(gdb) 
136     poptFreeContext(popt);
(gdb) 
140                interactive ? lu_prompt_console :
(gdb) print name
$6 = 0x555555568e90 "\330\333\003"

Moving poptFreeContext(popt) to the end of main() in apps/luseradd.c and apps/luserdel.c fixes my test cases.

It turns out this was fixed in upstream git: https://pagure.io/libuser/c/3e70bc230962b3539d742ea1b886c5d63b303cd6?branch=master

tormod commented on 2022-11-24 13:27 (UTC) (edited on 2022-11-24 14:35 (UTC) by tormod)

Something weird has crept up: When trying to create a new user "bob", it is instead attempted to create a user "default_useradd", which now is created and thus next time it complains

Account creation failed: error creating a LDAP directory entry: Already exists.

Even worse if I try to delete this account: /usr/bin/luserdel -r default_useradd

User /etc/login.defs does not exist.

The words "/etc/login.defs" and "default_useradd" appear in /etc/libuser.conf