Good job. Here is a unit file for systemd: http://pastebin.com/5tvNda63
Just add it as /usr/lib/systemd/system/logkeys.service
If you don't mind, I have a couple of suggestions.
1. I think the /etc/rc.d and /etc/rc.conf files should be "logkeys" and not
"logkeysd". Usually, only daemons with "daemon" in their name use the "d" in the
end.
2. The default parameters in the configuration file will not work if the user
does not have the extra keymaps and just wants to use the default one.
3. Alongside the one above, do not ask the user for a keymap. They can configure
it later if they want.
4. I think that the convention is to use all caps variables in the /etc/rc.conf
file.
Number #2 and #3 are the most important, because it breaks the unit and
service files on some users. The other two are mostly for keeping up with the
current conventions.
Also, on a side note, I do not use the --no-func-keys option, but I can easily
change that on my own. I am not sure if the users prefer it though.
Search Criteria
Package Details: logkeys-git 1:r74.5c36832-2
Package Actions
| Git Clone URL: | https://aur.archlinux.org/logkeys-git.git (read-only, click to copy) |
|---|---|
| Package Base: | logkeys-git |
| Description: | Simple keylogger supporting also USB keyboards. |
| Upstream URL: | https://github.com/kernc/logkeys |
| Keywords: | keylogger |
| Licenses: | GPLv3 |
| Conflicts: | logkeys |
| Provides: | logkeys |
| Submitter: | SanskritFritz |
| Maintainer: | SanskritFritz |
| Last Packager: | SanskritFritz |
| Votes: | 48 |
| Popularity: | 0.000000 |
| First Submitted: | 2013-04-10 13:03 (UTC) |
| Last Updated: | 2018-01-15 15:37 (UTC) |
Required by (0)
Sources (3)
sakalisc commented on 2012-09-04 15:34 (UTC)
SanskritFritz commented on 2012-09-04 14:50 (UTC)
conf.d/logkeysd implemented.
SanskritFritz commented on 2012-09-04 14:50 (UTC)
I'd be grateful if someone came up with a systemd unit file. I don't use systemd yet.
SanskritFritz commented on 2012-09-04 14:50 (UTC)
conf.d/logkeysd implemented.
SanskritFritz commented on 2012-08-21 13:12 (UTC)
SakalisC brilliant idea, thanks, I'll look into this. Expect a new version soon.
sakalisc commented on 2012-08-15 11:31 (UTC)
Hello. May I suggest that instead of modifying the rc script, add the
commandline options in a variable in a file in /etc/conf.d/ and the source it in
the rc script? This is the way most packages work and it's easier to modify the
commandline arguments after the installation. Also this way you won't have to
ask the user for what arguments should be passed during post-install.
Take a look at existing deamons in your system (their rc scripts in /etc/rc.d/
and their conf files in /etc/conf.d) if you are not sure how exactly this is
supposed to work.
SanskritFritz commented on 2012-04-05 18:48 (UTC)
@eduardosm: post your /etc/rc.d/logkeys to some pastebin. I suspect you messed up something at install. It is interactive, you have to enter the command executed by the script.
SanskritFritz commented on 2012-04-05 18:46 (UTC)
@eduardosm: I use this very daemon script every day automatically at startup. Never had any problem with it. I just tested it now with
rc.d stop logkeys
rc.d start logkeys
There could be something wrong on your system, check some logs.
eduardosm commented on 2012-04-05 17:21 (UTC)
The daemon script does not work.
Whether it is running or not it always fails to start and always says has success to stop.
Pinned Comments
SanskritFritz commented on 2018-03-09 14:08 (UTC)
Flagging a -git package out-of-date is only feasible if the build requirements change. Just rebuild the package otherwise.