Arch Linux User Repository

Why do I need to wait for what feels like forever for some test suite to run on installing this? Installation should not take more than a few seconds and not run a several minutes long test suite mandatorily.

I had to create /etc/lsyncd and /var/log/lsyncd directories, which should have been created by the package?

@la1den Definitely, makes sense to me. Changed in 2.3.1-8.

The ProtectHome option in the lsyncd.service file is enabled by default, which prevents the service from accessing home directories. However, most users may need to sync files within their home directories. Therefore, wouldn't it be better to remove this option?

@flaviut, Great suggestion, fixed in 2.3.1-7. Thanks!

On my system, I have CMake default to Ninja, so this package doesn't build right. Easy fix though:

diff --git a/PKGBUILD b/PKGBUILD
index 221af70..aa8c4d9 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -65,7 +65,7 @@ check() {
   sed --in-place '/exclude-rsyncssh.lua/d' CMakeLists.txt
   sed --in-place '/churn-rsyncssh.lua/d' CMakeLists.txt

-  make -C build run-tests
+  cmake --build build --target run-tests
 }

 package() {

I seem to be mistaken, the tests only take 10 minutes for me, which I think is acceptable. Still, if you have suggestions to reduce the test time, I'm open to hear them :)

@mmlenz, I prefer to run at least some tests to verify the functionality, but I agree that the whole suite takes incredibly long time (~1 hour for me). Do you have any suggestion on how to speed it up? Or, if we were to run a smaller selection of tests, which tests should we skip?

These new tests are a bit excessive. They just run and run. Never seen a package take this long to build just running a test suite.

Just pushed an update with two significant changes:

• Running tests.
• Run the service as a separate user (lsyncd) with some hardening enabled.

There is a risk this is broken for some users or affects some use-cases. Let me know if you experience any problems.