Arch Linux User Repository

Thanks, should be resolved now.

Getting this error today:

# github.com/tdewolff/minify/v2/minify
minify/minify.go:23:115: cannot use js.Minify (value of type func(m *"github.com/tdewolff/minify/v2".M, w io.Writer, r io.Reader, params map[string]string) error) as type "github.com/tdewolff/minify/v2".Minifier in argument to Default.AddRegexp:
        func(m *"github.com/tdewolff/minify/v2".M, w io.Writer, r io.Reader, params map[string]string) error does not implement "github.com/tdewolff/minify/v2".Minifier (missing Minify method)
ok      github.com/tdewolff/minify/v2   (cached)
FAIL    github.com/tdewolff/minify/v2/benchmarks [build failed]
ok      github.com/tdewolff/minify/v2/cmd/minify        (cached)
ok      github.com/tdewolff/minify/v2/css       (cached)
ok      github.com/tdewolff/minify/v2/html      (cached)
# github.com/tdewolff/minify/v2/minify [github.com/tdewolff/minify/v2/minify.test]
minify/minify.go:23:115: cannot use js.Minify (value of type func(m *"github.com/tdewolff/minify/v2".M, w io.Writer, r io.Reader, params map[string]string) error) as type "github.com/tdewolff/minify/v2".Minifier in argument to Default.AddRegexp:
        func(m *"github.com/tdewolff/minify/v2".M, w io.Writer, r io.Reader, params map[string]string) error does not implement "github.com/tdewolff/minify/v2".Minifier (missing Minify method)
ok      github.com/tdewolff/minify/v2/js        (cached)
ok      github.com/tdewolff/minify/v2/json      (cached)
FAIL    github.com/tdewolff/minify/v2/minify [build failed]
ok      github.com/tdewolff/minify/v2/svg       (cached)
ok      github.com/tdewolff/minify/v2/xml       (cached)
FAIL
==> ERROR: A failure occurred in check().
    Aborting...

You're right, when enabling LTO explicitly I was able to reproduce the problem. I've fixed this by disabling CGO as the library doesn't use any CGO. Thanks!

Thanks @freswa for the comment, but the package seems to build fine on my end. Additionally, LTO should be a problem when using CGO, and this package does not use CGO so as far as I know there shouldn;t even be an LTO involved as we're not linking with the C toolchain...happy to hear if I'm wrong though..

Could you add an options array with "!lto" please?

options=(!lto)

With the introduction of lto, this pkg doesn't compile anymore.

Thank you

Please remove the "v" prefix from the pkgver.

Thanks @bertptrs, it now gets build from source!

The checksum is for the bash completion is currently incorrect. The current checksum should be 25f25a205ca071471daab6b1c8eeb16e0b1c8609844b158b85c76344eb4bbc31.

Aside from that, this package should just build from source since it's available. If you do, you can just use the bash completion script from the main tarbal. Pulling the master for the bash completion is just going to cause issues every time it gets pushed.

You can see check how to package a Go program here: https://wiki.archlinux.org/index.php/Go_package_guidelines

Thanks @sjuxax, should be fixed now.

FYI the checksum is out of date for minify_bash_tab_completion.