Arch Linux User Repository

btw builded packages for this here: https://sourceforge.net/projects/fabiololix-os-archive/files/Packages/

I have uploaded ocaml4 on the AUR, it is not compatible with ocaml from the official repository, fortunately there was no need to make an ocaml4 version of dune (for now)

@kolcon likely you are using an old pkgbuild or have an old cache

It does not build for me:

src/utils/net/upnp_stubs.c: In function ‘upnpPulse’:src/utils/net/upnp_stubs.c:659:41: error: too many arguments to function ‘UPNP_GetValidIGD’ 659 | if( UPNP_IGD_VALID_CONNECTED == UPNP_GetValidIGD( devlist, &map->upnpUrls, &map->upnpData, | ^~In file included from src/utils/net/upnp_stubs.c:76:/usr/include/miniupnpc/miniupnpc.h:120:1: note: declared here 120 | UPNP_GetValidIGD(struct UPNPDev * devlist, | ^~make: *** [Makefile:5476: src/utils/net/upnp_stubs.o] Error 2==> ERROR: A failure occurred in build(). Aborting...

Add these lines after the patches in prepare() function and it'll build.

# src/utils/lib/charsetstubs.c:1207:23: error: passing argument 2 of ‘iconv’ from incompatible pointer type [-Wincompatible-pointer-types]

# https://bbs.archlinux.org/viewtopic.php?id=297268

sed -i '22iCFLAGS+=" -Wno-incompatible-pointer-types"' configure

# src/utils/net/upnp_stubs.c:659:41: error: too few arguments to function ‘UPNP_GetValidIGD’

# https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef78ef66f5a4b4c92e646a45ebd20c06c756eeb3

# Arch uses version >=2.2.8 of miniupnpc

# Fix for Mldonkey comes from https://github.com/bitcoin/bitcoin/commit/8acdf66540834b9f9cf28f16d389e8b6a48516d5.patch?full_index=1%20-%3E%20${PN}-miniupnpc-2.2.8-compat.patch

sed -i 's/sizeof( map->lanaddr )/sizeof( map->lanaddr ), NULL , 0/g' src/utils/net/upnp_stubs.c

==> Making package: mldonkey 3.1.7.2-3 (Fri Jul  5 21:31:11 2024)
+ gcc -O2 -fno-strict-aliasing -fwrapv -pthread -g  -fno-omit-frame-pointer -fPIC -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions                 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security                     -fstack-clash-protection -fcf-protection -ffat-lto-objects -D_FILE_OFFSET_BITS=64    -c  -I /byterun -o src/utils/lib/charsetstubs.o -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions                 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security                     -fstack-clash-protection -fcf-protection   -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/sysprof-6  -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now   -I'/usr/lib/ocaml' 'src/utils/lib/charsetstubs.c'
src/utils/lib/charsetstubs.c: In function 'raise_error':
src/utils/lib/charsetstubs.c:171:15: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  171 |     closure_f = caml_named_value("charset_error");
      |               ^
src/utils/lib/charsetstubs.c:173:13: warning: "raise_constant" is deprecated: use "caml_raise_constant" instead
  173 |   raise_constant(*closure_f);
      |             ^~~~~~~~~~~~~~~~~                                                      
src/utils/lib/charsetstubs.c: In function 'ml_iconv':
src/utils/lib/charsetstubs.c:1207:23: error: passing argument 2 of 'iconv' from incompatible pointer type [-Wincompatible-pointer-types]
 1207 |     return iconv (cd, inbuf, inbytes_left, outbuf, outbytes_left);
      |                       ^~~~~
      |                       |
      |                       const char **
In file included from src/utils/lib/charsetstubs.c:45:
/usr/include/iconv.h:49:54: note: expected 'char ** restrict' but argument is of type 'const char **'
   49 | extern size_t iconv (iconv_t __cd, char **__restrict __inbuf,
      |                                    ~~~~~~~~~~~~~~~~~~^~~~~~~
src/utils/lib/charsetstubs.c: In function 'ml_copy_string_len_and_free':
src/utils/lib/charsetstubs.c:1339:13: warning: "alloc_string" is deprecated: use "caml_alloc_string" instead
 1339 |   v = alloc_string (len);
      |             ^~~~~~~~~~~~~                                                      
src/utils/lib/charsetstubs.c: In function 'ml_convert_string':
src/utils/lib/charsetstubs.c:1351:13: warning: "string_length" is deprecated: use "caml_string_length" instead
 1351 |   c_res = ml_convert(String_val(str),string_length(str),
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                         
src/utils/lib/charsetstubs.c: In function 'ml_utf8_validate':
src/utils/lib/charsetstubs.c:1361:13: warning: "string_length" is deprecated: use "caml_string_length" instead
 1361 |   return Val_bool(utf8_validate(SizedString_val(s),NULL));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                       
src/utils/lib/charsetstubs.c: In function 'ml_locale_charset':
src/utils/lib/charsetstubs.c:1380:13: warning: "copy_string" is deprecated: use "caml_copy_string" instead
 1380 |   return (copy_string ((char*) str));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~                                        
make[1]: *** [Makefile:5476: src/utils/lib/charsetstubs.o] Error 2
make[1]: Leaving directory '/tmp/makepkg/mldonkey/src/mldonkey-3.1.7-2'
make: *** [Makefile:5167: depend] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

There is another problem after that

https://bbs.archlinux.org/viewtopic.php?id=297268

@evilred the file is still there, anyway I made a copy in my patch collection

failed to download https://raw.githubusercontent.com/gentoo/gentoo/master/net-p2p/mldonkey/files/cpp17-byte-namespace.patch

@grosjo can't confirm, successfully build with devtools and (outdated) system, my suggestion are:

• remove any pkgbuild cache
• remove any ocaml(5) package(s) if left

My best guess is on the cache, I have different ouput:

Compiling CryptoPP.cc can take several minutes, on slow machines up to half an hour.
make[1]: Entering directory '/build/mldonkey/src/mldonkey-3.1.7-2'
make[1]: 'svg_converter.byte' is up to date.
make[1]: Leaving directory '/build/mldonkey/src/mldonkey-3.1.7-2'
/usr/bin/ocamlopt.opt -unsafe-string -inline 10 -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60    -I src/utils/extlib  [...] -I +camlp4 -I +num -c src/utils/lib/syslog.ml

Note svg_converter.byte line which is missing from yours and the first file build is syslog.ml, while I don't have filename2.cmi anywhere in my log but there are several filename2.cmx

Btw that isn't a full log, uploading full logs here isn't welcome so send it directly to me by email or with a pastbin services

Compilers:
 - OCaml version     4.14.1 
 - gcc version       13.2.1
 - g++ version       13.2.1

\nNow execute 'make' to start compiling. Good luck!

To compile a static code execute:     make mlnet.static
To produce a release tarball execute: make release.mlnet.static
To clean the build directory execute: make maintainerclean

Compiling CryptoPP.cc can take several minutes, on slow machines up to half an hour.
make[1]: Entering directory '/files/admin/aur/mldonkey/src/mldonkey-3.1.7-2'
/usr/bin/ocamlc.opt -unsafe-string -w +a-3-4-6-27-29-32-35-37-41-44-45-48-60   -I src/utils/extlib  -I src/utils/cdk  -I src/utils/bitstring  -I src/utils/lib  -I src/utils/ocamlrss  -I src/utils/xml-light  -I src/utils/net  -I tools  -I src/daemon/common  -I src/daemon/driver  -I src/utils/mp3tagui  -I src/config/unix  -I src/gtk2/gui  -I src/gtk2/gui/x11  -I src/gtk2/gui/win32  -I icons/rsvg  -I +lablgtk2  -I src/networks/direct_connect  -I src/networks/fasttrack  -I src/networks/fileTP  -I src/networks/bittorrent  -I src/networks/donkey -I +camlp4 -I +num -c src/utils/lib/misc2.ml
File "src/utils/lib/misc2.ml", line 1:
Error: src/utils/cdk/filename2.cmi
       is not a compiled interface for this version of OCaml.
It seems to be for an older version of OCaml.
make[1]: *** [Makefile:5446: src/utils/lib/misc2.cmo] Error 2
make[1]: Leaving directory '/files/admin/aur/mldonkey/src/mldonkey-3.1.7-2'
make: *** [Makefile:5167: depend] Error 2
==> ERROR: A failure occurred in build().
    Aborting...