Arch Linux User Repository

Just spotted a serious mistake in this PKGBUILD.

It creates and installs stuff to,

mpvc-git /usr/share/docs/ mpvc-git /usr/share/docs/mpvc/ mpvc-git /usr/share/docs/mpvc/README.md

This '/usr/share/docs/' should not exist in Archlinux.

It should be '/usr/share/doc' a pre existing directory.

This mistake happens because this PKBUILD is blindly following the developers Makefile. That Makefile is a generic Makefile, it is not Archlinux specific. It does basicly just 'make xxx install'

The PKGBUILD needs to be corrected so that things work for Archlinux, independently of the original Makefile.

A simple 'install xxx /usr/shared/doc/mpcv/xxx ... ' should work.

Several other issues with the installation method of this PKGBUILD were already reported in July 2023,

TLDR to the maintainer:

An Archlinux PKGBUILD is an Archlinux thing. You cannot just slap 'make generic-Makefile' and forget about it.

gesh flagged mpvc-git out-of-date on 2023-07-21 (UTC) for the following reason:

    Among massive changes in https://github.com/lwilletts/mpvc/pull/51, commits 6057994..6e136229 changed the installation method to a
    bash script. Haven't yet reported upstream, but their implementation makes `PREFIX` useless (the `install-sys` target overrides the
    passed value of `PREFIX`). In the meantime, explicitly setting `BINDIR` works instead. ``` diff --git a/PKGBUILD b/PKGBUILD index
    13a57ce..0f1ab83 100644 --- a/PKGBUILD +++ b/PKGBUILD @@ -1,6 +1,6 @@ # Maintainer: Laurence Willetts <laurencewilletts at
    protonmail dot com> pkgname=mpvc-git -pkgver=1.3.r24.g6890b36 +pkgver=1.3.r668.g4230023 pkgrel=1 pkgdesc='A mpc-like control
    interface for mpv.' @@ -26,7 +26,6 @@ build() { } package() { - prefix="/usr" cd "$srcdir/mpvc" - make DESTDIR="$pkgdir" PREFIX=
    "$prefix" install + BINDIR="$pkgdir/bin" extras/mpvc-installer install-sys } ```

• "PKGBUILD on Archlinux AUR repo is broken" , https://github.com/lwilletts/mpvc/issues/59

The latest changes made in the "Makefile" at the github repo (1.4.r42.g6193d9e-1) now make "mpvc-git" install this:

pacman -Ql mpvc-git

mpvc-git /usr/
mpvc-git /usr/bin/
mpvc-git /usr/bin/mpvc
mpvc-git /usr/bin/mpvc-autostart
mpvc-git /usr/bin/mpvc-chapter
mpvc-git /usr/bin/mpvc-equalizer
mpvc-git /usr/bin/mpvc-fzf
mpvc-git /usr/bin/mpvc-installer
mpvc-git /usr/bin/mpvc-mpris
mpvc-git /usr/bin/mpvc-tui
mpvc-git /usr/bin/mpvc-web
mpvc-git /usr/share/
mpvc-git /usr/share/docs/
mpvc-git /usr/share/docs/mpvc/
mpvc-git /usr/share/docs/mpvc/README.md
mpvc-git /usr/share/licenses/
mpvc-git /usr/share/licenses/mpvc/
mpvc-git /usr/share/licenses/mpvc/LICENSE.md

Still misses some "logbook.html" and "mpv.conf" that are in the "docs" folder at github.

Relevant github issues related to this PKGBUILD:

• "PKGBUILD on Archlinux AUR repo is broken" , https://github.com/lwilletts/mpvc/issues/59

• "explain in the README differences to lwilletts/mpvc", https://github.com/gmt4/mpvc/issues/3

Also relevant. There is also another newer "mpvc" PKGBUILD created in 2023, https://aur.archlinux.org/packages/mpvc. It is totally unrelated to this one. It is a Rust tool. The chosen name "mpvc" is only adding confusion. It should have been "mpvc-rs".But he doesnt answer comments.

pacman -Ql mpvc-git

mpvc-git /usr/
mpvc-git /usr/bin/
mpvc-git /usr/bin/mpvc
mpvc-git /usr/bin/mpvc-autostart
mpvc-git /usr/bin/mpvc-chapter
mpvc-git /usr/bin/mpvc-equalizer
mpvc-git /usr/bin/mpvc-fzf
mpvc-git /usr/bin/mpvc-installer
mpvc-git /usr/bin/mpvc-mpris
mpvc-git /usr/bin/mpvc-tui
mpvc-git /usr/bin/mpvc-web

The repo at github also includes a README, a LICENSE and a "docs" folder. The "docs" folder contains some raw html's and a mpv.conf. They are also needed and should end up in something like

/usr/share/docs/mpvc/README
/usr/share/docs/mpvc/index.html ... etc
/usr/share/licenses/mpvc/LICENCE

A simple "install" added to the PKGBULID will do the job, example

install -Dm644 LICENSE  ...

Read more here, https://wiki.archlinux.org/title/PKGBUILD

I have tried again today this PKGBUILD. It seems to build OK now. Havent tested the installed tool thouroughly yet.

This tool has had a recente release, 1.4, https://github.com/lwilletts/mpvc/releases/tag/1.4

This PKGBUILD, "mpvc-git" continues to be broken and does not build.

Cloning into 'mpvc'...
done.
==> Starting pkgver()...
==> Updated version: mpvc-git 1.4.r0.g419f83f-1
==> Sources are ready.
==> Making package: mpvc-git 1.4.r0.g419f83f-1 (Wed 01 Nov 2023 01:21:07 AM
WET)
...
==> Entering fakeroot environment...
==> Starting package()...
make: *** No rule to make target 'install'.  Stop.
==> ERROR: A failure occurred in package().
    Aborting...
 -> error making: mpvc-git-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
mpvc-git - exit status 4

The PKGBUILD was last updated on 2022-06-12 16:25 (UTC). The PKGBUILD has been marked out of date since 2023-07-21.

The maintainer of the PKGBUILD is the same as the tool developer, "lwillets".

I've notified him on github and asked him to update the PKGBUILD, https://github.com/lwilletts/mpvc/issues/59

Correction to my out-of-date flag: directly invoking install still allows PREFIX to be used usefully.

diff --git a/PKGBUILD b/PKGBUILD
index 13a57ce..6f9766c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,6 +1,6 @@
 # Maintainer: Laurence Willetts <laurencewilletts at protonmail dot com>
 pkgname=mpvc-git
-pkgver=1.3.r24.g6890b36
+pkgver=1.3.r668.g4230023
 pkgrel=1

 pkgdesc='A mpc-like control interface for mpv.'
@@ -28,5 +28,5 @@ build() {
 package() {
   prefix="/usr"
   cd "$srcdir/mpvc"
-  make DESTDIR="$pkgdir" PREFIX="$prefix" install
+  PREFIX="$pkgdir/$prefix" extras/mpvc-installer install
 }

Currently fails to build,

==> Retrieving sources...
  -> Cloning mpvc git repo...
Cloning into bare repository '/dev/shm/aurydesty/mpvc-git/mpvc'...
fatal: unable to connect to github.com:
github.com[0: 140.82.121.4]: errno=Connection timed out

==> ERROR: Failure while downloading mpvc git repo
    Aborting...
 -> error downloading sources: mpvc-git 
     context: exit status 1 

I has a strange "git://" in the source instead of using "https://"

source=('git://github.com/wildefyr/mpvc')

As stated before

github.com/wildefyr

doesnt exist anymore. It should be,

github.com/lwilletts

Needs update the url has changed:

from

Upstream URL:   https://github.com/wildefyr/mpvc

to

https://github.com/lwilletts/mpvc

# Maintainer: Tudor Roman <xenogenesis at openmailbox dot org>
# Contributor: Alexey Andreyev <aa13q@ya.ru>

pkgname=mpvc-git
pkgver=1.2.r105.g44a746c
pkgrel=1
pkgdesc="A mpc-like control interface for mpv"
arch=('armv7h' 'i686' 'x86_64' 'aarch64')
url="https://github.com/lwilletts/${pkgname%-git}"
license=('MIT')
depends=('mpv' 'socat')
makedepends=('git')
optdepends=()
provides=("${pkgname%-git}")
conflicts=()
source=(
  "${pkgname}::git+${url}.git"
)
sha256sums=('SKIP')

pkgver() {
  cd "${srcdir}/${pkgname}"
  ( set -o pipefail
    git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g' ||
    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
  ) 2>/dev/null
}

build() {
  cd "$pkgname"
}

package() {
  cd "$pkgname"
  mkdir -p "$pkgdir/usr/bin"
  make DESTDIR="$pkgdir" PREFIX="/usr" install
}