Arch Linux User Repository

btw there has been a patch upstream too https://github.com/flaviotordini/musique/commit/ba468521e5998f14fe387cd3051be95cead2e9ac

Thanks once more, pallegro. I've added these patches.

taglib 2.0 update breaks musique. this quick patch made it build and run for me:

diff -rupw A/musique/src/coverutils.cpp B/musique/src/coverutils.cpp
--- A/musique/src/coverutils.cpp    2024-02-04 20:43:02.898812700 -0400
+++ B/musique/src/coverutils.cpp    2024-02-04 21:18:43.757537366 -0400
@@ -158,8 +158,8 @@ bool CoverUtils::coverFromMP4(const QStr
    TagLib::MP4::Tag *tag = static_cast<TagLib::MP4::Tag *>(f.tag());
    if (!tag) return false;

-    TagLib::MP4::ItemListMap itemsListMap = tag->itemListMap();
-    TagLib::MP4::Item coverItem = itemsListMap["covr"];
+    TagLib::MP4::ItemMap itemsMap = tag->itemMap();
+    TagLib::MP4::Item coverItem = itemsMap["covr"];
    TagLib::MP4::CoverArtList coverArtList = coverItem.toCoverArtList();
    TagLib::MP4::CoverArt coverArt = coverArtList.front();

diff -rupw A/musique/src/mainwindow.cpp B/musique/src/mainwindow.cpp
--- A/musique/src/mainwindow.cpp    2024-02-04 20:43:02.898812700 -0400
+++ B/musique/src/mainwindow.cpp    2024-02-04 21:16:07.143978275 -0400
@@ -90,6 +90,7 @@ $END_LICENSE */
#include "updater.h"
#endif

+#include <iostream>

namespace {
MainWindow *singleton = nullptr;
diff -rupw A/musique/src/tags/mp4utils.h B/musique/src/tags/mp4utils.h
--- A/musique/src/tags/mp4utils.h   2024-02-04 20:43:02.902146222 -0400
+++ B/musique/src/tags/mp4utils.h   2024-02-04 21:19:21.949373826 -0400
@@ -9,7 +9,7 @@
namespace Mp4Utils {

void load(TagLib::MP4::Tag *tag, Tags *tags) {
-    const TagLib::MP4::ItemListMap &map = tag->itemListMap();
+    const TagLib::MP4::ItemMap &map = tag->itemMap();

    if (map.contains("trkn")) {
        TagLib::MP4::Item::IntPair intPair = map["trkn"].toIntPair();
@@ -31,7 +31,7 @@ void load(TagLib::MP4::Tag *tag, Tags *t
        tags->setComposerSort(v);
    }

-    TagLib::MP4::ItemListMap::ConstIterator it = map.find("aART");
+    TagLib::MP4::ItemMap::ConstIterator it = map.find("aART");
    if (it != map.end()) {
        TagLib::StringList sl = it->second.toStringList();
        if (!sl.isEmpty())

Thanks, pallegro. Fixed.

needs git -c protocol.file.allow=always submodule update

see https://wiki.archlinux.org/title/VCS_package_guidelines#Git_submodules

Thank you, Corax. Make-dependency qt5-declarative added.

@mrxx: please add qt5-declarative to makedepends, without it I get:

Project MESSAGE: Building Musique 1.10.1
Project MESSAGE: Qt 5.15.2 in /usr
Project MESSAGE: Building for release
Project MESSAGE: QT: core gui network sql widgets dbus qml dbus
Project MESSAGE: CONFIG: lex yacc debug exceptions depend_includepath testcase_targets import_plugins import_qpa_plugin file_copies qmake_use qt warn_on release link_prl incremental shared shared release linux unix posix gcc c++17 exceptions_off optimize_full object_parallel_to_source
Project MESSAGE: DEFINES: APP_VERSION=1.10.1 APP_NAME=Musique APP_UNIX_NAME=musique QT_NO_DEBUG_OUTPUT QT_USE_QSTRINGBUILDER QT_STRICT_ITERATORS QT_DEPRECATED_WARNINGS HTTP MEDIA_MPV MEDIA_AUDIOONLY APP_LINUX DATADIR=\"/usr/share\" PKGDATADIR=\"/usr/share/musique\"
Project MESSAGE: QMAKE_CXXFLAGS: -pipe
Project MESSAGE: QMAKE_LFLAGS:
Project ERROR: Unknown module(s) in QT: qml
==> ERROR: A failure occurred in build().
    Aborting...
error making: musique

Thanks for the clarification. Dependency qt5-base added.

@mrxx: makedepends() are only build dependencies. qt5-base is a runtime dependency. Without it in depends(), if you run makepkg -srif it will remove qt5-tools and qt5-base.

Removed dependency phonon-qt5. (No need for qt5-base as it is already pulled in as a dependency of qt5-tools.)