Package Details: ncp 1.2.4-1

Git Clone URL: https://aur.archlinux.org/ncp.git (read-only, click to copy)
Package Base: ncp
Description: A fast file copy tool for LANs
Upstream URL: http://www.fefe.de/ncp/
Licenses: custom
Submitter: noctux
Maintainer: noctux
Last Packager: noctux
Votes: 2
Popularity: 0.083366
First Submitted: 2016-03-06 16:27 (UTC)
Last Updated: 2016-03-06 16:38 (UTC)

Dependencies (2)

Required by (0)

Sources (2)

Latest Comments

andreas_baumann commented on 2025-01-23 05:48 (UTC) (edited on 2025-01-23 05:48 (UTC) by andreas_baumann)

tar is a dependency of the 'base' package (as POSIX tool), no need to add id explicitely.

dreieck commented on 2025-01-22 19:43 (UTC)

tar should be added to the depends array. (ncp calls tar.)

dreieck commented on 2025-01-22 19:27 (UTC) (edited on 2025-01-22 19:28 (UTC) by dreieck)

Ahoj,

fix to this build error reported in 2024-10-06:

1) Create a path fix_CFLAGS_acceptance.patch:

diff -rU1 ncp-1.2.4.orig/GNUmakefile ncp-1.2.4/GNUmakefile
--- ncp-1.2.4.orig/GNUmakefile  2025-01-22 20:14:33.803283144 +0100
+++ ncp-1.2.4/GNUmakefile   2025-01-22 20:16:00.063282582 +0100
@@ -8,3 +8,3 @@
 CC=gcc
-CFLAGS=-pipe -Wall
+CFLAGS?=-pipe -Wall
 LDFLAGS=

2) Apply this patch in prepare(), and append -I/usr/include/libowfat to $CFLAGS in build(). Patch to the PKGBUILD:

--- PKGBUILD.orig   2025-01-22 20:23:47.803279510 +0100
+++ PKGBUILD.new    2025-01-22 20:23:29.783279629 +0100
@@ -12,8 +12,22 @@
 source=("https://dl.fefe.de/$pkgname-$pkgver.tar.bz2"
-        "https://dl.fefe.de/$pkgname-$pkgver.tar.bz2.sig")
-md5sums=('421c4855bd3148b7d0a4342942b4bf13' 'ac496f2913a016cf987e28303bb04d94')
+        "https://dl.fefe.de/$pkgname-$pkgver.tar.bz2.sig"
+        "fix_CFLAGS_acceptance.patch")
+md5sums=('421c4855bd3148b7d0a4342942b4bf13' 'ac496f2913a016cf987e28303bb04d94' '1dfccf7b2fe5c7956170a1f359989bc8')
 validpgpkeys=('878CBE5DA9A50595E674183F15396A7933EB059A') # Felix von Leitner, expired

+prepare() {
+   cd "$pkgname-$pkgver"
+
+   for _patch in "${srcdir}/fix_CFLAGS_acceptance.patch"; do
+       printf '%s\n' "   > Applying patch '$(basename "${_patch}")' ..."
+       patch -Np1 --follow-symlinks -i "${_patch}"
+   done
+}
+
 build() {
    cd "$pkgname-$pkgver"
+   
+   CFLAGS+=" -I/usr/include/libowfat"
+   export CFLAGS
+   
    sed -i 's/\/man\//\/share\/man\//' GNUmakefile

Regards!

dreieck commented on 2025-01-22 19:20 (UTC)

You need to

  • make the license identifier SPDX compliant,
  • if it is not a common license (listed at /usr/share/licenses/spdx/), install the license into /usr/share/licenses/${pkgname}/.

Regards and thanks for the package!

andreas_baumann commented on 2024-10-06 07:40 (UTC) 

/usr/bin/diet -Os gcc -pipe -Wall -O2 -fomit-frame-pointer   -c -o ncp.o ncp.c
ncp.c:8:10: fatal error: dns.h: No such file or directory
    8 | #include "dns.h"
      |          ^~~~~~~
compilation terminated.
make: *** [<builtin>: ncp.o] Error 1

CFLAGS contains a reference to a local libowfat (-I../include/libowfat), this should point to the system location (-I/usr/include/libowfat).

in build(): sed -i 's|../libowfat|/usr/include/libowfat|g' GNUmakefile

Also, patching should happen in the prepare() target and not in build() IMHO.