Package Details: netatop-dkms 3.1-2

Git Clone URL: https://aur.archlinux.org/netatop-dkms.git (read-only, click to copy)
Package Base: netatop-dkms
Description: Atop network kernel module, enables network statistics in atop
Upstream URL: http://www.atoptool.nl/
Keywords: atop dkms kernel module netatop
Licenses: GPL
Groups: modules
Conflicts: netatop
Submitter: m1kc
Maintainer: m1kc
Last Packager: m1kc
Votes: 13
Popularity: 0.000061
First Submitted: 2015-06-02 10:10 (UTC)
Last Updated: 2020-12-24 08:31 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 Next › Last »

<deleted-account> commented on 2020-04-24 07:38 (UTC)

... OK so firstly,

boottime is a u64, not a u32. This was already in the changelog... C'mon guys... Pay attention...

then, as described in https://lore.kernel.org/linux-fsdevel/20191225172228.GA13378@avx2/ , You have to use proc_ops in newer kernels instead of file_operations

Proof of concept: use this prepare() of the PKGBUILD:

prepare() {
        true
        #patch -d "${srcdir}/${_pkgname}-${pkgver}" -Np1 -i "${srcdir}"/netatop_kernel_5.5.patch
        sed -i 's/timespec/timespec64/g'  $srcdir/$_pkgname-$pkgver/module/netatop.c
        sed -i 's/getboottime/getboottime64/g' $srcdir/$_pkgname-$pkgver/module/netatop.c
        sed -i 's/file_operations/proc_ops/g' $srcdir/$_pkgname-$pkgver/module/netatop.c
        sed -i 's/\.open/\.proc_open/g' $srcdir/$_pkgname-$pkgver/module/netatop.c
        sed -i 's/\.read/\.proc_read/g' $srcdir/$_pkgname-$pkgver/module/netatop.c
        sed -i 's/\.llseek/\.proc_lseek/g' $srcdir/$_pkgname-$pkgver/module/netatop.c
        sed -i 's/\.release/\.proc_release/g' $srcdir/$_pkgname-$pkgver/module/netatop.c
        sed -i '354d' $srcdir/$_pkgname-$pkgver/module/netatop.c
}

It should work then. I do not get why anyone has noticed this yet, also upstream. They could have already spot this minor problems upstream on RC kernels (yes, that is what they are for). Above all, This fix was very simple...

frankspace commented on 2020-04-20 14:26 (UTC)

I've reported to upstream that this no longer compiles under linux kernel version 5.6, but I've no idea whether upstream noticed yet.

m1kc commented on 2020-04-20 10:47 (UTC)

Updated to netatop 3.0.

stef204 commented on 2020-04-20 08:37 (UTC)

patch needs updating for 5.6+ kernel.

111MilesToGo commented on 2020-03-12 11:37 (UTC)

Looking at netatop, v3.0 is out now and available in the AUR. Please, is it possible to update netatop-dkms to v3.0? Thanks a lot in advance.

m1kc commented on 2020-03-02 11:31 (UTC)

Package updated. Added patch for kernels >= 5.5 - big thanks to people who did all the research work. LTS kernels are now supported as well.

bartus commented on 2020-02-28 14:48 (UTC)

Patch for kernel>=5.5

git am < <(curl -s http://ix.io/1ovB)

111MilesToGo commented on 2020-02-27 14:19 (UTC)

IF the fix applied to netatop (not the dkms) for 5.5 kernels is correct, could you then please apply it to netatop-dkms, too. Thanks a lot.

<deleted-account> commented on 2020-01-26 13:08 (UTC)

it seems that, for the 5.5 kernels, the C code has changed somehow. I'm not A C coder, but it seems that the suggestion in the error of the dkms build just works.

dkms install -m netatop -v 2.0 -k 5.5.0-rc7-New #(my test 5.5rc kernel, just like linux-mainline)

---errordump--- /var/lib/dkms/netatop/2.0/build/netatop.c:969:33: error: 'struct task_struct' has no member named 'real_start_time'; did you mean 'start_time'? 969 | tip->btime = div_u64((current->real_start_time + | ^~~~~~~~~~~~~~~ | start_time ---errordump---

Now I just tried what it suggested and it worked:

sed -i 's/real_start_time/start_time/g' /usr/src/netatop-2.0/netatop.c

dkms install -m netatop -v 2.0 -k 5.5.0-rc7-New

---outputdump--- Kernel preparation unnecessary for this kernel. Skipping...

Building module: cleaning build area... make -j24 KERNELRELEASE=5.5.0-rc7-New -C /usr/lib/modules/5.5.0-rc7-New/build M=/var/lib/dkms/netatop/2.0/build... cleaning build area... Kernel cleanup unnecessary for this kernel. Skipping...

DKMS: build completed. ---outputdump---

Does this make sense what I'm saying? Or did I just get lucky? Hope this helps someone.

stef204 commented on 2016-09-27 19:59 (UTC) (edited on 2016-09-28 10:09 (UTC) by stef204)

@m1kc thanks for this package. @hrast i've just installed it and it built both dkms modules; the libalpm hooks take care of it automatically: ==> dkms install -m netatop -v 1.0 -k 4.4.22-1-lts ==> dkms install -m netatop -v 1.0 -k 4.7.4-1-ARCH and it does work with both kernels. not so for you?