Arch Linux User Repository

Please implement a proper pkgver() function as per Arch guidelines.

@melvinvermeeren,

Thanks. All the best.

@rjahanbakhshi Thanks for the info, just made the changes. Good luck with maintainership!

Cheers

@melvinvermeeren,
You did it correctly, otherwise, the package would become orphaned. Now that I'm a co-maintainer, if you remove the other co-maintainer and disown the package, the ownership will be transferred.

@rjahanbakhshi Thanks a lot for your help! I've added you to both this and domoticz-git. I'm not familiar with disowning and it seems to have some unwanted side effects so I went with the co-maintainer route for now.

Cheers

@melvinvermeeren,

I already am maintaining a few AUR packages. I'm using this package and domoticz-git and have local modifications to make them work. If you still want, I have time to take over these two packages.

Hi all, since the last years I have stopped using openzwave and have come to a point where I think I cannot update this properly for now. Is someone interested in helping out via co-maintainer or taking over the entire package? Thanks!

Thanks for the patch, @darkbasic. Yes, I've since used the zwavejs2mqtt AUR package (with a Docker container for home-assistant) with great success.

This is the patch which needs to be applied if someone has permissions to modify this ebuild:

commit b36712c9464f4c8c07d99d8c7f8d64612f121494
Author: Niccolò Belli <niccolo.belli@linuxsystems.it>
Date:   Mon Oct 4 16:25:21 2021 +0200

    Fix build

diff --git a/cpp/build/Makefile b/cpp/build/Makefile
index 27ffa338..dacf26ff 100644
--- a/cpp/build/Makefile
+++ b/cpp/build/Makefile
@@ -13,10 +13,10 @@


 # what flags we will use for compiling in debug mode
-DEBUG_CFLAGS    := -Wformat -Wall -Wno-unknown-pragmas -Wno-inline -Werror -Wno-error=sequence-point -Wno-sequence-point -ggdb -DDEBUG -fPIC  -DSYSCONFDIR="\"$(PREFIX)/etc/openzwave/\""
+DEBUG_CFLAGS    := -Wformat -Wall -Wno-unknown-pragmas -Wno-inline  -Wno-error=sequence-point -Wno-sequence-point -ggdb -DDEBUG -fPIC  -DSYSCONFDIR="\"$(PREFIX)/etc/openzwave/\""
 DEBUG_CPPFLAGS  := -std=c++11 
 # what flags we will use for compiling in release mode
-RELEASE_CFLAGS  := -Wall -Wno-unknown-pragmas -Werror -Wno-error=sequence-point -Wno-sequence-point -O3 -DNDEBUG -fPIC  -DSYSCONFDIR="\"$(PREFIX)/etc/openzwave/\""
+RELEASE_CFLAGS  := -Wall -Wno-unknown-pragmas  -Wno-error=sequence-point -Wno-sequence-point -O3 -DNDEBUG -fPIC  -DSYSCONFDIR="\"$(PREFIX)/etc/openzwave/\""
 RELEASE_CPPFLAGS := -std=c++11
 #what flags we will use for linking in debug mode
 DEBUG_LDFLAGS  := -g
diff --git a/cpp/examples/MinOZW/Makefile b/cpp/examples/MinOZW/Makefile
index ec613e55..5cccf366 100644
--- a/cpp/examples/MinOZW/Makefile
+++ b/cpp/examples/MinOZW/Makefile
@@ -10,8 +10,8 @@
 .PHONY:    default clean


-DEBUG_CFLAGS    := -Wall -Wno-format -ggdb -DDEBUG $(CPPFLAGS) -std=c++11 
-RELEASE_CFLAGS  := -Wall -Wno-unknown-pragmas -Wno-format -O3 $(CPPFLAGS) -std=c++11 
+DEBUG_CFLAGS    := -Wall -ggdb -DDEBUG $(CPPFLAGS) -std=c++11 
+RELEASE_CFLAGS  := -Wall -Wno-unknown-pragmas -O3 $(CPPFLAGS) -std=c++11 

 DEBUG_LDFLAGS  := -g

diff --git a/cpp/hidapi/configure.ac b/cpp/hidapi/configure.ac
index 3533bef7..d6b0b2a7 100644
--- a/cpp/hidapi/configure.ac
+++ b/cpp/hidapi/configure.ac
@@ -19,7 +19,7 @@ lt_age="0"
 LTLDFLAGS="-version-info ${lt_current}:${lt_revision}:${lt_age}"

 AC_CONFIG_MACRO_DIR([m4])
-AM_INIT_AUTOMAKE([foreign -Wall -Werror])
+AM_INIT_AUTOMAKE([foreign -Wall ])
 AC_CONFIG_MACRO_DIR([m4])

 m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
diff --git a/debian/rules b/debian/rules
index cf55ac77..dfbe13c7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,10 +2,10 @@

 export DH_VERBOSE=1

-# because of a issue un Ubuntu - cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
-CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS | sed -e "s/-Wformat-security//g" -e "s/-Wformat//g" -e "s/-Werror\=format-security//g")
-CFLAGS:=$(shell dpkg-buildflags --get CFLAGS | sed -e "s/-Wformat-security//g" -e "s/-Wformat//g" -e "s/-Werror\=format-security//g")
-CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS | sed -e "s/-Wformat-security//g" -e "s/-Wformat//g" -e "s/-Werror\=format-security//g")
+# because of a issue un Ubuntu - cc1: error: -Wformat-security ignored without -Wformat [=format-security]
+CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS | sed -e "s/-Wformat-security//g" -e "s/-Wformat//g" -e "s/\=format-security//g")
+CFLAGS:=$(shell dpkg-buildflags --get CFLAGS | sed -e "s/-Wformat-security//g" -e "s/-Wformat//g" -e "s/\=format-security//g")
+CXXFLAGS:=$(shell dpkg-buildflags --get CXXFLAGS | sed -e "s/-Wformat-security//g" -e "s/-Wformat//g" -e "s/\=format-security//g")
 LDFLAGS:=$(shell dpkg-buildflags --get LDFLAGS)
 #XXX: MORECPPFLAGS=-fPIE -pie
 MORECPPFLAGS:=$(CFLAGS)

P.S. Just a hint, you should probably stop using openzwave and migrate to zwave-js ;)

I, too, found it necessary to run these commands to successfully build:

cd ~/aur/openzwave-git # the top-level directory containing PKGBUILD
makepkg --nobuild
cd src/open-zwave
grep -rIn Werror | grep -v PKGBUILD | cut -d':' -f1 | xargs sed -i 's|-Werror||g'
cd ../..
makepkg --noextract

Update!

I also had to edit openzwave-git/src/open-zwave/cpp/examples/MinOZW and remove -Wno-format. In other words, I changed this:

DEBUG_CFLAGS    := -Wall -Wno-format -ggdb -DDEBUG $(CPPFLAGS) -std=c++11
RELEASE_CFLAGS  := -Wall -Wno-unknown-pragmas -Wno-format -O3 $(CPPFLAGS) -std=c++11

to this:

DEBUG_CFLAGS    := -Wall -ggdb -DDEBUG $(CPPFLAGS) -std=c++11
RELEASE_CFLAGS  := -Wall -Wno-unknown-pragmas -O3 $(CPPFLAGS) -std=c++11