Package Details: polymc 6.1-1

Git Clone URL: https://aur.archlinux.org/polymc.git (read-only, click to copy)
Package Base: polymc
Description: Minecraft launcher with the ability to manage multiple instances
Upstream URL: https://github.com/PolyMC/PolyMC
Licenses: GPL3
Submitter: glorious-yellow
Maintainer: LennyLennington (Kaydax, sperg512)
Last Packager: Kaydax
Votes: 65
Popularity: 0.21
First Submitted: 2022-01-11 20:53 (UTC)
Last Updated: 2024-01-11 19:59 (UTC)

Dependencies (18)

Required by (1)

Sources (1)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 Next › Last »

LennyLennington commented on 2022-04-22 10:40 (UTC)

@dada513 oh yeah you're right my bad

dada513 commented on 2022-04-19 19:05 (UTC) (edited on 2022-04-19 19:05 (UTC) by dada513)

yeah its fine but with the tarball you dont have to maintain submodules void and others already use the tarball as it's easier to maintain it

Scrumplex commented on 2022-04-19 18:38 (UTC)

Using Git as a source is a completely valid approach on Arch Linux. Don't really see a reason to use a vendored tarball

dada513 commented on 2022-04-19 16:42 (UTC)

@LennyLennington no, that patch uses the vendored tarball which is a git checkout generated by github actions that has submodules in it. It does not download any binaries

LennyLennington commented on 2022-04-19 14:37 (UTC) (edited on 2022-04-19 14:40 (UTC) by LennyLennington)

@dada513 that isn't right, that is just a patch to turn it into polymc-bin

dada513 commented on 2022-04-19 11:38 (UTC)

Patch to use vendored tarball, 1.2.0, LTO, and fix dependencies

From 91c7faa77b8c25517134b0695e4c82cf2c65fd7c Mon Sep 17 00:00:00 2001
From: dada513 <dada513@protonmail.com>
Date: Tue, 19 Apr 2022 13:35:33 +0200
Subject: [PATCH] Update to 1.2.0, use vendored tarball, fix dependencies

---
 PKGBUILD | 31 ++++++++++---------------------
 1 file changed, 10 insertions(+), 21 deletions(-)

diff --git a/PKGBUILD b/PKGBUILD
index 7e3e8e6..1f21419 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,16 +3,16 @@
 # Contributor: Lenny McLennington <lennymclennington@protonmail.com>
 # Contributor: Miko <mikoxyzzz@gmail.com>
 # Contributor: Cheru Berhanu <aur attt cheru doot dev>
+# Contributor: dada513 <dada513@protonmail.com>

 pkgname=polymc
-pkgver=1.1.1
+pkgver=1.2.0
 pkgrel=1
 pkgdesc="Minecraft launcher with ability to manage multiple instances."
 arch=('i686' 'x86_64')
 url="https://github.com/PolyMC/PolyMC"
 license=('GPL3')
-depends=('java-runtime' 'libgl' 'qt5-base' 'zlib')
-provides=('polymc')
+depends=('java-runtime' 'libgl' 'qt5-base' 'zlib' 'qt5-imageformats' 'qt5-svg' 'hicolor-icon-theme')
 conflicts=('polymc')
 makedepends=('cmake' 'git' 'java-environment')
 optdepends=('glfw: to use system GLFW libraries'
@@ -20,41 +20,30 @@ optdepends=('glfw: to use system GLFW libraries'
             'visualvm: Profiling support'
             'xorg-xrandr: for older minecraft versions'
 )
-source=("PolyMC::git+https://github.com/PolyMC/PolyMC#tag=${pkgver}"
-        "git+https://github.com/MultiMC/libnbtplusplus#commit=dc72a20b7efd304d12af2025223fad07b4b78464"
-        "git+https://github.com/PolyMC/quazip#commit=c9ef32de19bceb58d236f5c22382698deaec69fd")
+source=("https://github.com/PolyMC/PolyMC/releases/download/$pkgver/PolyMC-$pkgver.tar.gz")

-sha256sums=('SKIP'
-            'SKIP'
-            'SKIP')
-
-prepare() {
-  cd "${srcdir}/PolyMC"
-  git submodule init
-  git config submodule.libnbtplusplus.url "${srcdir}/libnbtplusplus"
-  git config submodule.quazip.url "${srcdir}/quazip"
-  git submodule update
-}
+sha256sums=('f2bc1b0b18a166445e3ca03d3e0f606043c57b1811317079603bef4e44994484')

 build() {
-  cd "${srcdir}/PolyMC"
+  cd "${srcdir}/PolyMC-$pkgver"
   mkdir -p build

   cd build
   cmake -DCMAKE_BUILD_TYPE=None \
     -DCMAKE_INSTALL_PREFIX="/usr" \
-    -DLauncher_PORTABLE=OFF \
+    -DLauncher_BUILD_PLATFORM="archlinux" \
     -DLauncher_APP_BINARY_NAME="${pkgname}" \
+    -DENABLE_LTO=ON \
     ..
   cmake --build .
 }

 check() {
-  cd "${srcdir}/PolyMC/build"
+  cd "${srcdir}/PolyMC-$pkgver/build"
   ctest .
 }

 package() {
-  cd "${srcdir}/PolyMC/build"
+  cd "${srcdir}/PolyMC-$pkgver/build"
   DESTDIR="$pkgdir" cmake --install .
 }
-- 
2.35.3

LennyLennington commented on 2022-04-19 11:13 (UTC)

@glorious-yellow could you add @Scrumplex as a co-maintainer please

ChrisLane commented on 2022-04-18 11:25 (UTC) (edited on 2022-04-18 11:47 (UTC) by ChrisLane)

1.2.0 builds fine with lto enabled. Here's a PKGBUILD diff for 1.2.0 in general:

diff --git a/PKGBUILD b/PKGBUILD
index 7e3e8e6..caa22ce 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -5,7 +5,7 @@
 # Contributor: Cheru Berhanu <aur attt cheru doot dev>

 pkgname=polymc
-pkgver=1.1.1
+pkgver=1.2.0
 pkgrel=1
 pkgdesc="Minecraft launcher with ability to manage multiple instances."
 arch=('i686' 'x86_64')
@@ -21,8 +21,8 @@ optdepends=('glfw: to use system GLFW libraries'
             'xorg-xrandr: for older minecraft versions'
 )
 source=("PolyMC::git+https://github.com/PolyMC/PolyMC#tag=${pkgver}"
-        "git+https://github.com/MultiMC/libnbtplusplus#commit=dc72a20b7efd304d12af2025223fad07b4b78464"
-        "git+https://github.com/PolyMC/quazip#commit=c9ef32de19bceb58d236f5c22382698deaec69fd")
+        "git+https://github.com/PolyMC/libnbtplusplus#commit=2203af7eeb48c45398139b583615134efd8d407f"
+        "git+https://github.com/stachenov/quazip#commit=6117161af08e366c37499895b00ef62f93adc345")

 sha256sums=('SKIP'
             'SKIP'

Scrumplex commented on 2022-04-02 23:04 (UTC)

This needs qt5-svg and qt5-imageformats. Otherwise, most icons won't work.

Also, namcap complains that hicolor-icon-theme isn't a dependency

FintasticMan commented on 2022-04-01 12:32 (UTC)

I'm unable to build with lto enabled, but without lto it compiles and installs just fine. I'm unable to reproduce the issue @katt has with test #7 failing, it passes just fine for me.