Arch Linux User Repository

PSA: Like most of the PKGBUILDs that I (co-)maintain, I host prebuilt packages for this in my user repository and all its dependencies for those who wish to install it using pacman without messing around with building from the AUR. Issues or contributions are welcome either in comments below or via this GitHub repository.

Thanks, I'll apply the first one.

Okay, you say you will, but you haven't. I'd be happy to actually do the work, if you don't have time yourself to address issues or follow guidelines please at least add me as a co-maintainer. I've been commenting and sending patches like this for years. I didn't even bother reporting this one because you hadn't accepted most of my fixes, so I just had this one forked for my own use.

For the second one, I'd rather just patch setup.py the way I did for ufo2ft.

Why are you trying to patch upstream projects to build with different tooling when they build fine with the dependencies they were specified upstream (and which are in Arch repositories)?

If you want to spend energy fixing broken packages, how about you look at python-skia-pathops, where you're a co-maintainer? This one really is completely broken.

Yes, it was quite broken. I just fixed it — not with an ideal fix but at least with something that follows Arch guidelines for what to do when Wheels are the only known way.

Thanks, I'll apply the first one. For the second one, I'd rather just patch setup.py the way I did for ufo2ft.

If you want to spend energy fixing broken packages, how about you look at python-skia-pathops, where you're a co-maintainer? This one really is completely broken.

Per previous discussion, here are two incremental packages needed to bring this up to even minimal Arch packaging requirements. This package does not build before these patches, and it does with them. There are more things mentioned in the Arch Python package guidelines that are not correct yet, but this is an essential start to even get a working build.

Please apply each with git am < file.patch:

From 2bdc0771d31c9b7bb1fbea27845198e856008ec5 Mon Sep 17 00:00:00 2001
From: Caleb Maclennan <caleb@alerque.com>
Date: Mon, 19 Jul 2021 18:51:50 +0300
Subject: [PATCH 1/2] Split build/package functions

See https://wiki.archlinux.org/title/Python_package_guidelines#distutils

Signed-off-by: Caleb Maclennan <caleb@alerque.com>
---
 PKGBUILD | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/PKGBUILD b/PKGBUILD
index 4f7a0f4..0cf40e1 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -15,9 +15,14 @@ arch=('x86_64')
 source=("https://files.pythonhosted.org/packages/source/${_pkgname:0:1}/$_pkgname/$_pkgname-$pkgver.tar.gz")
 sha256sums=('e24bd03c94944e1536ec8437ab83fb4ac38477412426c1ffd4e056dd16cde235')

+build() {
+    cd "$_pkgname-$pkgver"
+    python setup.py build
+}
+
 package() {
-    cd "${_pkgname}-${pkgver}"
-    python setup.py install --root="${pkgdir}" --optimize=1
+    cd "$_pkgname-$pkgver"
+    python setup.py install --root="${pkgdir}" --optimize=1 --skip-build
 }

 check() {
-- 
2.32.0

From 1d4a1b99df1446ee32adf14e3efe9dfae800f6dc Mon Sep 17 00:00:00 2001
From: Caleb Maclennan <caleb@alerque.com>
Date: Mon, 19 Jul 2021 18:53:08 +0300
Subject: [PATCH 2/2] Fix incorrect make dependency, patch out unnecessary one

Signed-off-by: Caleb Maclennan <caleb@alerque.com>
---
 .SRCINFO |  5 ++---
 PKGBUILD | 10 ++++++++--
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index c3885ce..2ace580 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,15 +1,14 @@
 pkgbase = python-cffsubr
    pkgdesc = Standalone CFF subroutinizer based on AFDKO tx
    pkgver = 0.2.8
-   pkgrel = 1
+   pkgrel = 2
    url = https://github.com/adobe-type-tools/cffsubr
    arch = x86_64
    license = Apache
    checkdepends = python-pytest
-   makedepends = python-setuptools
+   makedepends = python-setuptools-scm
    depends = python-fonttools
    source = https://files.pythonhosted.org/packages/source/c/cffsubr/cffsubr-0.2.8.tar.gz
    sha256sums = e24bd03c94944e1536ec8437ab83fb4ac38477412426c1ffd4e056dd16cde235

 pkgname = python-cffsubr
-
diff --git a/PKGBUILD b/PKGBUILD
index 0cf40e1..13be564 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,20 +1,26 @@
 # Maintainer: Guillaume Horel <guillaume.horel@gmail.com>
+# Contributor: Caleb Maclennan <caleb@alerque.com>

 pkgname='python-cffsubr'
 _pkgname='cffsubr'
 pkgver=0.2.8
-pkgrel=1
+pkgrel=2
 pkgdesc="Standalone CFF subroutinizer based on AFDKO tx"
 url="https://github.com/adobe-type-tools/cffsubr"
 checkdepends=('python-pytest')
 depends=('python-fonttools')
-makedepends=('python-setuptools')
+makedepends=('python-setuptools-scm')
 optdepends=()
 license=('Apache')
 arch=('x86_64')
 source=("https://files.pythonhosted.org/packages/source/${_pkgname:0:1}/$_pkgname/$_pkgname-$pkgver.tar.gz")
 sha256sums=('e24bd03c94944e1536ec8437ab83fb4ac38477412426c1ffd4e056dd16cde235')

+prepare() {
+    cd "$_pkgname-$pkgver"
+    sed -i -e '/git-ls-files/d' setup.py
+}
+
 build() {
     cd "$_pkgname-$pkgver"
     python setup.py build
-- 
2.32.0