Any reason the tests were removed in this last commit? Does the pypi version not ship with the tests?
Search Criteria
Package Details: python-syncedlyrics 1.0.1-1
Package Actions
Git Clone URL: | https://aur.archlinux.org/python-syncedlyrics.git (read-only, click to copy) |
---|---|
Package Base: | python-syncedlyrics |
Description: | Get an LRC format (synchronized) lyrics for your music |
Upstream URL: | https://github.com/moehmeni/syncedlyrics |
Keywords: | lrc lyrics lyrics-fetcher lyrics-finder lyrics-search music music-bot music-player synced-lyrics synchronization |
Licenses: | MIT |
Submitter: | txtsd |
Maintainer: | txtsd (pekkarr) |
Last Packager: | txtsd |
Votes: | 9 |
Popularity: | 0.49 |
First Submitted: | 2023-03-15 19:06 (UTC) |
Last Updated: | 2024-11-10 07:12 (UTC) |
Dependencies (9)
- python (python37AUR, python311AUR, python310AUR)
- python-beautifulsoup4
- python-rapidfuzz (python-rapidfuzz-gitAUR)
- python-requests
- python-build (make)
- python-installer (make)
- python-poetry-core (python-poetry-core-gitAUR) (make)
- python-wheel (make)
- python-pytest (check)
Required by (1)
Sources (1)
gesh commented on 2024-03-07 12:16 (UTC)
pekkarr commented on 2024-01-26 14:22 (UTC)
@Typology I can't reproduce the error, please post the whole check
output. You can also build in a clean chroot or disable tests with --nocheck
makepkg option.
Typology commented on 2024-01-26 12:58 (UTC)
File "/usr/lib/python3.11/site-packages/pytest_asyncio/plugin.py", line 501, in <module>
@pytest.hookimpl(specname="pytest_pycollect_makeitem", tryfirst=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: HookimplMarker.__call__() got an unexpected keyword argument 'specname'
==> ERROR: A failure occurred in check().
Aborting...
error: failed to build 'python-syncedlyrics-0.8.0-1':
any idea what's the problem here?
aminvakil commented on 2023-10-20 13:54 (UTC)
@pekkarr Sorry for late response, oddly tests run OK for me as well now :|
Anyway I will continue on running this package without running checks, as this is only needed for python-spotdl dependency in my testing environment, and this has gone too far for me.
This was the failing test at the time: https://github.com/aminvakil/aur/actions/runs/6555075825/job/17803026288#step:6:2166
Unfortunately I do not have failed tests which I ran locally then.
pekkarr commented on 2023-10-18 13:23 (UTC)
@aminvakil The tests run successfully for me. What's the failed test output you got? Upstream disabled Netease tests on their CI so if it's related to that then that specific test could be disabled in the PKGBUILD as well.
aminvakil commented on 2023-10-18 12:05 (UTC) (edited on 2023-10-18 12:05 (UTC) by aminvakil)
Tests are failing again, most probably it's related to upstream, I've disabled running tests on python-spotdl before makepkg commands.
pekkarr commented on 2023-09-28 16:50 (UTC)
@gesh thanks fox noticing, the tests are fixed in 0.6.1-2
gesh commented on 2023-09-28 15:56 (UTC)
https://github.com/0x7d4/syncedlyrics/commit/b3f99287312c60c91e2345de72e64591dbcc52eb should fix the tests, no need to disable them (besides, anybody bothered by failing tests should just pass --nocheck
instead of disabling them in the PKGBUILD)
aminvakil commented on 2023-09-25 07:24 (UTC)
Thanks, 0.6.0-2 fixed the issue (https://github.com/aminvakil/aur/actions/runs/6293835195/job/17090511646).
txtsd commented on 2023-09-25 07:09 (UTC)
Yea it's failing repeatedly locally for me too. I'll disable tests in the PKGBUILD.
Pinned Comments
txtsd commented on 2024-07-20 09:16 (UTC) (edited on 2024-07-20 09:17 (UTC) by txtsd)
Tests often fail when a search provider is unavailable.
Build with
makepkg --nocheck
to skip tests.If using an AUR helper like yay, it's
yay -S --mflags --nocheck
.