Arch Linux User Repository

I've pushed 1.26.9-5 with a fix for the RECENT_DATE expiry.

Please kindly rerun the build and report if the problem is resolved or not. :)

Yes, lol, I've found the same.

There is a hard-coded date for 2020-07-01 in connection.py, and the test fails if the current date is at least 2 years later! ':-)

vim src/urllib3-1.26.9/src/urllib3/connection.py

change line 71 RECENT_DATE from 2020 to 2022 fix this build fail.

 69 # When it comes time to update this value as a part of regular maintenance
 70 # (ie test_recent_date is failing) update it to ~6 months before the current date.
 71 RECENT_DATE = datetime.date(2020, 7, 1)

Cleared the build cache and there's a different error this time, outside the Flaky Test Report. (This may have appeared before if I was misreading how the Flaky Tests work)

=================================== FAILURES ===================================
_______________________ TestConnection.test_recent_date ________________________

self = <test.test_connection.TestConnection object at 0x7fb944babfd0>

    def test_recent_date(self):
        # This test is to make sure that the RECENT_DATE value
        # doesn't get too far behind what the current date is.
        # When this test fails update urllib3.connection.RECENT_DATE
        # according to the rules defined in that file.
        two_years = datetime.timedelta(days=365 * 2)
>       assert RECENT_DATE > (datetime.datetime.today() - two_years).date()
E       AssertionError: assert datetime.date(2020, 7, 1) > datetime.date(2020, 7, 1)
E        +  where datetime.date(2020, 7, 1) = <built-in method date of datetime.datetime object at 0x7fb9458b98d0>()
E        +    where <built-in method date of datetime.datetime object at 0x7fb9458b98d0> = (datetime.datetime(2022, 7, 1, 9, 31, 46, 55853) - datetime.timedelta(730)).date
E        +      where datetime.datetime(2022, 7, 1, 9, 31, 46, 55853) = <built-in method today of type object at 0x7fb94762b880>()
E        +        where <built-in method today of type object at 0x7fb94762b880> = <type 'datetime.datetime'>.today
E        +          where <type 'datetime.datetime'> = datetime.datetime

...

= 1 failed, 1621 passed, 284 skipped, 55 deselected, 151 warnings in 45.56 seconds =
==> ERROR: A failure occurred in check().
    Aborting...

+1 push: 1.26.9-4: added back optdepends (were removed by mistake).

Not sure where the problem can come from. I was unable to reproduce. Though I am not using Pamac.

I've pushed 1.26.9-3 to disable that one specific test case (test_request_host_header_ignores_fqdn_dot).

Maybe there is some problem with the test dummy server in certain environments.

Please kindly try to build again and report back if it succeeds or not.

Thanks for reporting. I will look into it as soon as I have the chance.

Meanwhile, could you please retry the full build after deleting the build cache? It would be helpful for me to know if this is happening again or maybe it happens only sometimes.

This is refusing to build:

test_request_host_header_ignores_fqdn_dot failed; it passed 0 out of the required 1 times.
    <class 'urllib3.exceptions.NewConnectionError'>
    <urllib3.connection.HTTPConnection object at 0x7f09f03bd890>: Failed to establish a new connection: [Errno 111] Connection refused
    [<TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/test/with_dummyserver/test_socketlevel.py:1617>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/request.py:75>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/request.py:96>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/connectionpool.py:786>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/util/retry.py:525>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/connectionpool.py:710>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/connectionpool.py:398>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/connection.py:239>, <TracebackEntry /usr/lib/python2.7/httplib.py:1099>, <TracebackEntry /usr/lib/python2.7/httplib.py:1139>, <TracebackEntry /usr/lib/python2.7/httplib.py:1095>, <TracebackEntry /usr/lib/python2.7/httplib.py:898>, <TracebackEntry /usr/lib/python2.7/httplib.py:860>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/connection.py:205>, <TracebackEntry /var/tmp/pamac-build-tangomyk/python2-urllib3/src/urllib3-1.26.9/src/urllib3/connection.py:187>]
...
===End Flaky Test Report===
= 1 failed, 1622 passed, 284 skipped, 54 deselected, 151 warnings in 46.40 seconds =
==> ERROR: A failure occurred in check().
    Aborting...