Arch Linux User Repository

Thank you all for the contributions, I was away for the past two weeks.

I have updated the package accordingly.

The pull request was accepted, please update the package. Here is a patch to do so

diff --git a/010-qoi-use-arch-flags.patch b/010-qoi-use-arch-flags.patch
deleted file mode 100644
index 30c53c2..0000000
--- a/010-qoi-use-arch-flags.patch
+++ /dev/null
@@ -1,21 +0,0 @@
---- a/Makefile
-+++ b/Makefile
-@@ -1,7 +1,8 @@
- CC ?= gcc
- CFLAGS_BENCH ?= -std=gnu99 -O3
--LFLAGS_BENCH ?= -lpng
-+LFLAGS_BENCH ?= -lpng $(LDFLAGS)
- CFLAGS_CONV ?= -std=c99 -O3
-+LFLAGS_CONV ?= $(LDFLAGS)
- 
- TARGET_BENCH ?= qoibench
- TARGET_CONV ?= qoiconv
-@@ -15,7 +16,7 @@ $(TARGET_BENCH):$(TARGET_BENCH).c
- 
- conv: $(TARGET_CONV)
- $(TARGET_CONV):$(TARGET_CONV).c
--  $(CC) $(CFLAGS_CONV) $(CFLAGS) $(TARGET_CONV).c -o $(TARGET_CONV)
-+  $(CC) $(CFLAGS_CONV) $(CFLAGS) $(TARGET_CONV).c -o $(TARGET_CONV) $(LFLAGS_CONV)
- 
- .PHONY: clean
- clean:
diff --git a/PKGBUILD b/PKGBUILD
index bc34b71..4e66710 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,25 +7,19 @@ pkgname=(qoi-headers-git
          qoibench-git
         )
 pkgbase=qoi-git
-pkgver=r321.9c487be
+pkgver=r335.d4fc9d1
 pkgrel=1
 pkgdesc="The 'Quite OK Image' format for fast, lossless image compression"
 arch=('x86_64')
 url='https://qoiformat.org/'
 license=('MIT')
-source=("$source_dir::git+https://github.com/phoboslab/qoi.git"
-        "010-qoi-use-arch-flags.patch")
+source=("$source_dir::git+https://github.com/phoboslab/qoi.git")
 makedepends=('git'
              'gcc-libs'
              'stb'
              'libpng'
              )
-sha256sums=('SKIP'
-            '3c5aed75c5560fe782cdb47b713be7292291b37fa311f74a01ec88561f0e321f')
-
-prepare() {
-    patch -d $source_dir -Np1 -i "${srcdir}/010-qoi-use-arch-flags.patch"
-}
+sha256sums=('SKIP')

 pkgver() {
   cd $source_dir

Created https://github.com/phoboslab/qoi/pull/299 for it ;)

Yeah... the Makefile keeps changing upstream. Patches to it should probably be pushed upstream too.

==> Start prepare()...
patching file Makefile
Hunk #2 FAILED at 16.
1 out of 2 hunks FAILED -- saving rejects to file Makefile.rej
==> ERROR: An error ocurred in prepare().
    Aborting...

@dbermond Thank you for catching those issues. I have fixed them.

As for the separate packages, I think the meta-package system is designed for this, people can just build qoi-git and get all of it in one. The main reason I did not want to install/package all in one, is because qoibench depends on libpng, which seems like an unnecessary dependency to pull for people that just want the library. That being said I have noticed that for people using aur helpers like aurutils, they cant just get qoi-git as intended

@lbatalha The package is lacking the use of Arch Linux flags. You are overwriting CFLAGS with the command 'make CFLAGS="-I /usr/include/stb/"'. It should be 'CFLAGS+= -I/usr/include/stb' (notice the '+=', and the not '='). LDFLAGS is missing from upstream Makefile, and this prevents the binaries from using important security flags defined in LDFLAGS, as like as LTO. For using Arch's LDFLAGS you need to patch the Makefile. You can see an example of such a patch in the qoa-git package. Also, there is no need for splitting the package in multiple binary ones for providing a single 200kb binary in each one of then, as this goes against the Arch Linux simplicity principle. You can package everything in a single qoi-git package.

The value of pkgbase for this package is incorrect. It should be "qoiconv-git", not "qoi-git".

I have updated the PKGBUILD to unpin the commit hash.

Also changed the build to use the Makefile.

Not that there's been any meaningful updates upstream, but in the spirit of the -git name we should consider unpinning the git hash and just take the latest version.

Compare

==> Updated version: qoi-git r274.b8d77df-1

vs: warning: qoiconv-git-r192.09d144f-2 is up to date -- reinstalling

At that point we should also consider making use of the new Makefile targets.

Con for this: you get all the pointless qoi/Readme.md "here's another qoi implementation" causing everyone's aur packages to get rebuilt.