Arch Linux User Repository

Gosh... Why it's so complicated.

Ok with libxml2, libseccomp and libcurl. I edited that.

Then if I remove git I get this:

...
gcc  -DNDEBUG -O2 -Wall -Wextra -fno-strict-aliasing  -I/usr/include/libxml2 -o src/prep_article.o -c src/prep_article.c
make: git: No such file or directory
gcc  -DNDEBUG -O2 -Wall -Wextra -fno-strict-aliasing  -I/usr/include/libxml2 -o src/readability.o -c 
...

so I have to get this dependency. Also I use it for -v option.

And I leave it here now - https://github.com/nebulosa2007/PKGBUILDs

I hope you find this information useful when writing your own PKGBUILDs ;)

Thank you for your answers. I'm sorry but I dont understand some of them.

glibc Why ? ...
Just for suppress message from namcap:
nothing special..

... git as a make dependcy
Not necessary. Just eyecandy stuff....

Please check a README file.
For a three years some changes happened.

I assume you mean the rdrview README on the github file. Nothing has changed in 3 years regarding the instructions to build and requirements. The developer is very clear:

There are three direct dependencies: libxml2, libseccomp and libcurl.

That's it. That's all you need.

You write:

But you write to a wrong person :) I just make a package with last version
for convenience.

No, I dont write to the wrong person.

You have created a package 3 years after a previous package for the same tool already existed. You cant ignore that and make it as it has nothnig to do with your work.

You are in the AUR and you are supposed to care about consistency and the convenience of all users. That means paying attention to previous work. And discussing/coordinating with others who have started doing that work before you, if you think things should be very different and you want to make more options/additions.

I will just leave it here now. I hope you have all the references needed and can reconsider your decisions.

• https://wiki.archlinux.org/index.php?title=PKGBUILD

• https://wiki.archlinux.org/title/Arch_User_Repository

It would be nice if both PKGBUILD's could cooperate

Agree. But you write to a wrong person :) I just make a package with last version for convenience.

"rdrview-git" is much simpler:

For a three years some changes happened. Please check a README file.

glibc Why ? This is basic system dependency. Why do you put it in depends ?

Just for suppress message from namcap:

rdrview W: Dependency glibc detected and implicitly satisfied (libraries ['usr/lib/libm.so.6', 'usr/lib/libc.so.6'] needed in files ['usr/bin/rdrview'])

nothing special..

optdepends Why ? Nothing of that is necessary. What is "xdg-utils" and "libcurl-gnutls" doing ther ?

Please read README file. Anyway, you not need install any of optdepend packages and skip them. xdg-utils contains xdg-open utility needed for headless machines.

git as a make dependcy

Not necessary. Just eyecandy stuff. For -v option

Thanks for the work maintaining this "rdview" PKGBUILD. This is a very usefull and important tool. Maybe with enough votes, it could one day be an official Arch package.

Here are some comments about this PKGBUILD.

I am not a PKGBUILD expert. I might be wrong. But here are some things that might be worth reviewing and carefully checking.

There is already a much older, https://aur.archlinux.org/pkgbase/rdview-git It would be nice if both PKGBUILD's could cooperate, check each other and share work to avoid reduplicating effort and maintaining consistency.

"rdrview-git"
First Submitted               : Mon 19 Oct 2020 07:57:36 PM WEST
Maintainer: Parker Reed <parker.l.reed@gmail.com>

Since you only started this in 2024,

"rdrview":
First Submitted               : Sat 20 Apr 2024 06:53:05 PM WEST
Maintainer: Nebulosa <nebulosa2007-at-yandex-dot-ru>

Let's compare them:

"rdrview":

.......
depends=(
  curl
  glibc
  libseccomp
  libxml2
)
optdepends=(
  'elinks: open pages in elinks'
  'libcurl-gnutls: backend that provides the SSL support'
  'links: open pages in links'
  'lynx: open pages in lynx'
  'w3m: open pages in w3m'
  'xdg-utils: for opening pages'
)

makedepends=(
  git
)
.....
..... ???? there is this here "strange" "git get-tar-xxxx"
.....
  local _commit=$(zcat ../$pkgname-$pkgver.tar.gz | git get-tar-commit-id)

"rdrview-git" is much simpler:

.....
depends=('curl' 'libxml2' 'libseccomp')
.......
makedepends=('git')

Comment 1. glibc

Why ? This is basic system dependency. Why do you put it in depends ?

Comment 2. optdepends

Why ? Nothing of that is necessary. What is "xdg-utils" and "libcurl-gnutls" doing ther ?

Comment 3. git as a make dependcy

Since this "rdview" is not a "-git" PKGBUILD, it is a bit strange to have git as a dependency, even if it is "only" a make dependency.

What is that "git get-tar xxxx " thing ? Is it really necessary ? Is it reallly the only way to get the version id ?

Thanks in advance.