Some notification daemon don't set their own timeout and rely on the application, so I guess relying on the default settings might not be the best solution for those daemons.
Search Criteria
Package Details: rocketchat-desktop 4.1.2-1
Package Actions
Git Clone URL: | https://aur.archlinux.org/rocketchat-desktop.git (read-only, click to copy) |
---|---|
Package Base: | rocketchat-desktop |
Description: | Rocket.Chat Native Cross-Platform Desktop Application via Electron |
Upstream URL: | https://github.com/RocketChat/Rocket.Chat.Electron |
Keywords: | chat client electron rocket rocketchat |
Licenses: | MIT |
Submitter: | sum01 |
Maintainer: | buzo |
Last Packager: | buzo |
Votes: | 30 |
Popularity: | 0.90 |
First Submitted: | 2017-10-23 16:52 (UTC) |
Last Updated: | 2024-11-13 19:58 (UTC) |
Dependencies (8)
- electron32 (electron32-binAUR)
- libvips (libvips-gitAUR, libvips-notiffAUR)
- nodejs (nodejs-lts-fermiumAUR, nodejs-gitAUR, python-nodejs-wheelAUR, nodejs-lts-hydrogen, nodejs-lts-iron)
- asar (make)
- node-gyp (corepackerAUR) (make)
- openjpeg2 (openjpeg-gitAUR) (make)
- python-distutils-extra (make)
- yarn (yarn-pnpm-corepackAUR, corepackerAUR, yarn-berryAUR) (make)
Required by (0)
Sources (2)
Latest Comments
« First ‹ Previous 1 .. 7 8 9 10 11 12 13 14 15 16 17 18 Next › Last »
matthias.lisin commented on 2019-02-14 14:56 (UTC)
Turtizzle commented on 2019-02-14 14:12 (UTC)
Reporting back after testing for 1 day myself: I've had mixed results with this particular patch. Earlier, I tested it with a hardcoded timeout of 10 seconds, which worked fine. I assumed, removing it entirely would use the default value, but now the messages won't disappear again, just like before. :/
I'll keep you informed if I figure out more.
matthias.lisin commented on 2019-02-13 14:47 (UTC)
Hello Turtizzle my friend, Thanks for the suggestion, I've been annoyed by the never disappearing notifications for a while now but never got around to see what's wrong.
I have applied the suggested patch, let's see how well it works.
Turtizzle commented on 2019-02-13 14:21 (UTC) (edited on 2019-02-13 14:21 (UTC) by Turtizzle)
May I suggest adding the following patch? It removes the hard coded 24h notification timeout and uses the configured default timeout of the notification daemon instead.
diff -ura package.orig/src/background/notifications.js package.new/src/background/notifications.js
--- package.orig/src/background/notifications.js 2019-02-13 15:06:35.778156745 +0100
+++ package.new/src/background/notifications.js 2019-02-13 15:07:01.368069410 +0100
@@ -86,7 +86,6 @@
body: body && this.escapeBody(body),
icon: icon ? path.resolve(icon) : 'info',
appName: app.getName(),
- timeout: 24 * 60 * 60 * 1000,
sound: silent ? undefined : 'message-new-instant',
actions: process.env.XDG_CURRENT_DESKTOP !== 'Unity' ? {
default: '',
matthias.lisin commented on 2019-02-08 08:45 (UTC)
There is a good chance the next release will use Electron 3.
To the future, and beyond. ( ͡° ͜ʖ ͡°)
matthias.lisin commented on 2018-12-31 23:20 (UTC)
The package now uses the system electron2. Therefore it is now a dependency of this package. Don't worry about the additional size of the new dependency, because this package lost most than 120M of size itself!
Spell checking now uses the system hunspell dictionaries instead of using the ones provided by upstream. This is a breaking change and you need to install the desired hunspell-* packages to re-enable spell checking. Again, this is a zero sum game, the size gained by installing system hunspell dicts is lost through removing the package dicts.
Next upstream rocketchat-update is likely to use electron3, so don't worry about electron2 being somewhat a waste of space if you have electron installed also. It's gone soon.
As always, report problems.
matthias.lisin commented on 2018-12-02 20:48 (UTC)
I decided against leaving this package broken. As a temporary solution the yarn.lock Lockfile will be ignored.
Waiting for https://github.com/RocketChat/Rocket.Chat.Electron/issues/1024
Also had to patch the package.json due to (another) broken dependencie concerning electron-updater. I quickly tested it on my home machine and it seems to work.
Everything is a mess.
God have mercy
matthias.lisin commented on 2018-12-02 20:18 (UTC) (edited on 2018-12-02 20:45 (UTC) by matthias.lisin)
Edit: this comment is obsolete now
Hi je-vv, yes, it's broken now. But I can't fix it that easily because it's an issue somewhere else. (this whole event-stream drama)
I reported it upstream and will update as soon as it's fixed upstream. I would really like to patch it myself, but I'm not an expert and will probably break something else if I try to.
je-vv commented on 2018-12-02 02:51 (UTC)
Build of 2.14.4 failing with:
==> Extracting sources...
-> Extracting rocketchat-desktop-2.14.4.tar.gz with bsdtar
==> Starting prepare()...
patching file electron-builder.json
Hunk #1 succeeded at 86 (offset 10 lines).
patching file tasks/release.js
==> Removing existing $pkgdir/ directory...
==> Starting build()...
yarn install v1.12.3
[1/4] Resolving packages...
[2/4] Fetching packages...
error https://registry.yarnpkg.com/event-stream/-/event-stream-3.3.6.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "Unexpected end of data"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
==> ERROR: A failure occurred in build().
Aborting...
==> ERROR: build: failure on package rocketchat-desktop
Pinned Comments