Arch Linux User Repository

Hi, checksum fail. For me the correct one is:

475271880d3f78bcd571b6c2d382f855c8451f41cba992a51ac9fd7e7c9d84e2 rustdesk-1.2.2-0-x86_64.pkg.tar.zst

Hey, sorry, but I won't maintain this package anymore.

I stopped using it, because the codebase is incredibly bad to the point where I wonder how it's even functional.

Just have a look at this file for example: https://github.com/rustdesk/rustdesk/blob/master/src/platform/linux.rs
All paths are formatted with format!(), while rust has a builtin cross-platform solution for paths, which would probably also save them a lot of duplicate code. Furthermore, a lot of functionality is accomplished by executing shell commands, and piping the result into other shell commands, which is just bad style. What if one of these shell commands isn't installed on a system?

Also a lot of edge-cases seem to be unhandled:

https://github.com/rustdesk/rustdesk/blob/5875cb1896936ddff47e3931ac11e6ab37ce1036/src/platform/linux.rs#L1180
What happens if $HOME is unset? Ah yes, of course it tries to create the file /.config/autostart/rustdesk.desktop.

https://github.com/rustdesk/rustdesk/blob/5875cb1896936ddff47e3931ac11e6ab37ce1036/src/platform/linux.rs#L671
If you cancel the pkexec prompt, rustdesk thinks you have super-user permissions, because pkexec then exits with 127 instead of 126.

These are just a few examples I found without much effort in a few minutes. You might argue that these aren't critical issues, and I agree. But if all of their code is written in a similar fashion, it will almost certainly also contain a lot of actual security issues.

But the worst thing about rustdesk is their lack of respect for the users (or the users system). Since version 1.2.0, rustdesk always creates an autostart entry, forcing you into workarounds like modifying the autostart entry to avoid autostarting it. When I reported this issue, they just closed it as wontfix, without any explanation: https://github.com/rustdesk/rustdesk/issues/4863

And they have done similar things in the past, where they changed your gdm configuration and disabled wayland with a simple click on a button that said "Fix it!", with no explanation on what it's going to do: https://github.com/rustdesk/rustdesk/blob/1.1.9/src/platform/linux.rs#L411-L422

Their code quality has also been critized in the past:
https://news.ycombinator.com/item?id=34723752
https://news.ycombinator.com/item?id=34723595

So that's definitely enough reason for me to not trust the authors of this software. You're free to keep using this software, but I didn't want to just stop maintaining this package without stating my reasons. If anyone wants to co-maintain this package you can give taotieren a ping.

@Marzal: Thanks, added!

lang=C rustdesk --tray

thread '<unnamed>' panicked at 'Failed to load ayatana-appindicator3 or appindicator3 dynamic library
libayatana-appindicator3.so.1: no se puede abrir el fichero del objeto compartido: No existe el fichero o el directorio
libappindicator3.so.1: no se puede abrir el fichero del objeto compartido: No existe el fichero o el directorio
libayatana-appindicator3.so: no se puede abrir el fichero del objeto compartido: No existe el fichero o el directorio
libappindicator3.so: no se puede abrir el fichero del objeto compartido: No existe el fichero o el directorio', /root/.cargo/registry/src/-6b4b463b3dd26ee0/libappindicator-sys-0.8.0/src/lib.rs:41:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Abortado (`core' generado)

I think that libappindicator-gtk3 and libayatana-appindicator should be on optdepend.

Comment out the exec line in ~/.config/autostart/rustdesk.desktop if you don't want it to run on logon.

rustdesk-nightly @Kingtous

RustDesk has pre-released the nightly version made by flutter. May be a rustdesk-nightly aur can be issued?

More details: https://github.com/rustdesk/rustdesk/releases/tag/nightly

@taotieren, when I install it creates a new category "Other" in the menu (tested on XFCE and Cinnamon). If you change the .desktop file to "Network" it works fine! Can you create a new line under prepare like:

sed -i "s/Other/Network/g" "$srcdir/usr/share/rustdesk/files/rustdesk.desktop" TIA

@andy5995 It also segfaults for me. Not sure if the binary needs rebuilding, but even if it does we can't do anything about it, because we're just packaging the release assets from the rustdesk github repo (since this is a -bin package).

If you want a version that can be rebuilt have a look at rustdesk and rustdesk-git.

Does the binary need rebuilding? When I use '-h' or '--help', rustdesk segfaults. (v1.1.9-2)