Arch Linux User Repository

I was just about to comment on this issue again, but it was fixed a few hours ago, which I noticed as yay updated it right now, so thank you to whoever did that! You helped a lot of people that just want to have a basic package template to get a custom spotify-player with the least trouble possible :3

@alosarjos You (and the other maintainer) ignored the problem for six months, even though more than one person complained about it. It wasn't a threat, but the next step if you insisted on leaving the package in an unbuildable state. It is a well known problem with Rust. If you haven't encountered it, you haven't kept makepkg.conf up to date.

@xiota, AFAIK LTO issues do not affect this package, since this comes with the default feature set and not the lyrics finder that is what causes the issue. I have disabled LTO but it's not necessary for this package and honestly having people "threatening" with orphan request for something that is not required/affecting here when the package was updated 3 days ago is the last thing I was expecting.

@alosarjos Recommendations by HurricanePootis are non-controversial.

LTO needs to be disabled with Rust packages because the default on Arch is to attempt to build with LTO enabled. Using options=('!lto') is effectively the same as adding -ffat-lto-objects to CFLAGS. The difference is fat-lto-objects allows the linker to disable LTO after wasting time trying to link with it enabled.

This issue was described in comment on 2024-05-29. Six months is more than long enough to fix it. I will follow with an orphan request if this is not fixed "soon".

Hi @HurricanePootis

First of all thanks for the feedback, I will try to look better into it and try to update the package this weekend.

With this Rust projects though, I'm not sure if the "normal package" should include a different set of features than the default ones. That's the biggest question I have right now with the provided patch.

But still thanks a lot

@alosarjos, your package could do with the following changes:

1. Add preprare() to fetch cargo deps like stated in the Rust Packaging Guidlines
2. Change build() to follow the guidlines. --locked needs to be used instead of --frozen due to a weird dep issue with aensi.
3. Add export CFLAGS="$CFLAGS -ffat-lto-objects" to fix LTO compiling
4. Add a bunch of missing dependencies, like sdl2, gstreamer, libpulse, etc.

I have also created a librespot-auth package to help with authentication.

I am listing a patch here:

diff --git a/PKGBUILD b/PKGBUILD
index 01fdcce..7852536 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,15 +7,25 @@ pkgdesc="A command driven spotify player."
 arch=('x86_64' 'aarch64' 'armv7h')
 url="https://github.com/aome510/spotify-player"
 license=('MIT')
-depends=('alsa-lib' 'openssl' 'dbus')
+depends=('alsa-lib' 'openssl' 'dbus' 'gstreamer' 'jack' 'sdl2' 'libpulse' 'glib2' 'portaudio' 'libsixel' 'glibc' 'gcc-libs'
+    'gst-plugins-base-libs')
 makedepends=('cargo')
 source=("${pkgname}-${pkgver}.tar.gz::https://github.com/aome510/spotify-player/archive/v${pkgver}.tar.gz")
 sha512sums=('a9b753e7f956874597c6c0e47a5c9366be0d07b7f7d27c424d24e464edeaba4add862c5d82bac0c32932e9525efbe8501422ef574adb5e7400052964f7687d2c')

-build() {
+
+prepare() {
   cd "${pkgname}-${pkgver}"
+  export RUSTUP_TOOLCHAIN=stable
+  cargo fetch --locked --target "$(rustc -vV | sed -n 's/host: //p')"
+}

-  cargo build --locked --release --bin spotify_player --no-default-features
+build() {
+  cd "${pkgname}-${pkgver}"
+  export RUSTUP_TOOLCHAIN=stable
+  export CARGO_TARGET_DIR=target
+  export CFLAGS="$CFLAGS -ffat-lto-objects"
+  cargo build --locked --release --all-features
 }

 package() {

spotifys newly introduced OAuth2 client authentication method hasn't been implemented up so far, thus its lacks a basic functionality, for at least 2 months already.

A workaround is to retrieve a valid OAuth2 token via ncspot temporarily. cp ~/.config/ncspot/librespot/credentials.json ~/.config/spotify_player/credentials.json

librespot-auth should work as well to retrieve valid credentials https://github.com/dspearson/librespot-auth

Linking with lyric_finder enabled fails due to the ring crate + openssl. It boils down to -flto=auto being set, which is standard since 2023. The issue was discussed in the forum and the gitlab, and heftig's verdict is: Package maintainers should disable lto per-package manually, with options=(!lto). spotify-player-full does this for example.

Crazy how nobody thinks of adding this to the rust, makepkg, creating a package or the rust package guidelines wiki article, considering it can waste a day of time easily (especially with rusts long compile times).

Technically this package does not need this change, as its default PKGBUILD does not build lyric-finder, but as it's used by most people as base to build the customized binary with, I think it would make sense to at least warn of it or include this note.

package fails to compile after latest update EDIT: works now

It includes the features that the developer has as defaults. If you want to enable more you can change the PKGBUILD