Package Details: supertux-advance-bin 0.2.0-7

Git Clone URL: https://aur.archlinux.org/supertux-advance-bin.git (read-only, click to copy)
Package Base: supertux-advance-bin
Description: A SuperTux game made in Brux GDK with 16bit-style graphics.
Upstream URL: https://github.com/KelvinShadewing/supertux-advance
Licenses: AGPL-3.0-only
Conflicts: supertux-advance
Submitter: Aryan
Maintainer: Aryan (tulpenkiste)
Last Packager: Aryan
Votes: 0
Popularity: 0.000000
First Submitted: 2025-01-23 10:10 (UTC)
Last Updated: 2025-01-31 12:15 (UTC)

Latest Comments

fabiscafe commented on 2025-02-04 09:36 (UTC) (edited on 2025-02-04 09:37 (UTC) by fabiscafe)

Hey. The PKGBUILD scares me a bit for the structure overall. What do you think about something like this?

Changelog:

Ensure a more consistent logic in the PKGBUILD

* Eliminate the additional use of unzip
* Improve permission handling
* Include transient dependencies
* Avoid Windows binaries in a more elegant manner

# Maintainer: Tulpenkiste <tulpenkiste at the amogus email domain which is .cloud>
# Maintainer: Aryan Ghasemi <aryangh1379@gmail.com>

_pkgname=supertux-advance
pkgname=supertux-advance-bin
pkgver=0.2.0
pkgrel=6
pkgdesc="A SuperTux game made in Brux GDK with 16bit-style graphics."
arch=('x86_64')
url="https://github.com/KelvinShadewing/supertux-advance"
license=('AGPL-3.0-only')
depends=(
  bash
  brux-gdk
  gcc-libs
  glibc
  hicolor-icon-theme
  sdl2-compat
  sdl2_gfx
  sdl2_image
  sdl2_mixer
)
conflicts=("supertux-advance")

source=(
  "${_pkgname}-${pkgver}.zip::$url/releases/download/v${pkgver}/sta-${pkgver}.zip"
  "$_pkgname.desktop"
  "$_pkgname"
)
b2sums=('cda831d459a01935e8c4c6ec25a9bf63f063639b4929eb4c451572b7946c9108dc99e7a76e288c50bed3bf96ab33542decebdc5d50b7652784c7ec6683b30d49'
        'a0aaf13e5e7e8c5f40d387fe837238bd2e3c2523d745e4d1e75a3b98dd4a15d62518a860162c1971e6739165c09b761e1d3425dbd39a8e67a2ab286a3024ac52'
        '6177a13f079504f1cb6baffbb71b9bded2e2763ef5988917b1560b611f06351f68b08b29b2e55182fbd227b9e74f68f42eda8ef020214bd8c7e0df8688cad99b')


package() {
  # Copy folder structure with good permissions
  /usr/bin/find . \
    -type d \
    -exec \
    /usr/bin/install -dm755 "${pkgdir}/opt/${_pkgname}/{}" \;

  # Populate with game-data, except the Windows bits and the executable
  /usr/bin/find . \
    -type f \
    ! -name "sta" \
    ! -name "*.dll" \
    ! -name "*.exe" \
    -exec \
    /usr/bin/install -m644 "{}" "${pkgdir}/opt/${_pkgname}/{}" \;

  # Install executable and start-script
  /usr/bin/install -D -m755 "${srcdir}/sta" \
    "${pkgdir}/opt/${_pkgname}/sta"
  /usr/bin/install -D -m755 "${srcdir}/supertux-advance" \
    "${pkgdir}/usr/bin/supertux-advance"

  # Desktop File
  /usr/bin/install -D -m644 "${srcdir}/supertux-advance.desktop" \
    "${pkgdir}/usr/share/applications/supertux-advance.desktop"

  # License
  /usr/bin/install -D -m644 "${srcdir}/LICENSE" \
    "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"

  # Install Icon
  /usr/bin/install -D -m644 "${srcdir}/icon.png" \
    "$pkgdir/usr/share/icons/hicolor/16x16/apps/$_pkgname.png"
}

tulpenkiste commented on 2025-01-20 16:43 (UTC)

Prior comments were resolved by me.

tulpenkiste commented on 2025-01-11 15:37 (UTC)

Also, in the packages current form, it should probably be called supertux-advance-bin.

tulpenkiste commented on 2025-01-11 15:28 (UTC) (edited on 2025-01-11 23:19 (UTC) by tulpenkiste)

License is incorrect (should be AGPL-3.0(-only)).

Also I personally think this package should use a v(version).(archive format) (e.g. v0.2.0.tar.gz) instead of sta-(version).zip (e.g. sta-0.2.0.zip) along with depending on brux (AUR packages: brux-gdk, brux-gdk-git) (as to not install the runtime multiple times).