Package Details: thermald-git 2.5.4.r0.g63b290f-1

Git Clone URL: https://aur.archlinux.org/thermald-git.git (read-only, click to copy)
Package Base: thermald-git
Description: The Linux Thermal Daemon program from 01.org
Upstream URL: https://github.com/intel/thermal_daemon
Licenses: GPL2
Conflicts: thermald
Provides: thermald
Submitter: rat4
Maintainer: codebling
Last Packager: codebling
Votes: 25
Popularity: 0.000000
First Submitted: 2013-05-11 09:18 (UTC)
Last Updated: 2024-01-17 02:10 (UTC)

Required by (5)

Sources (2)

Latest Comments

1 2 3 Next › Last »

codebling commented on 2021-05-15 01:08 (UTC)

@dr460nf1r3 it feels like the version tags should exactly match what is used upstream but you seem to know better than I do, so I'm going to defer to your superior knowledge and make the change

dr460nf1r3 commented on 2021-05-12 10:08 (UTC)

Thanks! Also you might want to replace the sed part in pkgver() with sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' to remove the v from it :)

codebling commented on 2021-05-11 20:15 (UTC)

@dr460nf1r3 done, thanks.

dr460nf1r3 commented on 2021-05-11 18:17 (UTC)

Please add upower & libevdev to makedepends, needed in clean chroots

codebling commented on 2021-01-05 05:11 (UTC)

@intelfx updated

codebling commented on 2021-01-03 20:44 (UTC)

@intelfx great thanks for the explanation! Will make the change

intelfx commented on 2021-01-03 20:22 (UTC) (edited on 2021-01-03 20:24 (UTC) by intelfx)

@codebling Not sure what exactly are you asking. The revision number and commit count are always since the last tag, but git only considers annotated tags by default (and ignores unannotated tags). By using git describe --tags, you are telling it to consider all tags.

The best practice for packaging is to follow what the project does. Some projects use annotated tags for releases and unannotated tags for temporary garbage. Other projects only use unannotated tags, and some projects do not have any well-defined policy and use a mix of both.

Thus, it is not to keep the revision number smaller or anything like that, but rather just to keep your pkgver close to reality. For example, if I build your PKGBUILD, it will produce a package with a version of 1.4.2.rxxx.gyyy, thus making an impression that the last released version was 1.4.2 and the built package contains "some unreleased commits on top of 1.4.2". Whereas in fact the last release version of thermald is 2.4.1.

codebling commented on 2021-01-01 21:53 (UTC)

@intelfx can do. Just to be clear -- if the tags were annotated, the revision number/commit count (.rxxx in the package version) would be since the last tag? Is this considered best practice for packaging? Is this considered better since the revision number is smaller?

intelfx commented on 2021-01-01 16:11 (UTC)

Please use git describe --long --tags in your pkgver() because upstream seems to be using unannotated tags.

Patch: http://ix.io/2KvT

1 2 3 Next › Last »