Package Details: threema-desktop 1.2.46-2

Git Clone URL: https://aur.archlinux.org/threema-desktop.git (read-only, click to copy)
Package Base: threema-desktop
Description: Threema Desktop (Threema Web in Electron).
Upstream URL: https://github.com/threema-ch/threema-web-electron
Licenses: AGPL
Submitter: dbrgn
Maintainer: dbrgn
Last Packager: dbrgn
Votes: 17
Popularity: 0.022599
First Submitted: 2021-10-27 10:38 (UTC)
Last Updated: 2024-11-22 00:17 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 Next › Last »

solnce commented on 2022-09-23 11:48 (UTC)

@dbrgn @Jino I think I found the cause of the error, but I don't understand it one bit.

TL;DR: The bug only appears when I set BUILDDIR=/tmp/makepkg in my makepkg.conf, in order to build it in my ramdisk. If I leave that unset (with the original config), it works. Are you able to confirm that?

solnce commented on 2022-09-16 11:38 (UTC)

@dbrgn Yes, unfortunately it does. Here's the relevant output for me.

May I suggest trying to reproduce this in a chroot-build?

==> Making package: threema-desktop 1.2.21-1 (Fri 16 Sep 2022 01:36:27 PM CEST)
==> Retrieving sources...
  -> Downloading threema-web-electron-v1.2.21.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2699k  100 2699k    0     0  5402k      0 --:--:-- --:--:-- --:--:-- 5402k
  -> Downloading threema-web-v2.4.4.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 21.5M    0 21.5M    0     0  14.8M      0 --:--:--  0:00:01 --:--:-- 21.0M
  -> Found threema.desktop
  -> Found 0001-Remove-browser-warning.patch
==> Validating source files with sha256sums...
    threema-web-electron-v1.2.21.tar.gz ... Passed
    threema-web-v2.4.4.tar.gz ... Passed
    threema.desktop ... Passed
    0001-Remove-browser-warning.patch ... Passed
==> Making package: threema-desktop 1.2.21-1 (Fri 16 Sep 2022 01:36:29 PM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found threema-web-electron-v1.2.21.tar.gz
  -> Found threema-web-v2.4.4.tar.gz
  -> Found threema.desktop
  -> Found 0001-Remove-browser-warning.patch
==> Validating source files with sha256sums...
    threema-web-electron-v1.2.21.tar.gz ... Passed
    threema-web-v2.4.4.tar.gz ... Passed
    threema.desktop ... Passed
    0001-Remove-browser-warning.patch ... Passed
==> Removing existing $srcdir/ directory...
==> Extracting sources...
  -> Extracting threema-web-electron-v1.2.21.tar.gz with bsdtar
  -> Extracting threema-web-v2.4.4.tar.gz with bsdtar
==> Starting prepare()...
patching file src/partials/welcome.ts
==> Sources are ready.
threema-desktop-1.2.21-1: parsing pkg list...
==> Making package: threema-desktop 1.2.21-1 (Fri 16 Sep 2022 01:36:34 PM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Removing existing $pkgdir/ directory...
==> Starting build()...
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

added 606 packages, and audited 607 packages in 10s

74 packages are looking for funding
  run `npm fund` for details

3 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
Patching new user agent detection
../../../tools/patches/patch-user-agent.patch:45: trailing whitespace.
            browser.macosDesktop = /darwinthreemadesktop/.test(uagent)
../../../tools/patches/patch-user-agent.patch:46: trailing whitespace.
            browser.win32Desktop = /win32threemadesktop/.test(uagent)
../../../tools/patches/patch-user-agent.patch:47: trailing whitespace.
            browser.linuxDesktop = /linuxthreemadesktop/.test(uagent)
error: patch failed: src/partials/welcome.ts:174
error: src/partials/welcome.ts: patch does not apply
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'threema-desktop-1.2.21-1':
error: packages failed to build: threema-desktop-1.2.21-1

dbrgn commented on 2022-09-15 07:21 (UTC)

@solnce @Jino does the issue persist with the latest update?

solnce commented on 2022-08-25 12:10 (UTC)

@dbrgn Could you maybe try to reproduce the issue in a chroot-build? I was able to reproduce the issue there.

Jino commented on 2022-08-19 09:06 (UTC) (edited on 2022-08-19 09:06 (UTC) by Jino)

I experience the same issue as solnce:

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

npm-version: 8.18.0

solnce commented on 2022-08-05 11:14 (UTC)

this is how src/partials/welcome.ts looks like. The first line is 167. I don't even have a line in the file that says this.showBrowserWarning().

        // Clear cache
        this.webClientService.clearCache();

        // Determine whether trusted key is available
        let hasTrustedKey = null;
        try {
            hasTrustedKey = this.trustedKeyStore.hasTrustedKey();
        } catch (e) {

solnce commented on 2022-08-05 11:01 (UTC)

Can you check that src/threema-web-electron-1.2.18/tools/patches/patch-user-agent.patch looks like a normal patch file?

Yes it does. md5sum is 7ea14086c3e2954c6afe0de89e77fd26

solnce commented on 2022-08-05 10:59 (UTC)

Same version of git here. I also tried a clean chroot-build in the meantime, same error.

dbrgn commented on 2022-08-05 10:58 (UTC) (edited on 2022-08-05 10:59 (UTC) by dbrgn)

@solnce: Node is probably not the issue. Main problem is that applying some patches by the build script seems to fail:

Patching new user agent detection
../../../tools/patches/patch-user-agent.patch:45: trailing whitespace.
            browser.macosDesktop = /darwinthreemadesktop/.test(uagent)
../../../tools/patches/patch-user-agent.patch:46: trailing whitespace.
            browser.win32Desktop = /win32threemadesktop/.test(uagent)
../../../tools/patches/patch-user-agent.patch:47: trailing whitespace.
            browser.linuxDesktop = /linuxthreemadesktop/.test(uagent)
error: patch failed: src/partials/welcome.ts:170
error: src/partials/welcome.ts: patch does not apply
error: patch failed: src/services/browser.ts:124
error: src/services/browser.ts: patch does not apply

I neither get the whitespace warnings nor the patch failures. The patches are applied with "git apply" (see src/threema-web-electron-1.2.18/tools/patches/patch-threema-web.sh).

Can you check that src/threema-web-electron-1.2.18/tools/patches/patch-user-agent.patch looks like a normal patch file?

What version of git is installed? I'm on 2.37.1.

solnce commented on 2022-08-05 10:49 (UTC) (edited on 2022-08-05 10:49 (UTC) by solnce)

@dbrgn Thanks for your message. I did as you suggested, but no luck..(rm -rf threema-desktop, git clone ..., cd threema-desktop, makepkg -si). That is the third machine where I have this error.

Which versions of the dependencies do you have installed? For me it's electron18-18.3.6-1 and npm-8.16.0-1.

==> Making package: threema-desktop 1.2.18-2 (Fri 05 Aug 2022 12:43:55 PM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Package (4)            New Version  Net Change

community/node-gyp     9.1.0-1        4.41 MiB
community/nodejs-nopt  5.0.0-2        0.03 MiB
community/semver       7.3.7-1        0.11 MiB
community/npm          8.16.0-1       6.48 MiB

Total Installed Size:  11.03 MiB

:: Proceed with installation? [Y/n]
(4/4) checking keys in keyring                               [################################] 100%
(4/4) checking package integrity                             [################################] 100%
(4/4) loading package files                                  [################################] 100%
(4/4) checking for file conflicts                            [################################] 100%
(4/4) checking available disk space                          [################################] 100%
:: Processing package changes...
(1/4) installing nodejs-nopt                                 [################################] 100%
(2/4) installing semver                                      [################################] 100%
(3/4) installing node-gyp                                    [################################] 100%
(4/4) installing npm                                         [################################] 100%
:: Running post-transaction hooks...
(1/2) Arming ConditionNeedsUpdate...
(2/2) Removing old cached packages ...
==> no candidate packages found for pruning
==> no candidate packages found for pruning
==> no candidate packages found for pruning
==> no candidate packages found for pruning
==> Retrieving sources...
  -> Downloading threema-web-electron-v1.2.18.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2692k    0 2692k    0     0  3767k      0 --:--:-- --:--:-- --:--:-- 3767k
  -> Downloading threema-web-v2.4.2.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 21.5M    0 21.5M    0     0  14.0M      0 --:--:--  0:00:01 --:--:-- 16.9M
  -> Found threema.desktop
  -> Found 0001-When-browser-detection-fails-don-t-return-undefined.patch
  -> Found 0002-Remove-browser-warning.patch
==> Validating source files with sha256sums...
    threema-web-electron-v1.2.18.tar.gz ... Passed
    threema-web-v2.4.2.tar.gz ... Passed
    threema.desktop ... Passed
    0001-When-browser-detection-fails-don-t-return-undefined.patch ... Passed
    0002-Remove-browser-warning.patch ... Passed
==> Extracting sources...
  -> Extracting threema-web-electron-v1.2.18.tar.gz with bsdtar
  -> Extracting threema-web-v2.4.2.tar.gz with bsdtar
==> Starting prepare()...
patching file src/services/browser.ts
patching file src/partials/welcome.ts
==> Removing existing $pkgdir/ directory...
==> Starting build()...

up to date in 4m

63 packages are looking for funding
  run `npm fund` for details
Patching new user agent detection
../../../tools/patches/patch-user-agent.patch:45: trailing whitespace.
            browser.macosDesktop = /darwinthreemadesktop/.test(uagent)
../../../tools/patches/patch-user-agent.patch:46: trailing whitespace.
            browser.win32Desktop = /win32threemadesktop/.test(uagent)
../../../tools/patches/patch-user-agent.patch:47: trailing whitespace.
            browser.linuxDesktop = /linuxthreemadesktop/.test(uagent)
error: patch failed: src/partials/welcome.ts:170
error: src/partials/welcome.ts: patch does not apply
error: patch failed: src/services/browser.ts:124
error: src/services/browser.ts: patch does not apply
==> ERROR: A failure occurred in build().
    Aborting...

« First ‹ Previous 1 2 3 4 5 6 Next › Last »