Arch Linux User Repository

The PKGBUILD is missing one dependency and could not be installed. I fixed it by adding "go get golang.org/x/crypto/blake2b" inside the build() function at line 31.

go should be in makedepends, and not in depends. go programs are compiled, not interpreted. The system it is being run on doesn't need to have go installed.

Everyone has bash, and also namcap is not 100% right all the time. TMSU is written in Go, so it's a dependency. Fuse is required too, and you can see in the PKGBUILD that Go bindings for it are being downloaded. Same goes with sqlite. Thanks for trying to help tho.

FYI, noticed these warnings at the end of building in a clean chroot.

Checking PKGBUILD Checking tmsu-0.7.0-1-x86_64.pkg.tar.xz tmsu E: Dependency bash detected and not included (programs ['sh', 'bash'] needed in scripts ['usr/bin/tmsu-fs-mv', 'usr/bin/tmsu-fs-merge', 'usr/bin/mount.tmsu', 'usr/bin/tmsu-fs-rm']) tmsu W: Dependency included and not needed ('go') tmsu W: Dependency included and not needed ('fuse') tmsu W: Dependency included and not needed ('sqlite')

Modifying the PATH variable is not the correct solution here. The issue is a poorly written Makefile. Neither of the tests have dependencies on the final compiled output, so running with jobs > 1 causes the tests to run in parallel with the compilation. Additionally tests shouldn't be in the build command in the first place. That's what check is for. The user should have the option to skip failing tests if the outputs are generated properly. So with all that being said I think the correct solution is to modify the PKGBUILD like ``` 28c28,33 < make --- > make dist > } > > check() { > cd "$srcdir/TMSU-$pkgver" > make test ```

Yep. CheezenOne is right. Just run make with the modified PATH env variable. Can the maintainer edit the PKGBUILD please?

I could get the PKGBUILG compile the package after changing the make command to: ``` cd "$srcdir/TMSU-$pkgver" PATH="$PATH:$(pwd)/bin" make -j1 ``` My build was failing because the path to the `tmsu` executable was not known when the tests were executed.

Well, to investigate this further I just: 1. Uninstalled TMSU 2. Downloaded the PKGBUILD from here 3. Commented out the Go dependency from the PKGBUILD (as I have a version installed outside of Pacman) 4. Ran `makepkg` on the PKGBUILD. This worked fine: the tests all ran successfully. I then ran `sudo pacman -U tmsu-0.6.1-1-i686.pkg.tar.gz` and installed it without any problem. So I don't think there is, after all, any problem with either the PKGBUILD or the TMSU binary. My earlier fears about the `run` script are unfounded: the build directory is not affected (it still builds to `bin` beneath the directory `makepkg` creates, so the relative path to the just-built TMSU is good). So not sure why this is not working for some people.

@vok5, sure, I could look to introduce a `BUILD_DIR` variable. I would need to think about how the `run` script will be able to pick this up, especially as it's possible to run this script directly (without `make`).

@oniony, thank you for having a look. I believe the `run` script shouldn't assume the build directory to be `bin`. It would fix the issue with this package and also make tmsu's tests more robusts. Perhaps, using an environment variable like BUILD_DIR, which could be overwritten would be a solution. As for the PKGBUILD file, the build directory is changed by `makepkg` (https://wiki.archlinux.org/index.php/Creating_packages#build.28.29). Then, right before executing `make`, `cd "$srcdir/TMSU-$pkgver"` is executed to get inside the build directory of this package.