Arch Linux User Repository

@Faerbit thanks for maintaining the package. Here's a patch to fix the compilation issues.

diff --git a/PKGBUILD b/PKGBUILD
index 4952e21..ea5556a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -8,13 +8,19 @@ arch=('x86_64')
 url="https://github.com/Cropi/usbguard-notifier"
 license=('GPL2')
 depends=('usbguard' 'libnotify' 'librsvg')
-makedepends=('catch2' 'asciidoc')
-source=("https://github.com/Cropi/usbguard-notifier/releases/download/$pkgname-$pkgver/$pkgname-$pkgver.tar.gz"{,.asc})
-md5sums=('SKIP'
-         'SKIP')
+makedepends=('catch2-v2' 'asciidoc')
+source=("https://github.com/Cropi/usbguard-notifier/releases/download/$pkgname-$pkgver/$pkgname-$pkgver.tar.gz"{,.asc}
+        01-fix-compile-with-gcc-13.patch::https://github.com/Cropi/usbguard-notifier/pull/74.patch)
+sha256sums=('c317c3a31ef90e45ae3b3df855384e87f35a56546cebf8d85d39308e1d7a8d72'
+            'SKIP'
+            '0cc2b9351f0d3981a9ebd207bf3726975f30018af0f2654a0ae33f77473a1397')

 validpgpkeys=('42363D1C30A574A4EE5D9C87E650CBBFEF3AAC4B') # alakatos at redhat dot com

+prepare() {
+        patch --directory="$srcdir/$pkgname-$pkgver" --forward --strip=1 --input="$srcdir/01-fix-compile-with-gcc-13.patch"
+}
+
 build() {
         cd "$srcdir/$pkgname-$pkgver"
         ./configure CPPFLAGS=-I/usr/include/catch2 --prefix=/usr

PS: I'll be happy to take over as a maintainer if you like.

There is no catch.hpp anymore, the issue has been open for a year upstream - https://github.com/Cropi/usbguard-notifier/issues/75

Seems fixed in HEAD, would you roll a usbguard-notifier-git package?

checking for notify... yes
checking for a2x... a2x
checking for catch.hpp... no
configure: error: in `/tmp/makepkg/usbguard-notifier/src/usbguard-notifier-0.1.0':
configure: error: catch.hpp not found or not
        usable. Re-run with --with-bundled-catch to use the bundled library.
See `config.log' for more details

Hi Daklon,

I you have been able to compile it from source, just use usbguard-notifier-git and be done with it. Backporting fixes from upstream, because upstream doesn't feel like releasing a version even though their software can't be compiled is not something I will spend my time on. If you are interested in doing that, I will gladly give control over this package to you.

Hi Faerbit,

The current issue is fixed at upstream, it was fixed on January actually [1], but no new tag has been generated with the fix yet.

As LeoMeinel, I've been able to compile it from source.

I requested on the github issue to have a new tag released with the fix but I'm not sure when this will happen. So i've generated a sigthy modified pkg build with a patch that applies the same fix.

Could you review it and consider adding it to the package until a new tag is released upstream? patch:https://binshare.net/N9s7ptbj6KC67BBEGJdt PKGBUILD: https://binshare.net/TqmQtJE6TzWFTrVBsBdQ

[1] https://github.com/Cropi/usbguard-notifier/commit/f4586b732c8a7379aacbc9899173beeacfd54793

Hi Faerbit,

Thank you very much for your answer! I wasn't sure if the PKGBUILD might have anything to do with this at first but after managing to build the -git version of the package I thought that it couldn't be an upstream issue. Not sure how the signatures get processed etc. but thank you very much for clarifying! I will report this upstream (probably tomorrow) :)

Kind regards, Leo

Hi LeoMeinel,

thanks for taking the time to put together a detailed error report. I can reproduce your problems. However you are talking to the wrong person. I have only written the PKGBUILD (which you can see when you click the first link in the top right box). Your issues are caused by upstream (the original authors of the software). You can find the upstream, by clicking the Upstream URL. So I would kindly ask to take it up with them.

Regards,

Faerbit

First of all, thanks for packaging this!

Yesterday I noticed that your package doesn't manage to build anymore. I'm pretty sure it's because of the cxx build errors below, but the signature seems to be expired aswell.

I have attached a log of makepkg(makepkg.log), makepkg --skippgpcheck(makepkg_--skippgpcheck) and paru(post.log) to this GitHub issue.

None of those work for building the package on a "new" system in a vm.

0.1.0 available : https://github.com/Cropi/usbguard-notifier/tags