Arch Linux User Repository

I'd also motion to use standard libplacebo instead of libplacebo-git. Currently this package is unusable, because all of the source filter packages (lsmash, bestsource, ffms2) require the standard version of libplacebo (indirectly through ffmpeg), they do not work with libplacebo-git/ffmpeg-git.

Can you please change the make dependency libplacebo-git to libplacebo, so the user can devide if he/whe wants to have the official repository release variant or the AUR git variant?

It builds fine now with the official libplacebo.

If you need a versioned dependency, add >=2.61 to the dependency entry, and bug the maintainer of libplacebo-git to add a version into it's provides entries.

Thanks for maintaining!

There's an optional dependency to libdovi which now has an AUR package: https://aur.archlinux.org/packages/libdovi-git

for submodules:

  cd "${_plug}"
  git config submodule.libp2p.url "${srcdir}/libp2p"
  git submodule update --init libp2p

as note. the repo seems archived and not get updates anymore(?)

Yeah build fails.

../resample.c:51:35: error: incompatible type for argument 2 of ‘pl_shader_linearize’

Build failed with following output:

==> Retrieving sources...
==> WARNING: Skipping all source file integrity checks.
==> Extracting sources...
  -> Creating working copy of placebo git repo...
Cloning into 'placebo'...
done.
  -> Creating working copy of libp2p git repo...
Cloning into 'libp2p'...
done.
==> Starting prepare()...
+ exec meson setup --prefix /usr --libexecdir lib --sbindir bin --buildtype plain --auto-features enabled --wrap-mode nodownload -D b_lto=true -D b_pie=true builddir
The Meson build system
Version: 0.59.1
Source dir: /build/vapoursynth-plugin-placebo-git/src/placebo
Build dir: /build/vapoursynth-plugin-placebo-git/src/placebo/builddir
Build type: native build
Project name: vs-placebo
Project version: 1.2
C compiler for the host machine: cc (gcc 11.1.0 "cc (GCC) 11.1.0")
C linker for the host machine: cc ld.bfd 2.36.1
C++ compiler for the host machine: c++ (gcc 11.1.0 "c++ (GCC) 11.1.0")
C++ linker for the host machine: c++ ld.bfd 2.36.1
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (1.7.3)
Run-time dependency libplacebo found: YES 4.157.0
Run-time dependency vapoursynth found: YES 54
Build targets in project: 2

Option buildtype is: plain [default: release]
Found ninja-1.10.2 at /usr/bin/ninja
==> Starting pkgver()...
==> Updated version: vapoursynth-plugin-placebo-git r59.cf02e29-1
==> Starting build()...
ninja: Entering directory `builddir'
[1/9] Compiling C++ object libp2p.a.p/libp2p_v210.cpp.o
[2/9] Compiling C object libvs_placebo.so.p/resample.c.o
FAILED: libvs_placebo.so.p/resample.c.o 
cc -Ilibvs_placebo.so.p -I. -I.. -I/usr/include/vapoursynth -flto=auto -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c99 -fPIC -MD -MQ libvs_placebo.so.p/resample.c.o -MF libvs_placebo.so.p/resample.c.o.d -o libvs_placebo.so.p/resample.c.o -c ../resample.c
../resample.c: In function ‘do_plane_R’:
../resample.c:51:35: error: incompatible type for argument 2 of ‘pl_shader_linearize’
   51 |         pl_shader_linearize(ish, d->trc);
      |                                  ~^~~~~
      |                                   |
      |                                   enum pl_color_transfer
In file included from /usr/include/libplacebo/renderer.h:26,
                 from /usr/include/libplacebo/utils/upload.h:24,
                 from ../vs-placebo.h:6,
                 from ../resample.c:1:
/usr/include/libplacebo/shaders/colorspace.h:49:62: note: expected ‘struct pl_color_space’ but argument is of type ‘enum pl_color_transfer’
   49 | void pl_shader_linearize(pl_shader sh, struct pl_color_space csp);
      |                                        ~~~~~~~~~~~~~~~~~~~~~~^~~
../resample.c:106:36: error: incompatible type for argument 2 of ‘pl_shader_delinearize’
  106 |         pl_shader_delinearize(sh, d->trc);
      |                                   ~^~~~~
      |                                    |
      |                                    enum pl_color_transfer
In file included from /usr/include/libplacebo/renderer.h:26,
                 from /usr/include/libplacebo/utils/upload.h:24,
                 from ../vs-placebo.h:6,
                 from ../resample.c:1:
/usr/include/libplacebo/shaders/colorspace.h:54:64: note: expected ‘struct pl_color_space’ but argument is of type ‘enum pl_color_transfer’
   54 | void pl_shader_delinearize(pl_shader sh, struct pl_color_space csp);
      |                                          ~~~~~~~~~~~~~~~~~~~~~~^~~
../resample.c: In function ‘filter_R’:
../resample.c:180:20: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  180 |             .ptr = src->pixels,
      |                    ^~~
../resample.c: In function ‘ResampleGetFrame’:
../resample.c:233:51: warning: passing argument 1 of ‘vsapi->getWritePtr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  233 |                     .pixels =  vsapi->getWritePtr(frame, i),
      |                                                   ^~~~~
../resample.c:233:51: note: expected ‘VSFrameRef *’ but argument is of type ‘const VSFrameRef *’
../resample.c: In function ‘ResampleFree’:
../resample.c:262:33: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  262 |     free(d->sampleParams->filter.kernel);
      |          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
In file included from /usr/include/libplacebo/shaders/custom.h:21,
                 from /usr/include/libplacebo/renderer.h:29,
                 from /usr/include/libplacebo/utils/upload.h:24,
                 from ../vs-placebo.h:6,
                 from ../resample.c:1:
/usr/include/stdlib.h:565:25: note: expected ‘void *’ but argument is of type ‘const struct pl_filter_function *’
  565 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
../resample.c: In function ‘ResampleCreate’:
../resample.c:328:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  328 |     char * filter = vsapi->propGetData(in, "filter", 0, &err);
      |                     ^~~~~
[3/9] Compiling C object libvs_placebo.so.p/vs-placebo.c.o
../vs-placebo.c: In function ‘init’:
../vs-placebo.c:26:5: warning: ‘pl_context_create’ is deprecated [-Wdeprecated-declarations]
   26 |     p->ctx = pl_context_create(PL_API_VER, &(struct pl_context_params) {
      |     ^
In file included from /usr/include/libplacebo/common.h:32,
                 from /usr/include/libplacebo/gpu.h:25,
                 from /usr/include/libplacebo/shaders.h:27,
                 from /usr/include/libplacebo/dispatch.h:21,
                 from ../vs-placebo.c:11:
/usr/include/libplacebo/log.h:109:1: note: declared here
  109 | pl_context_create(int api_ver, const struct pl_context_params *params)
      | ^~~~~~~~~~~~~~~~~
../vs-placebo.c: In function ‘uninit’:
../vs-placebo.c:80:5: warning: ‘pl_context_destroy’ is deprecated [-Wdeprecated-declarations]
   80 |     pl_context_destroy(&p->ctx);
      |     ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/libplacebo/common.h:32,
                 from /usr/include/libplacebo/gpu.h:25,
                 from /usr/include/libplacebo/shaders.h:27,
                 from /usr/include/libplacebo/dispatch.h:21,
                 from ../vs-placebo.c:11:
/usr/include/libplacebo/log.h:114:34: note: declared here
  114 | static inline PL_DEPRECATED void pl_context_destroy(PL_STRUCT(pl_context) **pctx)
      |                                  ^~~~~~~~~~~~~~~~~~
[4/9] Compiling C object libvs_placebo.so.p/tonemap.c.o
../tonemap.c: In function ‘config_TM’:
../tonemap.c:63:26: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   63 |     struct pl_fmt *out = pl_plane_find_fmt(p->gpu, NULL,
      |                          ^~~~~~~~~~~~~~~~~
../tonemap.c: In function ‘filter_TM’:
../tonemap.c:95:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   95 |                 .ptr = src[i].pixels,
      |                        ^~~
../tonemap.c: In function ‘TMGetFrame’:
../tonemap.c:152:51: warning: passing argument 1 of ‘vsapi->getWritePtr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  152 |                     .pixels =  vsapi->getWritePtr(frame, j),
      |                                                   ^~~~~
../tonemap.c:152:51: note: expected ‘VSFrameRef *’ but argument is of type ‘const VSFrameRef *’
../tonemap.c: In function ‘TMFree’:
../tonemap.c:192:25: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  192 |     free(d->renderParams->peak_detect_params);
      |          ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/libplacebo/shaders/custom.h:21,
                 from /usr/include/libplacebo/renderer.h:29,
                 from /usr/include/libplacebo/utils/upload.h:24,
                 from ../vs-placebo.h:6,
                 from ../tonemap.c:1:
/usr/include/stdlib.h:565:25: note: expected ‘void *’ but argument is of type ‘const struct pl_peak_detect_params *’
  565 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
../tonemap.c:193:25: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  193 |     free(d->renderParams->color_map_params);
      |          ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
In file included from /usr/include/libplacebo/shaders/custom.h:21,
                 from /usr/include/libplacebo/renderer.h:29,
                 from /usr/include/libplacebo/utils/upload.h:24,
                 from ../vs-placebo.h:6,
                 from ../tonemap.c:1:
/usr/include/stdlib.h:565:25: note: expected ‘void *’ but argument is of type ‘const struct pl_color_map_params *’
  565 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
[5/9] Compiling C object libvs_placebo.so.p/shader.c.o
../shader.c: In function ‘config_S’:
../shader.c:89:26: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   89 |     struct pl_fmt *out = pl_plane_find_fmt(p->gpu, NULL,
      |                          ^~~~~~~~~~~~~~~~~
../shader.c: In function ‘SGetFrame’:
../shader.c:171:28: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  171 |             VSMap *props = vsapi->getFramePropsRO(frame);
      |                            ^~~~~
../shader.c:180:28: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  180 |         VSFormat *dstfmt = d->vi->format;
      |                            ^
../shader.c:181:16: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  181 |         dstfmt = vsapi->registerFormat(dstfmt->colorFamily, dstfmt->sampleType, dstfmt->bitsPerSample, 0, 0, core);
      |                ^
../shader.c:192:51: warning: passing argument 1 of ‘vsapi->getWritePtr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  192 |                     .pixels =  vsapi->getWritePtr(frame, j),
      |                                                   ^~~~~
../shader.c:192:51: note: expected ‘VSFrameRef *’ but argument is of type ‘const VSFrameRef *’
../shader.c: In function ‘SFree’:
../shader.c:231:33: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  231 |     free(d->sampleParams->filter.kernel);
      |          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
In file included from /usr/include/libplacebo/shaders/custom.h:21,
                 from /usr/include/libplacebo/renderer.h:29,
                 from /usr/include/libplacebo/utils/upload.h:24,
                 from ../vs-placebo.h:6,
                 from ../shader.c:2:
/usr/include/stdlib.h:565:25: note: expected ‘void *’ but argument is of type ‘const struct pl_filter_function *’
  565 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
../shader.c: In function ‘SCreate’:
../shader.c:249:16: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  249 |     char* sh = vsapi->propGetData(in, "shader", 0, &err);
      |                ^~~~~
../shader.c:268:26: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  268 |         char* shader_s = vsapi->propGetData(in, "shader_s", 0, &err);
      |                          ^~~~~
../shader.c:336:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  336 |     char * filter = vsapi->propGetData(in, "filter", 0, &err);
      |                     ^~~~~
[6/9] Compiling C object libvs_placebo.so.p/deband.c.o
../deband.c: In function ‘filter’:
../deband.c:108:20: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  108 |             .ptr = src->pixels,
      |                    ^~~
../deband.c: In function ‘DebandGetFrame’:
../deband.c:162:100: warning: passing argument 1 of ‘vsapi->getWritePtr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  162 |                 vs_bitblt(vsapi->getWritePtr(dst, i), vsapi->getStride(dst, i), vsapi->getWritePtr(frame, i),
      |                                                                                                    ^~~~~
../deband.c:162:100: note: expected ‘VSFrameRef *’ but argument is of type ‘const VSFrameRef *’
../deband.c:172:55: warning: passing argument 1 of ‘vsapi->getWritePtr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  172 |                         .pixels =  vsapi->getWritePtr(frame, i),
      |                                                       ^~~~~
../deband.c:172:55: note: expected ‘VSFrameRef *’ but argument is of type ‘const VSFrameRef *’
[7/9] Compiling C++ object libp2p.a.p/libp2p_p2p_api.cpp.o
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
    Aborting...
==> ERROR: Build failed, check /home/.archbuild/extra-x86_64/yuki/build

Currently will fail if built with extra/libplacebo as this is out of date. Replace extra/libplacebo with aur/libplacebo-git until the libplacebo package is updated to >= 2.61.