@bionade24 The reason behind my error a few months back is a flawed pkgver()
function, as it returns the pkgver
variable + the git information (r287.b0632c4
)... that is already in that variable - essentially duplicating it. I've noticed that after installing the package (through yay or manually) the PKGBUILD gets updated. Here is the diff:
diff --git a/PKGBUILD b/PKGBUILD
index 3a0eaf4..3f3f06b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,5 +1,5 @@
pkgname=vesc_tool-git
-pkgver=3.00.r287.b0632c4.r287.b0632c4.r287.b0632c4
+pkgver=3.00.r287.b0632c4.r287.b0632c4.r287.b0632c4.r287.b0632c4
pkgrel=1
pkgdesc="VESC ESC graphical configuration tool"
arch=('i686' 'x86_64' 'aarch64' 'armv7h' 'armv6h')
So, if you don't reload the pkgbuild during installation, this issue will not arise (which I guess Yay does for some reason). Also using the --editmenu
to edit the PKGBUILD /w Yay and removing the "${pkgver}" from pkgver()
solves the issue.
I can see that this is not an issue only affecting me, as, in the latest commit, you've changed the pkgver
to 3.00.r287.b0632c4.r287.b0632c4.r287.b0632c4-1
. I find that kind of hilarious as it also changed the name of the package on AUR.
Also, dunno if this is helpful, but the commit that introduced this issue was: 163d11d0e029.
The offending line is: printf "${pkgver}.r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
My recommendation is, if you want to also keep the program version included in the name & the pkgbuild, use a separate variable for it (like gitver=3.00
).
Though it is unfortunate that the github maintainers still don't tag the versions on GitHub.
I hope my formatting is done right, otherwise I might edit this comment a few times.
Pinned Comments
bionade24 commented on 2024-04-07 09:57 (UTC)
I switched to the mold linker on purpose to reduce the enormous link times (with LTO) of this project and get better error messages when the linking fails due to the patched buildscript. If you don't like that, use
qmake -unset <flags>
to remove it.