Arch Linux User Repository

How to fix?

Hi, Confirming the checksum error on 0001-Fix-redefinition-compile-error.patch this morning.

0001-Fix-redefinition-compile-error.patch has a wrong checksum.

Hi,

Please add 'aarch64' in the supported architectures in PKGBUILD, as it compiles and runs fine there.

Thanks in advance.

@reibax comment works for me. Just modify the src 'onmainwindow_privat.h ' and simply make install will work. Many thanks.

Indeed, I can testify that @reibax command works really well

I'm new to the ArchLinux world, so I apologize for not knowing how to share useful information about the environment on which I'm getting this compile error, being that Arch Linux is a rolling release.

The point is that I'm getting this error when trying to install this package:

In file included from /usr/include/linux/fs.h:19,
                 from ../src/onmainwindow_privat.h:91:
/usr/include/linux/mount.h:95:6: error: multiple definition of ‘enum fsconfig_command’
   95 | enum fsconfig_command {
      |      ^~~~~~~~~~~~~~~~
In file included from ../src/onmainwindow_privat.h:87:
/usr/include/sys/mount.h:189:6: note: previous definition here
  189 | enum fsconfig_command
      |      ^~~~~~~~~~~~~~~~
/usr/include/linux/mount.h:129:8: error: redefinition of ‘struct mount_attr’
  129 | struct mount_attr {
      |        ^~~~~~~~~~

I was able to fix it by applying this patch:

From 80df504b43591a8a5028c1d49346419887eb9d10 Mon Sep 17 00:00:00 2001
From: Reibax <reibax@gmail.com>
Date: Tue, 16 Aug 2022 00:35:05 +0200
Subject: [PATCH] Use linux mount.h instead of sys mount.h

This patch fixes compilation on ArchLinux.

Using sys/mount.h instead of linux/mount.h resulted in compilation
errors due to redefinition of fsconfig_command and mount_attr.
---
 0001-Fix-redefinition-compile-error.patch | 25 +++++++++++++++++++++++
 PKGBUILD                                  |  9 ++++++--
 2 files changed, 32 insertions(+), 2 deletions(-)
 create mode 100644 0001-Fix-redefinition-compile-error.patch

diff --git a/0001-Fix-redefinition-compile-error.patch b/0001-Fix-redefinition-compile-error.patch
new file mode 100644
index 0000000..24b57b6
--- /dev/null
+++ b/0001-Fix-redefinition-compile-error.patch
@@ -0,0 +1,25 @@
+From b6d591bf246f65aba75a822364215b8bcb08fafe Mon Sep 17 00:00:00 2001
+From: Reibax <reibax@gmail.com>
+Date: Tue, 16 Aug 2022 00:13:36 +0200
+Subject: [PATCH] Fix redefinition compile error
+
+---
+ src/onmainwindow_privat.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/onmainwindow_privat.h b/src/onmainwindow_privat.h
+index d37f4c9..f4002bd 100644
+--- a/src/onmainwindow_privat.h
++++ b/src/onmainwindow_privat.h
+@@ -84,7 +84,7 @@
+ #include "contest.h"
+ 
+ #if !defined Q_OS_WIN
+-#include <sys/mount.h>
++#include <linux/mount.h>
+ #ifdef Q_OS_LINUX
+ #include <X11/Xatom.h>
+ #include <X11/xpm.h>
+-- 
+2.37.2
+
diff --git a/PKGBUILD b/PKGBUILD
index 5cf0fac..81ced97 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -15,13 +15,17 @@ depends=('qt5-x11extras' 'qt5-svg'
 # FS#48088
 optdepends=('xorg-xauth: may be required by X2goservers running a different linux distribution giving MIT-COOKIE errors')
 source=(https://code.x2go.org/releases/source/${pkgname}/${pkgname}-${pkgver}.tar.gz{,.asc}
-        reproducible-man-gzip.patch)
+        reproducible-man-gzip.patch 0001-Fix-redefinition-compile-error.patch)
 sha256sums=('c9953267c40fa67119ad96a73bacb1f266196da2059f0cdcd1b8d5199421d12a'
             'SKIP'
-            '8b309f0cc99d89737f47e57b79afdc9cccdd36ca3d0772040b1c3fdc0399a4d2')
+            '8b309f0cc99d89737f47e57b79afdc9cccdd36ca3d0772040b1c3fdc0399a4d2'
+            'afdb3a67d3ab875dbd924112350cc662f354e6dd6a6159c8349cad369f86f30d')
 validpgpkeys=('9BFBAEE86C0AA5FFBF2207829AF46B3025771B31'  # Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
               '1AD23D1B8F087A35AB74BDE9F4A7678C9C6B0B2B') #  "X2go Git Administrator <git-admin@x2go.org>"

+export CFLAGS+=' -fcommon'
+export CXXFLAGS+=' -fcommon'
+
 prepare() {
   cd ${pkgname}-${pkgver}
   sed -i "s:-o root -g root ::" Makefile
@@ -29,6 +33,7 @@ prepare() {

   # remove timestamp to solve reproducible build
   patch -Np1 -i ../reproducible-man-gzip.patch
+  patch -Np1 -i ../0001-Fix-redefinition-compile-error.patch
 }

 build() {
-- 
2.37.2

Before that compile error I was getting a gpg error that I was able to fix by using this command:

gpg --recv-keys F4A7678C9C6B0B2B

Build fails with no obvious error message:

make[2]: Leaving directory '/var/tmp/pamac-build-jking/x2goclient/src/x2goclient-4.1.2.2/client_build'
make[1]: *** [Makefile:72: build_client] Error 2
make[1]: Leaving directory '/var/tmp/pamac-build-jking/x2goclient/src/x2goclient-4.1.2.2'
make: *** [Makefile:67: build] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

How would I go about diagnosing this?