Arch Linux User Repository

@simona I see, thanks. For now you can try to run tests with a previous Python version or just skip them. I shall try to improve the tests meanwhile!

E AssertionError: assert [call('.ys/co...all().close()] == [call('.ys/co...t', 'x'), ...]
E
E At index 5 diff: call().close() != call('.ys/repo_myhost.txt', 'x')
E Left contains 2 more items, first extra item: call().exit(None, None, None)
E Use -v to get more diff

/home/simona/.cache/yay/yarsync/src/yarsync-0.2.1/tests/test_init.py:87: AssertionError

@simona could you please add the error trace?

no more builds

Todo for the next release: drop setuptools (see the wiki).

Done, thanks. Are you sure python-setuptools is really needed?

On https://wiki.archlinux.org/title/Python_package_guidelines#Standards_based_(PEP_517) it is written that this package is only needed "If no pyproject.toml can be found or it fails to contain a [build-system] table".

Please add

rsync python-setuptools python-pytest python-pytest-mock

to makedepends. It doesn't build without these.

Made a patch release. Many thanks to @m040601 for the suggestions!

1) man-db is no longer a dependency in PKGBUILD. I still launch mandb command after installation, but if it is not found, it is no longer an error (if you know a better way, please share).

2) documentation added. Thanks again for the suggestion; it was missing in PKGBUILD on Arch Wiki (I added a topic to its talk page), but I've found it at https://wiki.archlinux.org/title/Arch_package_guidelines#Directories

3) I don't add licence, because it is common and installed on the system.

"The licenses package (a dependency of the base meta package) contains many commonly used licenses, which are installed under /usr/share/licenses/common/.

If a package is licensed under one of these licenses, the value should be set to the directory name, e.g. license=('GPL')." - this is what I do.

https://wiki.archlinux.org/title/PKGBUILD#license

4) If you've read the docs and evaluated my points, that would be interesting to hear! Thanks for the feedback.

Thank you for your kind words and useful comments. In fact, this is my first AUR package (though I've released more packages on PyPI), so I greatly appreciate any improvements for that.

1. I want the installation to update man pages. Otherwise the newly copied man page will remain unknown to the system! In your package do you have a command mandb ?

Can I call this command when I don't require man pages to be installed? (or I could call this command and ignore its possible failure) Should I expect users to call this command manually?

I read Arch Wiki carefully, but could find no solutions for this at that time.

1. Thanks for the suggestion, I shall add my documents to /usr/share/doc !

However, do I have to copy GPL file? I think this license is pre-installed on Arch, didn't find it in the Wiki what to do with that. Sorry about formatting, know no way to check it beforehand.

Thank you for this curious and interesting tool. Long time fan of rsync, and now I'm testing yarsync.

Nice to see that you are both the developer and maintainer of this PKGBUILD.

Here my two comments about this PKGBUILD

• You should remove the "man-db" from the dependencies of this PKGBUILD.
• You should add all the README's, and .md's and docs to this PKGBUILD.

content:

1. You should remove the "man-db" from the dependencies of this PKGBUILD.

I dont understand why you put this:

depends=('python' 'man-db')

I think I've never seen a PKGBUILD with a "mandatory" dependency for "man-db". Except of course those that deal explicitally with man pages.

I assume what you want to do is to install the man page of "yarsync". So you have this.

    install -D docs/yarsync.1.gz ${pkgdir}/usr/share/man/man1/yarsync.1.gz

That is correct. That is enough. You dont have to force the user to install "man-db". Actually you should not mess with that at all.

I think you are confusing the tool to display and manage the man pages, "man-db" or "mandoc", with the man pages itself, that is, the "meat", the content, the files that get installed to /usr/share/man/xyz ... (https://wiki.archlinux.org/title/Man_page)

This is for example the damage and breakage that would be caused in my system:

:: Checking for conflicts...
:: Checking for inner conflicts...
 -> Package conflicts found:
 -> Installing man-db will remove: mandoc (man)
 -> Conflicting packages will have to be confirmed manually
[Repo Make:5]  libpipeline-1.5.7-1  man-db-2.11.2-1  python-pyproject-hooks-1.0.0-1  python-build-0.10.0-1  python-installer-0.6.0-1
[Aur:1]  yarsync-0.2-1

As you can see, if I were to install "yarsync" it would make a big mess on my system. It would force me to install a tool I dont want, "man-db", and force me to remove a tool I want "mandoc".

I my case, like everyone on the planet, I also read and have the same man pages everyone has. But the tool to read them is "man" from the package "mandoc". Not "man" from the package "man-db"

2. You should add all the README's, and .md's and docs to this PKGBUILD.

I see you have a man page. I also see that you have a very interesting README. It takes time to read, understand your points. And you have also more .md's in "docs". Things like "details" etc. And then you have the documentation online.

I dont know if these overlap or not. But I hate to install a PKGBUILD and be forced to go back online to the Internet just to read documentation.

Please make sure every thing usefull to this PKGBUILD ends up in something like, for example:

/usr/share/doc/yarsync/README
/usr/share/doc/yarsync/Advanced.md
/usr/share/doc/yarsync/Tutorial.md
/usr/share/doc/yarsync/Details.md

and

/usr/share/licenses/yarsync/LICENSE.xyz

Thanks in advance ```