Package Details: yt-x 0.4.5-1

Git Clone URL: https://aur.archlinux.org/yt-x.git (read-only, click to copy)
Package Base: yt-x
Description: Browse youtube from your terminal
Upstream URL: https://github.com/Benexl/yt-x
Licenses: GPL
Provides: yt-x
Submitter: denkijin
Maintainer: denkijin
Last Packager: denkijin
Votes: 5
Popularity: 2.23
First Submitted: 2024-11-25 22:21 (UTC)
Last Updated: 2025-02-10 19:07 (UTC)

Latest Comments

1 2 Next › Last »

denkijin commented on 2025-02-11 05:35 (UTC)

I've filed a minimal bug report as the release from github marked as v0.4.5 is actually v0.4.0. so be warned.

justbispo commented on 2025-02-11 00:18 (UTC) (edited on 2025-02-11 00:18 (UTC) by justbispo)

Patch to add them

--- PKGBUILD2   2025-02-11 00:11:09.924770989 +0000
+++ PKGBUILD    2025-02-11 00:06:16.980317333 +0000
@@ -29,4 +29,16 @@
 package() {
   cd "$srcdir/"
   install -D "$srcdir/$pkgname-$pkgver" "$pkgdir/usr/bin/$pkgname"
+
+  # Add zsh and bash when the completions are available
+  for shell in fish; do
+    $pkgname completions --$shell > $shell-completion
+  done
+
+  $pkgname -E > yt-x.desktop
+
+  #install -Dm644 bash-completion "$pkgdir/usr/share/bash-completion/completions/yt-x"
+  install -Dm644 fish-completion "$pkgdir/usr/share/fish/vendor_completions.d/yt-x.fish"
+  #install -Dm644 zsh-completion "$pkgdir/usr/share/zsh/site-functions/_yt-x"
+  install -Dm644 yt-x.desktop "$pkgdir/usr/share/applications/yt-x.desktop"
 }

It's simple and there's no need for people to generate them themselves each time the package updates and adds new options.

vitaliikuzhdin commented on 2025-02-10 21:17 (UTC) (edited on 2025-02-11 00:27 (UTC) by vitaliikuzhdin)

@denkijin, so your solution is to make the user generate the completions and the .desktop entry on their own and install both themselves? On every update? What's even the point of packaging then, if we can always just mv and chmod? And how would a non-privileged user even do that?

Generating completions and other files during the build (well, there is no build here since this is a shell script, but the point stands) is a completely normal practice which is used in the official packages as well and is expected from a good PKGBUILD. You were already given a way you could modify the package process, which would take you no more than 5 minutes.

denkijin commented on 2025-02-10 21:10 (UTC)

I am not adding things that are already in the code and available from the commandline. That's unneeded bloat, sorry, there is no reason to include all those things when it is already in the code.

vitaliikuzhdin commented on 2025-02-10 20:53 (UTC)

@denkijin, you can generate them on the go, see this and the package provided below by @justbispo.

denkijin commented on 2025-02-10 20:49 (UTC)

they are not written as far as I can see, I was not planning to do so! If you check the README.md, and the rest of the code base, you can see that neither of your requests can be found. I suggest if you desire completions, write them and make a pull request to that repo. writing code is outside of the scope of package management.

justbispo commented on 2025-02-10 19:36 (UTC) (edited on 2025-02-10 19:39 (UTC) by justbispo)

Could you include the installation of the completion files? There are multiple ways of doing it, but here's an example of a package I own.

Edit: and the desktop entry too, since yt-x supports it.

denkijin commented on 2025-01-04 19:01 (UTC) (edited on 2025-01-04 19:04 (UTC) by denkijin)

error should be corrected.

1 2 Next › Last »