You don't need to chmod the helper via the install script (e.g.: at install time), you can just do this when packaging.
Here's a diff:
diff --git a/1password.install b/1password.install
index e752514..156badc 100755
--- a/1password.install
+++ b/1password.install
@@ -9,12 +9,6 @@ app_group_exists() {
fi
}
-set_chromesandbox_permissions() {
- # chrome-sandbox requires the setuid bit to be specifically set.
- # See https://github.com/electron/electron/issues/17972
- chmod 4755 /opt/1Password/chrome-sandbox
-}
-
setup_browser_helper() {
# Setup the Core App Integration helper binary with the correct permissions and group
HELPER_PATH="/opt/1Password/1Password-KeyringHelper"
@@ -46,12 +40,10 @@ pre_upgrade() {
}
post_install() {
- set_chromesandbox_permissions
setup_browser_helper
}
post_upgrade() {
- set_chromesandbox_permissions
setup_browser_helper
}
diff --git a/PKGBUILD b/PKGBUILD
index 2e5a93e..680429f 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -46,4 +46,8 @@ package() {
# Symlink /usr/bin executable to opt
install -dm0755 "${pkgdir}"/usr/bin
ln -s /opt/1Password/1password "${pkgdir}"/usr/bin/1password
+
+ # chrome-sandbox requires the setuid bit to be specifically set.
+ # See https://github.com/electron/electron/issues/17972
+ chmod 4755 "${pkgdir}"/opt/1Password/chrome-sandbox
}
I noticed there's some gitlab CI set up in the repo. Is there somewhere better to send an MR instead of a patch here?
Pinned Comments
1Password commented on 2021-07-27 21:07 (UTC) (edited on 2021-09-13 17:52 (UTC) by 1Password)
1Password for Arch Linux - Stable
The source is signed with the GPG key
3FEF9748469ADBE15DA7CA80AC2D62742012EA22
and can be seen on the install-linux guide.Getting Started
Our getting started guide can be found at https://support.1password.com/install-linux/#arch-linux
Support
Our Linux support discussion is available at https://1password.community/categories/linux
Beta Releases
Our beta releases can be found at 1password-beta. Beta releases are more likely to have regressions than our stable releases.